All of lore.kernel.org
 help / color / mirror / Atom feed
From: Linus Torvalds <torvalds@linux-foundation.org>
To: Jens Axboe <axboe@kernel.dk>, Christoph Hellwig <hch@lst.de>
Cc: "linux-block@vger.kernel.org" <linux-block@vger.kernel.org>
Subject: Re: [GIT PULL] Block fix for 5.12 final
Date: Fri, 23 Apr 2021 14:54:36 -0700	[thread overview]
Message-ID: <CAHk-=wi5otGvBvWGx-XC=es88Xghe1TNFEYg_ZwoiZBzRvGeRA@mail.gmail.com> (raw)
In-Reply-To: <c657100e-aef5-0710-2760-1d02f193cab6@kernel.dk>

On Fri, Apr 23, 2021 at 2:06 PM Jens Axboe <axboe@kernel.dk> wrote:
>
> A single fix for a behavioral regression in this series, when re-reading
> the partition table with partitions open.

Hmm. The fact that it's no longer calling blk_drop_partitions() didn't
just mean that the check for "bdev->bd_part_count" was lost (now
re-instated).

It also seems to mean that blkdev_reread_part() no longer does the

        sync_blockdev(bdev);
        invalidate_bdev(bdev);

to write back and invalidate any caches.

Are we sure cache writeback/invalidate isn't needed? Or does it get
done some other place?

            Linus

  reply	other threads:[~2021-04-23 21:54 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-23 21:06 [GIT PULL] Block fix for 5.12 final Jens Axboe
2021-04-23 21:54 ` Linus Torvalds [this message]
2021-04-23 23:18   ` Jens Axboe
2021-04-24  6:52   ` Christoph Hellwig
2021-04-23 21:55 ` pr-tracker-bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAHk-=wi5otGvBvWGx-XC=es88Xghe1TNFEYg_ZwoiZBzRvGeRA@mail.gmail.com' \
    --to=torvalds@linux-foundation.org \
    --cc=axboe@kernel.dk \
    --cc=hch@lst.de \
    --cc=linux-block@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.