Re: [GIT PULL] Block fix for 5.12 final

[Jens Axboe <axboe@kernel.dk>]

On 4/23/21 3:54 PM, Linus Torvalds wrote:
> On Fri, Apr 23, 2021 at 2:06 PM Jens Axboe <axboe@kernel.dk> wrote:
>>
>> A single fix for a behavioral regression in this series, when re-reading
>> the partition table with partitions open.
> 
> Hmm. The fact that it's no longer calling blk_drop_partitions() didn't
> just mean that the check for "bdev->bd_part_count" was lost (now
> re-instated).
> 
> It also seems to mean that blkdev_reread_part() no longer does the
> 
>         sync_blockdev(bdev);
>         invalidate_bdev(bdev);
> 
> to write back and invalidate any caches.
> 
> Are we sure cache writeback/invalidate isn't needed? Or does it get
> done some other place?

Hmm yes, that's a good point, we dropped both of those in the call trace
as part of 4601b4b130de2329fe06df80ed5d77265f2058e5 - Christoph, what
was the reasoning here?

-- 
Jens Axboe