All of lore.kernel.org
 help / color / mirror / Atom feed
From: Linus Torvalds <torvalds@linux-foundation.org>
To: "Jason A. Donenfeld" <Jason@zx2c4.com>
Cc: Linux Crypto Mailing List <linux-crypto@vger.kernel.org>,
	Herbert Xu <herbert@gondor.apana.org.au>
Subject: Re: [PATCH crypto v2] crypto: poly1305 - cleanup stray CRYPTO_LIB_POLY1305_RSIZE
Date: Fri, 27 May 2022 15:19:07 -0700	[thread overview]
Message-ID: <CAHk-=wiGben+GoVuY2qnqKYR7mn6F9kfUkBbTcOt4K7fjAGnog@mail.gmail.com> (raw)
In-Reply-To: <CAHmME9oAqBT5bOd94Na-q_tHHNZqVyU7eLk0odei7-KB07VPRA@mail.gmail.com>

On Fri, May 27, 2022 at 2:16 PM Jason A. Donenfeld <Jason@zx2c4.com> wrote:
>
> Whoops. I sent this to linux-crypto/Herbert assuming that it'd work
> with the "2 weeks pass and nobody complains --> queued up" flow of
> that list.

Well, it's more like "4 months since I complained about this thing",
so I thought it was overdue and applied it..

That said, I don't think CRYPTO_LIB_POLY1305_GENERIC can be set unless
CRYPTO_LIB_POLY1305 is set. And CRYPTO_ARCH_HAVE_LIB_POLY1305 looks
like a bogus thing to test for too - those two just decide if the
arch-specific one or the generic one should be used.

So I think v1 was actually the right one. Possibly

        depends on CRYPTO_LIB_POLY1305 != n

due to the tristate?


                    Linus

      reply	other threads:[~2022-05-27 22:19 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-05-26  9:35 [PATCH crypto] crypto: poly1305 - cleanup stray CRYPTO_LIB_POLY1305_RSIZE Jason A. Donenfeld
2022-05-27  7:34 ` kernel test robot
2022-05-27 20:19   ` [PATCH crypto v2] " Jason A. Donenfeld
     [not found]     ` <CAHk-=whyH8xx=2LVmOdQDTy9RRqBs_JJz_oMV2+6a2myk8+wow@mail.gmail.com>
2022-05-27 21:15       ` Jason A. Donenfeld
2022-05-27 22:19         ` Linus Torvalds [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAHk-=wiGben+GoVuY2qnqKYR7mn6F9kfUkBbTcOt4K7fjAGnog@mail.gmail.com' \
    --to=torvalds@linux-foundation.org \
    --cc=Jason@zx2c4.com \
    --cc=herbert@gondor.apana.org.au \
    --cc=linux-crypto@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.