All of lore.kernel.org
 help / color / mirror / Atom feed
From: Linus Torvalds <torvalds@linux-foundation.org>
To: Linux regressions mailing list <regressions@lists.linux.dev>
Cc: "Jason A. Donenfeld" <Jason@zx2c4.com>,
	Andrew Lunn <andrew@lunn.ch>,
	 Linux Stable <stable@vger.kernel.org>,
	Bagas Sanjaya <bagasdotme@gmail.com>,
	 Sami Korkalainen <sami.korkalainen@proton.me>
Subject: Re: [REGRESSION][BISECTED] Boot stall from merge tag 'net-next-6.2'
Date: Wed, 21 Jun 2023 10:56:06 -0700	[thread overview]
Message-ID: <CAHk-=wiK5oDqgt6=OHLiiAu4VmLy4qn8WQdhvFo+sm26r4UjHw@mail.gmail.com> (raw)
In-Reply-To: <9517bb70-426c-0296-b426-f5b4f075f7c8@leemhuis.info>

On Wed, 21 Jun 2023 at 01:46, Linux regression tracking (Thorsten
Leemhuis) <regressions@leemhuis.info> wrote:
>
> Jason, in that case it seems this is something for you. For the initial
> report, see here:

I'll just revert it for now. Writing EFI variables has always been
fraught with danger - more so than just reading them - and this one
just looks horrible anyway.

Calling execute_with_initialized_rng() can end up having the callback
done under a spinlock with interrupts disabled, which is probably why
it then has that odd double indirection through a one-time work. And
in no situation should we start writing to EFI variables during early
subsystem initialization, I feel.

It also probably shouldn't use the "set_variable" function at all, but
the non-blocking one, and who knows if it should try to do some
serialization with efi/vars.c.

I think it would be better off done in user space, but if we can't
trust user space to do the right thing, at least do it much much
later.

               Linus

  reply	other threads:[~2023-06-21 17:56 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-05-26 19:17 [REGRESSION][BISECTED] Boot stall from merge tag 'net-next-6.2' Sami Korkalainen
2023-05-27  1:17 ` Bagas Sanjaya
2023-05-27  4:07   ` Sami Korkalainen
2023-06-12 14:07     ` Bagas Sanjaya
2023-06-12 19:05       ` Sami Korkalainen
2023-06-12 19:50         ` Andrew Lunn
2023-06-21  6:07           ` Sami Korkalainen
2023-06-21  8:46             ` Linux regression tracking (Thorsten Leemhuis)
2023-06-21 17:56               ` Linus Torvalds [this message]
2023-06-21 18:08                 ` Linus Torvalds
2023-06-22 18:34                   ` Thorsten Leemhuis
2023-06-21 17:57               ` Jason A. Donenfeld
2023-06-23 13:55                 ` Ard Biesheuvel
2023-06-23 17:29                   ` Linus Torvalds
2023-06-23 20:30                     ` Jason A. Donenfeld
2023-06-23 21:52                       ` Linus Torvalds
2023-06-23 22:55                         ` Ard Biesheuvel
2023-06-23 23:02                           ` Linus Torvalds
2023-06-25 15:36                             ` David Laight
2023-06-25 14:40                         ` Jason A. Donenfeld
2023-06-23 18:20                   ` Sami Korkalainen
2023-06-23 18:38                     ` Ard Biesheuvel
2023-06-23 19:01                       ` Linus Torvalds
2023-06-21 18:49               ` Jason A. Donenfeld
2023-06-21 19:51                 ` Linus Torvalds
2023-06-22 13:40                   ` Jason A. Donenfeld
2023-06-22 19:25                     ` Sami Korkalainen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAHk-=wiK5oDqgt6=OHLiiAu4VmLy4qn8WQdhvFo+sm26r4UjHw@mail.gmail.com' \
    --to=torvalds@linux-foundation.org \
    --cc=Jason@zx2c4.com \
    --cc=andrew@lunn.ch \
    --cc=bagasdotme@gmail.com \
    --cc=regressions@lists.linux.dev \
    --cc=sami.korkalainen@proton.me \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.