All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sami Korkalainen <sami.korkalainen@proton.me>
To: Bagas Sanjaya <bagasdotme@gmail.com>
Cc: Andrew Lunn <andrew@lunn.ch>,
	Linus Torvalds <torvalds@linux-foundation.org>,
	Linux Stable <stable@vger.kernel.org>,
	Linux Regressions <regressions@lists.linux.dev>,
	Linux Networking <netdev@vger.kernel.org>,
	Linux ACPI <linux-acpi@vger.kernel.org>,
	"Rafael J. Wysocki" <rafael@kernel.org>,
	"David S. Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@google.com>,
	Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
	"Linux regression tracking (Thorsten Leemhuis)"
	<regressions@leemhuis.info>
Subject: Re: [REGRESSION][BISECTED] Boot stall from merge tag 'net-next-6.2'
Date: Wed, 21 Jun 2023 06:07:59 +0000	[thread overview]
Message-ID: <FNzHwp9-AyweVwIMndmih6VuBD0nsyRp3OM72bmOxpeYszF680jFPJjENIknT32FeaqfVBtVSQFw-5mgE3ZXeksVD8VCFbxwojxP3mSZ9DQ=@proton.me> (raw)
In-Reply-To: <e2ca75ef-d779-4bad-84a5-a9f262dbe213@lunn.ch>

[-- Attachment #1: Type: text/plain, Size: 538 bytes --]

I bisected again. It seems I made some mistake last time, as I got a different result this time. Maybe, because these problematic kernels may boot fine sometimes, like I said before.

Anyway, first bad commit (makes much more sense this time):
e7b813b32a42a3a6281a4fd9ae7700a0257c1d50
efi: random: refresh non-volatile random seed when RNG is initialized

I confirmed that this is the code causing the issue by commenting it out (see the patch file). Without this code, the latest mainline boots fine.

Terveisin
Sami Korkalainen

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: patch.diff --]
[-- Type: text/x-patch; name=patch.diff, Size: 1137 bytes --]

diff --git a/drivers/firmware/efi/efi.c b/drivers/firmware/efi/efi.c
index abeff7dc0b58..c362c807f5d6 100644
--- a/drivers/firmware/efi/efi.c
+++ b/drivers/firmware/efi/efi.c
@@ -360,7 +360,7 @@ static void __init efi_debugfs_init(void)
 #else
 static inline void efi_debugfs_init(void) {}
 #endif
-
+/*
 static void refresh_nv_rng_seed(struct work_struct *work)
 {
 	u8 seed[EFI_RANDOM_SEED_SIZE];
@@ -378,7 +378,7 @@ static int refresh_nv_rng_seed_notification(struct notifier_block *nb, unsigned
 	return NOTIFY_DONE;
 }
 static struct notifier_block refresh_nv_rng_seed_nb = { .notifier_call = refresh_nv_rng_seed_notification };
-
+*/
 /*
  * We register the efi subsystem with the firmware subsystem and the
  * efivars subsystem with the efi subsystem, if the system was booted with
@@ -450,10 +450,10 @@ static int __init efisubsys_init(void)
 	if (efi.coco_secret != EFI_INVALID_TABLE_ADDR)
 		platform_device_register_simple("efi_secret", 0, NULL, 0);
 #endif
-
+/*
 	if (efi_rt_services_supported(EFI_RT_SUPPORTED_SET_VARIABLE))
 		execute_with_initialized_rng(&refresh_nv_rng_seed_nb);
-
+*/
 	return 0;
 
 err_remove_group:

  reply	other threads:[~2023-06-21  6:08 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-05-26 19:17 [REGRESSION][BISECTED] Boot stall from merge tag 'net-next-6.2' Sami Korkalainen
2023-05-27  1:17 ` Bagas Sanjaya
2023-05-27  4:07   ` Sami Korkalainen
2023-06-12 14:07     ` Bagas Sanjaya
2023-06-12 19:05       ` Sami Korkalainen
2023-06-12 19:50         ` Andrew Lunn
2023-06-21  6:07           ` Sami Korkalainen [this message]
2023-06-21  8:46             ` Linux regression tracking (Thorsten Leemhuis)
2023-06-21 17:56               ` Linus Torvalds
2023-06-21 18:08                 ` Linus Torvalds
2023-06-22 18:34                   ` Thorsten Leemhuis
2023-06-21 17:57               ` Jason A. Donenfeld
2023-06-23 13:55                 ` Ard Biesheuvel
2023-06-23 17:29                   ` Linus Torvalds
2023-06-23 20:30                     ` Jason A. Donenfeld
2023-06-23 21:52                       ` Linus Torvalds
2023-06-23 22:55                         ` Ard Biesheuvel
2023-06-23 23:02                           ` Linus Torvalds
2023-06-25 15:36                             ` David Laight
2023-06-25 14:40                         ` Jason A. Donenfeld
2023-06-23 18:20                   ` Sami Korkalainen
2023-06-23 18:38                     ` Ard Biesheuvel
2023-06-23 19:01                       ` Linus Torvalds
2023-06-21 18:49               ` Jason A. Donenfeld
2023-06-21 19:51                 ` Linus Torvalds
2023-06-22 13:40                   ` Jason A. Donenfeld
2023-06-22 19:25                     ` Sami Korkalainen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='FNzHwp9-AyweVwIMndmih6VuBD0nsyRp3OM72bmOxpeYszF680jFPJjENIknT32FeaqfVBtVSQFw-5mgE3ZXeksVD8VCFbxwojxP3mSZ9DQ=@proton.me' \
    --to=sami.korkalainen@proton.me \
    --cc=andrew@lunn.ch \
    --cc=bagasdotme@gmail.com \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=kuba@kernel.org \
    --cc=linux-acpi@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=rafael@kernel.org \
    --cc=regressions@leemhuis.info \
    --cc=regressions@lists.linux.dev \
    --cc=stable@vger.kernel.org \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.