[GIT PULL] XArray updates

[GIT PULL] XArray updates

[Matthew Wilcox]

Hi Linus,

We found some bugs in the DAX conversion to XArray (and one bug which
predated the XArray conversion).  There were a couple of bugs in some of
the higher-level functions, which aren't actually being called in today's
kernel, but surfaced as a result of converting existing radix tree &
IDR users over to the XArray.  Some of the other changes to how the
higher-level APIs work were also motivated by converting various users;
again, they're not in use in today's kernel, so changing them has a low
probability of introducing a bug.

Dan can still trigger a bug in the DAX code with hot-offline/online,
and we're working on tracking that down.

The following changes since commit 651022382c7f8da46cb4872a545ee1da6d097d2a:

  Linux 4.20-rc1 (2018-11-04 15:37:52 -0800)

are available in the Git repository at:

  git://git.infradead.org/users/willy/linux-dax.git xarray

for you to fetch changes up to fffc9a260e38acec3187515738122a3ecb24ac90:

  XArray tests: Add missing locking (2018-11-19 09:41:11 -0500)

----------------------------------------------------------------
Matthew Wilcox (19):
      XArray: Fix xa_for_each with a single element at 0
      XArray: Export __xa_foo to non-GPL modules
      nilfs2: Use xa_erase_irq
      XArray: Regularise xa_reserve
      XArray: Unify xa_cmpxchg and __xa_cmpxchg
      XArray: Turn xa_erase into an exported function
      XArray: Add xa_store_bh() and xa_store_irq()
      XArray: Unify xa_store and __xa_store
      XArray: Handle NULL pointers differently for allocation
      XArray: Fix Documentation
      XArray: Correct xa_store_range
      XArray tests: Correct some 64-bit assumptions
      dax: Remove optimisation from dax_lock_mapping_entry
      dax: Make sure the unlocking entry isn't locked
      dax: Reinstate RCU protection of inode
      dax: Fix dax_unlock_mapping_entry for PMD pages
      dax: Fix huge page faults
      dax: Avoid losing wakeup in dax_lock_mapping_entry
      XArray tests: Add missing locking

 Documentation/core-api/xarray.rst |  52 ++++++--
 fs/dax.c                          |  60 +++++----
 fs/nilfs2/btnode.c                |   4 +-
 include/linux/xarray.h            | 267 +++++++++++++++++++++++++++++---------
 lib/test_xarray.c                 |  50 ++++++-
 lib/xarray.c                      | 139 +++++++++-----------
 6 files changed, 387 insertions(+), 185 deletions(-)

Re: [GIT PULL] XArray updates

[Linus Torvalds]

On Sat, Nov 24, 2018 at 9:32 AM Matthew Wilcox <willy@infradead.org> wrote:
>
>   git://git.infradead.org/users/willy/linux-dax.git xarray

Can you *please* make that a signed tag.

I don't trust infradead.org implicitly, so I really want signed tag
pull requests.  I may not always notice, but when I do, I abort the
pull.

The only site that doesn't need signed tags is kernel.org, which I can
ssh into and I know and trust the security model. And even there I
really prefer signed tags.

                   Linus

Re: [GIT PULL] XArray updates

[Matthew Wilcox]

On Sat, Nov 24, 2018 at 10:04:30AM -0800, Linus Torvalds wrote:
> On Sat, Nov 24, 2018 at 9:32 AM Matthew Wilcox <willy@infradead.org> wrote:
> >
> >   git://git.infradead.org/users/willy/linux-dax.git xarray
> 
> Can you *please* make that a signed tag.

Sure!  I hadn't been paying attention to the signed tag side of things,
so I hope I've done everything OK.

I generated a new key 5EC42E41545C1F5E and signed a new tag
xarray-4.20-rc4

I've signed that key with my old DSA key 2218C81E8E7C03FF which has
about 400 signatures on it, but I understand is not terribly trustable
these days.

Re: [GIT PULL] XArray updates

[Linus Torvalds]

On Sat, Nov 24, 2018 at 6:38 PM Matthew Wilcox <willy@infradead.org> wrote:
>
> I generated a new key 5EC42E41545C1F5E and signed a new tag
> xarray-4.20-rc4

Hmm. Did you publicize it on any keyservers? I'm not finding the key
on pgp.mit.edu or on the sks-keyservers.net pool..

> I've signed that key with my old DSA key 2218C81E8E7C03FF which has
> about 400 signatures on it, but I understand is not terribly trustable
> these days.

.. but at least I can find that one.  I think a 1024-bit DSA key may
be borderline in theory, but it's a lot better than no key at all.

               Linus

Re: [GIT PULL] XArray updates

[Matthew Wilcox]

On Sat, Nov 24, 2018 at 06:49:30PM -0800, Linus Torvalds wrote:
> On Sat, Nov 24, 2018 at 6:38 PM Matthew Wilcox <willy@infradead.org> wrote:
> >
> > I generated a new key 5EC42E41545C1F5E and signed a new tag
> > xarray-4.20-rc4
> 
> Hmm. Did you publicize it on any keyservers? I'm not finding the key
> on pgp.mit.edu or on the sks-keyservers.net pool..

I pushed it out to hkps://hkps.pool.sks-keyservers.net ... as I recall,
pgp.mit.edu is frequently not synchronised well with the other keyservers,
but I'm surprised that one of the sks-keyservers didn't have it.

http://pgpkeys.uk:11371/pks/lookup?search=0x5EC42E41545C1F5E&fingerprint=on&op=index

sees it just fine.

> > I've signed that key with my old DSA key 2218C81E8E7C03FF which has
> > about 400 signatures on it, but I understand is not terribly trustable
> > these days.
> 
> .. but at least I can find that one.  I think a 1024-bit DSA key may
> be borderline in theory, but it's a lot better than no key at all.
> 
>                Linus

Re: [GIT PULL] XArray updates

[Linus Torvalds]

On Sat, Nov 24, 2018 at 7:00 PM Matthew Wilcox <willy@infradead.org> wrote:
>
> I pushed it out to hkps://hkps.pool.sks-keyservers.net ... as I recall,
> pgp.mit.edu is frequently not synchronised well with the other keyservers,
> but I'm surprised that one of the sks-keyservers didn't have it.

I got it now, so it was just some propagation delay or somethinig.

Thanks,
                  Linus

Re: [GIT PULL] XArray updates

[pr-tracker-bot]

The pull request you sent on Sat, 24 Nov 2018 09:32:09 -0800:

> git://git.infradead.org/users/willy/linux-dax.git xarray

has been merged into torvalds/linux.git:
https://git.kernel.org/torvalds/c/e2125dac22f2c9c66c412cd8e049a7305af59f73

Thank you!

-- 
Deet-doot-dot, I am a bot.
https://korg.wiki.kernel.org/userdoc/prtracker