Re: [GIT PULL] printk for 5.20

From: Linus Torvalds <torvalds@linux-foundation.org>
To: Petr Mladek <pmladek@suse.com>
Cc: Sergey Senozhatsky <senozhatsky@chromium.org>,
	Steven Rostedt <rostedt@goodmis.org>,
	John Ogness <john.ogness@linutronix.de>,
	Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
	Rasmus Villemoes <linux@rasmusvillemoes.dk>,
	Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
	Thomas Gleixner <tglx@linutronix.de>, Jan Kara <jack@suse.cz>,
	Peter Zijlstra <peterz@infradead.org>,
	linux-kernel@vger.kernel.org
Subject: Re: [GIT PULL] printk for 5.20
Date: Tue, 2 Aug 2022 20:19:34 -0700	[thread overview]
Message-ID: <CAHk-=wie+VC-R5=Hm=Vrg5PLrJxb1XiV67Efx-9Cr1fBKCWHTQ@mail.gmail.com> (raw)
In-Reply-To: <YufsTLpighCI7qSf@alley>

On Mon, Aug 1, 2022 at 8:08 AM Petr Mladek <pmladek@suse.com> wrote:
>
> - Completely disable printing on consoles with CONFIG_RT.

I don't think this is acceptable.

We don't suddenly change behavior just because some random developer
has decided "this is the RightThing(tm) to do".

Users matter.

For all we know, there may be random users who are playing around with
PREEMPT_RT. They don't *have* to, but they want to.

Just saying "you get no console because you wanted to try it out" is
simply not acceptable.

It's also NOT SANE.

Seriously, even if you have strict RT requirements, you may also have
strict debugging requirements, and if something goes wrong, you want
to KNOW ABOUT IT. At that point, your RT rules may well fly out the
window, because you have more serious problems.

End result: no way will I accept this kind of completely arbitrary and
frankly not very intelligent patch.

If people want to disable console printing, that's THEIR CHOICE. It
could be a new config variable where you ASK people about what they
want. Not this kind of idiotic tying together of things.

And guys, I want to make it really clear how disappointed I am with
the printk tree lately. There seems to be some kind of hardline
religious fervor having taken over to make these kinds of "this is how
it has to be done, screw any sanity or common sense".

There is exactly one thing you should hold sacred: don't break
people's setups. All the rest is just engineering, and a HUGE part of
"engineering" is to realize that everything is a trade-off.

Linux kernel development is a pragmatic thing where existing users and
existing code matters, and you don't get to just throw it all away
because you have some odd personal hangup.

And printing messages to a console is not some "oh, we'll just stop
doing that because you asked for PREEMPT_RT".

Put another way: not only am I not pulling this, I'm concerned that I
will not be pulling printk patches in the future either because of
where these pull requests seem to be trending.

               Linus