All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@kernel.org>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Petr Mladek <pmladek@suse.com>,
	Sergey Senozhatsky <senozhatsky@chromium.org>,
	Steven Rostedt <rostedt@goodmis.org>,
	John Ogness <john.ogness@linutronix.de>,
	Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
	Rasmus Villemoes <linux@rasmusvillemoes.dk>,
	Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
	Thomas Gleixner <tglx@linutronix.de>, Jan Kara <jack@suse.cz>,
	Peter Zijlstra <peterz@infradead.org>,
	linux-kernel@vger.kernel.org
Subject: Re: [GIT PULL] printk for 5.20
Date: Wed, 3 Aug 2022 19:08:51 +0200	[thread overview]
Message-ID: <YuqroyYLQua8y+L3@gmail.com> (raw)
In-Reply-To: <CAHk-=wj0umHOtL1TB_7Tvinoqhxz6BnL-jEC0eQfVihHOmbWjw@mail.gmail.com>


* Linus Torvalds <torvalds@linux-foundation.org> wrote:

> On Wed, Aug 3, 2022 at 8:43 AM Petr Mladek <pmladek@suse.com> wrote:
> >
> > On Tue 2022-08-02 20:19:34, Linus Torvalds wrote:
> > > And printing messages to a console is not some "oh, we'll just stop
> > > doing that because you asked for PREEMPT_RT".
> >
> > My thinking was that PREEMPT_RT was used only by some rather small
> > community that was very well aware of the upstream status. I kind of
> > though that this was their choice.
> 
> Oh, I agree that it probably is a pretty small community.
> 
> And I also think that people who are really into RT are basically
> always going to have extra patches anyway - I think the bulk of the
> core stuff has made it upstream, but not *all* has made it.
> 
> And the "real RT" people tend to also have long lead times - it's not
> just about "we need guaranteed latency", it also tends to be about
> "our hardware is special and stays around for years" too - and likely
> wouldn't ever really use upstream kernels directly anyway.
> 
> In fact, I don't think anybody can currently even enable PREEMPT_RT in
> an upstream kernel anyway without extra patches. Much of the RT
> infrastructure has been merged, but some of the grottier parts are
> literally just "to make it easier to maintain the real external
> patch".
> 
> So I agree with you that in reality it probably wouldn't really affect
> very many people, if any.
> 
> I suspect the most immediate effect would literally be people who want
> to experiment with it, "just because".
> 
> Not the serious RT users who probably have special hardware anyway and
> are likely to also have special debug interfaces (exactly _because_
> they have special latency concerns).

As a side note, Red Hat is productizing -rt, and in general lots of systems 
with non-broken hardware will work mostly fine under -rt. For the really 
hairy hard-realtime usecases a lot of verification is done - often as part 
of the project.

With all the 'edge computing' usecases arising & the automotive industry 
getting much more software-intense, I think it's a safe policy to make -rt 
less special & adhere to the same quality and upstream maintenance 
standards as regular Linux distributions.

In a few years PREEMPT_RT won't be all that special anymore, and working 
consoles are very much part of a usable product.

> So that's why I'd suspect that the actual effect would be on people who 
> just want to tinker with it, and download the necessary RT patches and 
> set up some data acquisition station for their own use or whatever.
> 
> But thinking some more about it, even the "serious RT" people almost 
> certainly don't really want some kind of static "disable it all". Not 
> even if it was a separate Kconfig question like I suggested.
> 
> You'd most likely want it to be dynamic, because things like "log to 
> console" is different at bootup when the system hasn't started yet - you 
> can't really have realtime response when your hardware hasn't even 
> initialized yet - and when things are actually running.
> 
> So I think even then you really just want a "turn off console logging" 
> dynamic flag, not a Kconfig option.
> 
> Which I think we already have, in the form of log levels. No?

Yeah:

  CONFIG_CONSOLE_LOGLEVEL_DEFAULT=7
  CONFIG_CONSOLE_LOGLEVEL_QUIET=4

What we could do is to set the default console loglevel really low by on 
PREEMPT_RT - say to 1. Serious crashes would still show up - but random 
console chatter wouldn't.

Thanks,

	Ingo

  parent reply	other threads:[~2022-08-03 17:09 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-01 15:07 [GIT PULL] printk for 5.20 Petr Mladek
2022-08-01 15:45 ` David Laight
2022-08-02  7:37   ` Petr Mladek
2022-08-03  3:19 ` Linus Torvalds
2022-08-03 14:35   ` Sebastian Andrzej Siewior
2022-08-03 14:46     ` David Laight
2022-08-03 15:43   ` Petr Mladek
2022-08-03 16:06     ` Steven Rostedt
2022-08-03 16:08     ` Linus Torvalds
2022-08-03 16:34       ` Sebastian Andrzej Siewior
2022-08-03 17:08       ` Ingo Molnar [this message]
2022-08-09  1:18   ` Thomas Gleixner
2022-08-11 13:38     ` Daniel Vetter
2022-08-11 13:38       ` Daniel Vetter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YuqroyYLQua8y+L3@gmail.com \
    --to=mingo@kernel.org \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=bigeasy@linutronix.de \
    --cc=jack@suse.cz \
    --cc=john.ogness@linutronix.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@rasmusvillemoes.dk \
    --cc=peterz@infradead.org \
    --cc=pmladek@suse.com \
    --cc=rostedt@goodmis.org \
    --cc=senozhatsky@chromium.org \
    --cc=tglx@linutronix.de \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.