[GIT PULL] Thermal control updates for v5.16-rc1

[GIT PULL] Thermal control updates for v5.16-rc1

[Rafael J. Wysocki]

Hi Linus,

Please pull from the tag

 git://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm.git \
 thermal-5.16-rc1

with top-most commit 46e9f92f31e67385fab8b49c030635415f36b362

 Merge branches 'thermal-int340x', 'thermal-powerclamp' and 'thermal-docs'

on top of commit 3906fe9bb7f1a2c8667ae54e967dc8690824f4ea

 Linux 5.15-rc7

to receive thermal control updates for 5.16-rc1.

These extend the thermal trip point crossing notifications sent via
netlink to contain the temperature causing the trip point to be
crossed, deprecate the user space thermal governor, add new DT
bindings to drivers, move ABI documentation to Documentation/ABI,
fix assorted issues and clean up code.

Specifics:

 - Constify a variable in thermal MMIO driver (Rikard Falkeborn).

 - Add the current temperature in the netlink message when crossing a
   trip point in order to prevent useless back and forth reading from
   userspace (Daniel Lezcano).

 - Add support for the 'HC' variant on PM8998 PMIC in order to support
   VADC channels on recent QCom boards (Bjorn Andersson).

 - Add support for calibration values from hardware when they are
   fused (Niklas Söderlund).

 - Fix NULL pointer dereference in the thermal_release callback when
   an error occurs in the thermal_zone_device_register() (Yuanzheng
   Song).

 - Fix use-after-free in __thermal_cooling_device_register() in the
   error path (Ziyang Xuan).

 - Fix compilation of the LMh driver when CONFIG_QCOM_SCM is not set
   (Jackie Liu).

 - Add timeout when reading a register that can block forever in
   certain circumstances in the tsens driver (Ansuel Smith).

 - Add DT binding for the reset lines and use them in the rockchip
   sensor driver (Johan Jonker).

 - Add new uniphier NX1 SoC temperature sensor (Kunihiko Hayashi).

 - Save and restore the TCC value in the int340x driver (Antoine
   Tenart).

 - Deprecate the writability of the cooling device state sysfs file
   and the user space governor (Daniel Lezcano).

 - Delete bogus length check in int340x (Dan Carpenter).

 - Use bitmap_zalloc/bitmap_free when applicable in intel_powerclamp
   (Christophe JAILLET).

 - Move thermal ABI documentation to Documentation/ABI (Mauro Carvalho
   Chehab).

Thanks!


---------------

Ansuel Smith (1):
      thermal/drivers/tsens: Add timeout to get_temp_tsens_valid

Antoine Tenart (1):
      thermal/drivers/int340x: Improve the tcc offset saving for suspend/resume

Bjorn Andersson (2):
      dt-bindings: thermal: qcom: add HC variant of adc-thermal monitor bindings
      thermal/drivers/qcom/spmi-adc-tm5: Add support for HC variant

Christophe JAILLET (1):
      thermal: intel_powerclamp: Use bitmap_zalloc/bitmap_free when applicable

Dan Carpenter (1):
      thermal: int340x: delete bogus length check

Daniel Lezcano (3):
      thermal/drivers/netlink: Add the temperature when crossing a trip point
      thermal/core: Make the userspace governor deprecated
      thermal/core: Deprecate changing cooling device state from userspace

Jackie Liu (1):
      thermal/drivers/qcom/lmh: make QCOM_LMH depends on QCOM_SCM

Johan Jonker (3):
      dt-bindings: thermal: allow more resets for tsadc node in
rockchip-thermal.yaml
      dt-bindings: thermal: remove redundant comments from rockchip-thermal.yaml
      thermal/drivers/rockchip_thermal: Allow more resets for tsadc node

Kunihiko Hayashi (2):
      dt-bindings: thermal: uniphier: Add binding for NX1 SoC
      thermal/drivers/uniphier: Add compatible string for NX1 SoC

Mauro Carvalho Chehab (1):
      thermal: Move ABI documentation to Documentation/ABI

Niklas Söderlund (2):
      thermal: rcar_gen3_thermal: Store thcode and ptat in priv data
      thermal: rcar_gen3_thermal: Read calibration from hardware

Rikard Falkeborn (1):
      thermal/drivers/thermal_mmio: Constify static struct thermal_mmio_ops

Yuanzheng Song (1):
      thermal/core: Fix null pointer dereference in thermal_release()

Ziyang Xuan (1):
      thermal/core: fix a UAF bug in __thermal_cooling_device_register()

---------------

 Documentation/ABI/testing/sysfs-class-thermal      | 259 +++++++++++++++++++++
 .../bindings/thermal/qcom-spmi-adc-tm-hc.yaml      | 149 ++++++++++++
 .../bindings/thermal/rockchip-thermal.yaml         |  23 +-
 .../thermal/socionext,uniphier-thermal.yaml        |   1 +
 Documentation/driver-api/thermal/sysfs-api.rst     | 225 +-----------------
 MAINTAINERS                                        |   2 +
 drivers/thermal/gov_user_space.c                   |   9 +
 .../intel/int340x_thermal/int3400_thermal.c        |   9 +-
 .../intel/int340x_thermal/int3401_thermal.c        |   8 +-
 .../int340x_thermal/processor_thermal_device.c     |  36 ++-
 .../int340x_thermal/processor_thermal_device.h     |   1 +
 .../int340x_thermal/processor_thermal_device_pci.c |  18 +-
 .../processor_thermal_device_pci_legacy.c          |   8 +-
 drivers/thermal/intel/intel_powerclamp.c           |   8 +-
 drivers/thermal/qcom/Kconfig                       |   2 +-
 drivers/thermal/qcom/qcom-spmi-adc-tm5.c           |  41 +++-
 drivers/thermal/qcom/tsens.c                       |  29 ++-
 drivers/thermal/rcar_gen3_thermal.c                | 113 ++++++---
 drivers/thermal/rockchip_thermal.c                 |   2 +-
 drivers/thermal/thermal_core.c                     |  22 +-
 drivers/thermal/thermal_mmio.c                     |   2 +-
 drivers/thermal/thermal_netlink.c                  |  11 +-
 drivers/thermal/thermal_netlink.h                  |   8 +-
 drivers/thermal/thermal_sysfs.c                    |   3 +
 drivers/thermal/uniphier_thermal.c                 |   4 +
 25 files changed, 679 insertions(+), 314 deletions(-)

Re: [GIT PULL] Thermal control updates for v5.16-rc1

[pr-tracker-bot]

The pull request you sent on Tue, 2 Nov 2021 20:54:53 +0100:

> git://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm.git thermal-5.16-rc1

has been merged into torvalds/linux.git:
https://git.kernel.org/torvalds/c/f73cd9c951a9dc23f0ee1260fef5cc61d2825fb3

Thank you!

-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/prtracker.html

Re: [GIT PULL] Thermal control updates for v5.16-rc1

[Linus Torvalds]

On Tue, Nov 2, 2021 at 12:55 PM Rafael J. Wysocki <rafael@kernel.org> wrote:
>
> Daniel Lezcano (3):
>       thermal/core: Make the userspace governor deprecated

This one is very annoying indeed.

How about making that "pr_warn()" be a "pr_warn_once()"?

Because I don't see the point of

    dmesg  | grep "Userspace governor deprecated" | wc -l
    19

almost immediately after boot.

              Linus

Re: [GIT PULL] Thermal control updates for v5.16-rc1

[Daniel Lezcano]

On 03/11/2021 01:07, Linus Torvalds wrote:
> On Tue, Nov 2, 2021 at 12:55 PM Rafael J. Wysocki <rafael@kernel.org> wrote:
>>
>> Daniel Lezcano (3):
>>       thermal/core: Make the userspace governor deprecated
> 
> This one is very annoying indeed.
> 
> How about making that "pr_warn()" be a "pr_warn_once()"?
> 
> Because I don't see the point of
> 
>     dmesg  | grep "Userspace governor deprecated" | wc -l
>     19
> 
> almost immediately after boot.

Is the platform with 19 thermal zones and default thermal policy set to
userspace governor ?


-- 
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs

Follow Linaro:  <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog

Re: [GIT PULL] Thermal control updates for v5.16-rc1

[Linus Torvalds]

On Wed, Nov 3, 2021 at 12:53 AM Daniel Lezcano
<daniel.lezcano@linaro.org> wrote:
>
> Is the platform with 19 thermal zones and default thermal policy set to
> userspace governor ?

I think it has 11 thermal zones judging by
/sys/class/thermal/thermal_zone* going from 0 to 10.

And the kernel default seems to be

   CONFIG_THERMAL_DEFAULT_GOV_STEP_WISE=y

but presumably this is F34 then setting it to 'userspace' (the kernel
config comes from the F34 one too, although it's been tweaked for the
machine).

I suspect I could just turn off THERMAL_GOV_USER_SPACE and get rid of
the message, that's not the issue.

The issue is "why is the kernel spewing pointlessly the same message
over and over again?"

                      Linus

Re: [GIT PULL] Thermal control updates for v5.16-rc1

[Daniel Lezcano]

On 03/11/2021 16:03, Linus Torvalds wrote:
> On Wed, Nov 3, 2021 at 12:53 AM Daniel Lezcano
> <daniel.lezcano@linaro.org> wrote:
>>
>> Is the platform with 19 thermal zones and default thermal policy set to
>> userspace governor ?
> 
> I think it has 11 thermal zones judging by
> /sys/class/thermal/thermal_zone* going from 0 to 10.
> 
> And the kernel default seems to be
> 
>    CONFIG_THERMAL_DEFAULT_GOV_STEP_WISE=y
> 
> but presumably this is F34 then setting it to 'userspace' (the kernel
> config comes from the F34 one too, although it's been tweaked for the
> machine).
> 
> I suspect I could just turn off THERMAL_GOV_USER_SPACE and get rid of
> the message, that's not the issue.
> 
> The issue is "why is the kernel spewing pointlessly the same message
> over and over again?"

Yes, I agree and I will provide a patch to convert it to pr_warn_once
but having 19 messages sounds like the policy was set several times and
that is surprising.

This is why I asked about the configuration because the message should
appear when one thermal zone is changing the policy to 'user_space' and
that happens once per thermal zone, logically.

I'll send a fix for that and try to figure out what f34 is doing with
the thermal governors.

Thanks

  -- Daniel

-- 
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs

Follow Linaro:  <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog