From: Linus Torvalds <torvalds@linux-foundation.org>
To: Martin Schwidefsky <schwidefsky@de.ibm.com>
Cc: Christoph Hellwig <hch@infradead.org>,
Linux List Kernel Mailing <linux-kernel@vger.kernel.org>,
Michael Ellerman <mpe@ellerman.id.au>,
linuxppc-dev@lists.ozlabs.org,
linux-s390 <linux-s390@vger.kernel.org>
Subject: Re: Linux 5.1-rc5
Date: Tue, 16 Apr 2019 09:16:55 -0700 [thread overview]
Message-ID: <CAHk-=wjKi5C+Onhp5Vs5BQxHbaBud9M3cTS-S6Tr9yDY4dS-Sw@mail.gmail.com> (raw)
In-Reply-To: <20190416140658.2cb73a3f@mschwideX1>
On Tue, Apr 16, 2019 at 5:08 AM Martin Schwidefsky
<schwidefsky@de.ibm.com> wrote:
>
> This is not nice, would a patch like the following be acceptable?
Umm.
We actually already *have* this function.
It's called "gup_fast_permitted()" and it's used by x86-64 to verify
the proper address range. Exactly like s390 needs..
Could you please use that instead?
Linus
WARNING: multiple messages have this Message-ID (diff)
From: Linus Torvalds <torvalds@linux-foundation.org>
To: Martin Schwidefsky <schwidefsky@de.ibm.com>
Cc: Christoph Hellwig <hch@infradead.org>,
linuxppc-dev@lists.ozlabs.org,
Linux List Kernel Mailing <linux-kernel@vger.kernel.org>,
linux-s390 <linux-s390@vger.kernel.org>
Subject: Re: Linux 5.1-rc5
Date: Tue, 16 Apr 2019 09:16:55 -0700 [thread overview]
Message-ID: <CAHk-=wjKi5C+Onhp5Vs5BQxHbaBud9M3cTS-S6Tr9yDY4dS-Sw@mail.gmail.com> (raw)
In-Reply-To: <20190416140658.2cb73a3f@mschwideX1>
On Tue, Apr 16, 2019 at 5:08 AM Martin Schwidefsky
<schwidefsky@de.ibm.com> wrote:
>
> This is not nice, would a patch like the following be acceptable?
Umm.
We actually already *have* this function.
It's called "gup_fast_permitted()" and it's used by x86-64 to verify
the proper address range. Exactly like s390 needs..
Could you please use that instead?
Linus
next prev parent reply other threads:[~2019-04-16 16:17 UTC|newest]
Thread overview: 51+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-14 22:40 Linux 5.1-rc5 Linus Torvalds
2019-04-15 5:19 ` Christoph Hellwig
2019-04-15 16:17 ` Linus Torvalds
2019-04-15 16:17 ` Linus Torvalds
2019-04-16 9:09 ` Martin Schwidefsky
2019-04-16 9:09 ` Martin Schwidefsky
2019-04-16 12:06 ` Martin Schwidefsky
2019-04-16 12:06 ` Martin Schwidefsky
2019-04-16 16:16 ` Linus Torvalds [this message]
2019-04-16 16:16 ` Linus Torvalds
2019-04-16 16:49 ` Linus Torvalds
2019-04-16 16:49 ` Linus Torvalds
2019-04-17 7:46 ` Martin Schwidefsky
2019-04-17 7:46 ` Martin Schwidefsky
2019-04-17 8:02 ` Martin Schwidefsky
2019-04-17 8:02 ` Martin Schwidefsky
2019-04-17 16:57 ` Linus Torvalds
2019-04-17 16:57 ` Linus Torvalds
2019-04-18 8:02 ` Martin Schwidefsky
2019-04-18 8:02 ` Martin Schwidefsky
2019-04-18 15:49 ` Linus Torvalds
2019-04-18 15:49 ` Linus Torvalds
2019-04-18 18:41 ` Martin Schwidefsky
2019-04-18 18:41 ` Martin Schwidefsky
2019-04-19 13:33 ` Martin Schwidefsky
2019-04-19 13:33 ` Martin Schwidefsky
2019-04-19 17:27 ` Linus Torvalds
2019-04-19 17:27 ` Linus Torvalds
2019-04-23 15:38 ` Martin Schwidefsky
2019-04-23 15:38 ` Martin Schwidefsky
2019-04-23 16:06 ` Linus Torvalds
2019-04-23 16:06 ` Linus Torvalds
2019-04-17 3:38 ` Michael Ellerman
2019-04-17 3:38 ` Michael Ellerman
2019-04-17 4:13 ` Linus Torvalds
2019-04-17 4:13 ` Linus Torvalds
2019-05-02 12:21 ` Greg KH
2019-05-02 12:21 ` Greg KH
2019-05-02 14:17 ` Martin Schwidefsky
2019-05-02 14:17 ` Martin Schwidefsky
2019-05-02 14:31 ` Greg KH
2019-05-02 14:31 ` Greg KH
2019-05-02 15:10 ` Martin Schwidefsky
2019-05-02 15:10 ` Martin Schwidefsky
2019-05-20 11:09 ` Greg KH
2019-05-20 11:09 ` Greg KH
2019-05-03 13:31 ` Michael Ellerman
2019-05-03 13:31 ` Michael Ellerman
2019-05-02 23:15 ` Christoph Hellwig
2019-05-02 23:15 ` Christoph Hellwig
2019-05-02 23:15 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAHk-=wjKi5C+Onhp5Vs5BQxHbaBud9M3cTS-S6Tr9yDY4dS-Sw@mail.gmail.com' \
--to=torvalds@linux-foundation.org \
--cc=hch@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mpe@ellerman.id.au \
--cc=schwidefsky@de.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.