All of lore.kernel.org
 help / color / mirror / Atom feed
From: Linus Torvalds <torvalds@linux-foundation.org>
To: Michael Stapelberg <michael@stapelberg.ch>,
	Maxime Ripard <maxime@cerno.tech>,  Emma Anholt <emma@anholt.net>,
	Sudip Mukherjee <sudipm.mukherjee@gmail.com>
Cc: dri-devel <dri-devel@lists.freedesktop.org>,
	 Felix Kuehling <felix.kuehling@amd.com>,
	Dave Airlie <airlied@gmail.com>
Subject: Re: [git pull] drm for 5.14-rc1
Date: Sat, 18 Sep 2021 12:24:40 -0700	[thread overview]
Message-ID: <CAHk-=wjuN8afLz-QnefNgt2qKAOY7cez_63oAkdDmTu4Wscv_g@mail.gmail.com> (raw)
In-Reply-To: <871r5mp7h2.fsf@midna.i-did-not-set--mail-host-address--so-tickle-me>

On Sat, Sep 18, 2021 at 2:18 AM Michael Stapelberg
<michael@stapelberg.ch> wrote:
>
> torvalds at linux-foundation.org (Linus Torvalds) writes:
> > Did I fix it up correctly? Who knows. The code makes more sense to me
> > now and seems valid. But I really *really* want to stress how locking
> > is important.
>
> As far as I can tell, this merge conflict resolution made my Raspberry
> Pi 3 hang on boot.

Ok, that's a different merge issue than the locking one (which is
about the amd ttm code).

But the VC4 driver did have changes close to each other in the hdmi
detection and clock setting code.

And it doesn't seem to be just RPi3, there was a report back a couple
of weeks ago about RPi4 also having regressed (with an Ubuntu
install). That one was an oops in vc4_hdmi_audio_prepare(). I don't
know if that got resolved, I heard nothing about it after the report.

So there's something seriously wrong in VC4 space.

The main issue seems to be the runtime power management changes. As
far as I can tell, the commits that didn't come in through that drm
pull were these two

  9984d6664ce9 ("drm/vc4: hdmi: Make sure the controller is powered in detect")
  411efa18e4b0 ("drm/vc4: hdmi: Move the HSM clock enable to runtime_pm")

Michael - do things work if you revert those two (sadly, they don't
revert cleanly exactly _because_ of the other changes in the same
area)?

Maxime?

             Linus

  parent reply	other threads:[~2021-09-18 19:25 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-01  4:34 [git pull] drm for 5.14-rc1 Dave Airlie
2021-07-01  4:34 ` Dave Airlie
2021-07-01 20:15 ` Linus Torvalds
2021-07-01 20:15   ` Linus Torvalds
2021-07-01 21:31   ` Felix Kuehling
2021-07-01 21:31     ` Felix Kuehling
2021-09-18  9:18   ` Michael Stapelberg
2021-09-18 10:09     ` Simon Ser
2021-09-18 19:24     ` Linus Torvalds [this message]
2021-09-18 20:13       ` Michael Stapelberg
2021-09-18 22:12         ` Linus Torvalds
2021-09-19  7:26           ` Michael Stapelberg
2021-09-18 22:00       ` Sudip Mukherjee
2021-09-18 22:15         ` Linus Torvalds
2021-09-18 22:47           ` Sudip Mukherjee
2021-09-18 23:06             ` Linus Torvalds
2021-09-19 11:05               ` Sudip Mukherjee
2021-09-19 17:19                 ` Linus Torvalds
2021-09-20 12:17                   ` Maxime Ripard
2021-09-20 12:50                     ` Sudip Mukherjee
2021-09-20 17:10                     ` Linus Torvalds
2021-09-20 17:32                       ` Maxime Ripard
2021-09-20 17:47                         ` Linus Torvalds
2021-09-22 11:54                           ` Maxime Ripard
2021-09-20  8:55     ` Maxime Ripard
2021-09-20 12:18       ` Maxime Ripard
2021-07-01 20:24 ` pr-tracker-bot
2021-07-01 20:24   ` pr-tracker-bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAHk-=wjuN8afLz-QnefNgt2qKAOY7cez_63oAkdDmTu4Wscv_g@mail.gmail.com' \
    --to=torvalds@linux-foundation.org \
    --cc=airlied@gmail.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=emma@anholt.net \
    --cc=felix.kuehling@amd.com \
    --cc=maxime@cerno.tech \
    --cc=michael@stapelberg.ch \
    --cc=sudipm.mukherjee@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.