All of lore.kernel.org
 help / color / mirror / Atom feed
From: Catalin Marinas <catalin.marinas@arm.com>
To: Joonsoo Kim <iamjoonsoo.kim@lge.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
	Christoph Lameter <cl@linux.com>,
	Pekka Enberg <penberg@kernel.org>,
	David Rientjes <rientjes@google.com>,
	linux-mm <linux-mm@kvack.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Jesper Dangaard Brouer <brouer@redhat.com>
Subject: Re: [PATCH 2/6] mm/slab: remove kmemleak_erase() call
Date: Thu, 8 Jan 2015 12:01:43 +0000	[thread overview]
Message-ID: <CAHkRjk6Lfm4aOHaw6M7ug6DxvmKr1RtuqzfB6k2moJW9VvHAUQ@mail.gmail.com> (raw)
In-Reply-To: <1420421851-3281-3-git-send-email-iamjoonsoo.kim@lge.com>

On 5 January 2015 at 01:37, Joonsoo Kim <iamjoonsoo.kim@lge.com> wrote:
> We already call kmemleak_no_scan() in initialization step of array cache,
> so kmemleak doesn't scan array cache. Therefore, we don't need to call
> kmemleak_erase() here.
>
> And, this call is the last caller of kmemleak_erase(), so remove
> kmemleak_erase() definition completely.

Good point.

Acked-by: Catalin Marinas <catalin.marinas@arm.com>

-- 
Catalin

WARNING: multiple messages have this Message-ID (diff)
From: Catalin Marinas <catalin.marinas@arm.com>
To: Joonsoo Kim <iamjoonsoo.kim@lge.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
	Christoph Lameter <cl@linux.com>,
	Pekka Enberg <penberg@kernel.org>,
	David Rientjes <rientjes@google.com>,
	linux-mm <linux-mm@kvack.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Jesper Dangaard Brouer <brouer@redhat.com>
Subject: Re: [PATCH 2/6] mm/slab: remove kmemleak_erase() call
Date: Thu, 8 Jan 2015 12:01:43 +0000	[thread overview]
Message-ID: <CAHkRjk6Lfm4aOHaw6M7ug6DxvmKr1RtuqzfB6k2moJW9VvHAUQ@mail.gmail.com> (raw)
In-Reply-To: <1420421851-3281-3-git-send-email-iamjoonsoo.kim@lge.com>

On 5 January 2015 at 01:37, Joonsoo Kim <iamjoonsoo.kim@lge.com> wrote:
> We already call kmemleak_no_scan() in initialization step of array cache,
> so kmemleak doesn't scan array cache. Therefore, we don't need to call
> kmemleak_erase() here.
>
> And, this call is the last caller of kmemleak_erase(), so remove
> kmemleak_erase() definition completely.

Good point.

Acked-by: Catalin Marinas <catalin.marinas@arm.com>

-- 
Catalin

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  reply	other threads:[~2015-01-08 12:02 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-05  1:37 [PATCH 0/6] mm/slab: optimize allocation fastpath Joonsoo Kim
2015-01-05  1:37 ` Joonsoo Kim
2015-01-05  1:37 ` [PATCH 1/6] mm/slab: fix gfp flags of percpu allocation at boot phase Joonsoo Kim
2015-01-05  1:37   ` Joonsoo Kim
2015-01-05  1:37 ` [PATCH 2/6] mm/slab: remove kmemleak_erase() call Joonsoo Kim
2015-01-05  1:37   ` Joonsoo Kim
2015-01-08 12:01   ` Catalin Marinas [this message]
2015-01-08 12:01     ` Catalin Marinas
2015-01-05  1:37 ` [PATCH 3/6] mm/slab: clean-up __ac_get_obj() to prepare future changes Joonsoo Kim
2015-01-05  1:37   ` Joonsoo Kim
2015-01-05  1:37 ` [PATCH 4/6] mm/slab: rearrange irq management Joonsoo Kim
2015-01-05  1:37   ` Joonsoo Kim
2015-01-05  1:37 ` [PATCH 5/6] mm/slab: cleanup ____cache_alloc() Joonsoo Kim
2015-01-05  1:37   ` Joonsoo Kim
2015-01-05  1:37 ` [PATCH 6/6] mm/slab: allocation fastpath without disabling irq Joonsoo Kim
2015-01-05  1:37   ` Joonsoo Kim
2015-01-05 15:28   ` Christoph Lameter
2015-01-05 15:28     ` Christoph Lameter
2015-01-06  1:04     ` Joonsoo Kim
2015-01-06  1:04       ` Joonsoo Kim
2015-01-05 17:21   ` Andreas Mohr
2015-01-05 17:21     ` Andreas Mohr
2015-01-05 17:52     ` Christoph Lameter
2015-01-05 17:52       ` Christoph Lameter
2015-01-06  1:31     ` Joonsoo Kim
2015-01-06  1:31       ` Joonsoo Kim
2015-01-06 10:34       ` Andreas Mohr
2015-01-06 10:34         ` Andreas Mohr
2015-01-06 15:33         ` Christoph Lameter
2015-01-06 15:33           ` Christoph Lameter
2015-01-06 16:26           ` Andreas Mohr
2015-01-06 16:26             ` Andreas Mohr
2015-01-08  7:54         ` Joonsoo Kim
2015-01-08  7:54           ` Joonsoo Kim

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAHkRjk6Lfm4aOHaw6M7ug6DxvmKr1RtuqzfB6k2moJW9VvHAUQ@mail.gmail.com \
    --to=catalin.marinas@arm.com \
    --cc=akpm@linux-foundation.org \
    --cc=brouer@redhat.com \
    --cc=cl@linux.com \
    --cc=iamjoonsoo.kim@lge.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=penberg@kernel.org \
    --cc=rientjes@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.