From: Fabio Porcedda <fabio.porcedda@gmail.com>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Sascha Hauer <s.hauer@pengutronix.de>,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-media <linux-media@vger.kernel.org>,
linux-ide <linux-ide@vger.kernel.org>,
lm-sensors <lm-sensors@lm-sensors.org>,
linux-input <linux-input@vger.kernel.org>,
linux-fbdev <linux-fbdev@vger.kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
H Hartley Sweeten <hsweeten@visionengravers.com>,
Hans-Christian Egtvedt <hans-christian.egtvedt@atmel.com>,
Grant Likely <grant.likely@secretlab.ca>
Subject: Re: [PATCH 10/10] drivers: misc: use module_platform_driver_probe()
Date: Fri, 15 Mar 2013 19:09:18 +0100 [thread overview]
Message-ID: <CAHkwnC_4kVGcs03_6RVNrye21aUHsCWf9rQe=2JP_Nkjk8Yczw@mail.gmail.com> (raw)
In-Reply-To: <201303151128.48432.arnd@arndb.de>
On Fri, Mar 15, 2013 at 12:28 PM, Arnd Bergmann <arnd@arndb.de> wrote:
> On Friday 15 March 2013, Fabio Porcedda wrote:
>> >> * Regarding the use of module_platform_driver_probe, I'm a little worried about
>> >> the interactions with deferred probing. I don't think there are any regressions,
>> >> but we should probably make people aware that one cannot return -EPROBE_DEFER
>> >> from a platform_driver_probe function.
>>
>> The use of module_platform_driver_probe() doesn't change anything about that,
>> it's exactly the same thing as using "return platform_driver_probe()".
>> I'm right or I'm missing something? Maybe are you just speaking about
>> the misuse of "platform_driver_probe"?
>
> Yes, that was what I meant. The point is that if we need to review or remove
> all uses of platform_driver_probe, it would be better not to introduce a
> module_platform_driver_probe() interface to make it easier to use.
Just to let you know, the module_platform_driver_probe() macro is
already in v3.9-rc1 and is already used by some drivers.
In linux-next there are already many patches that use that macro.
Best regards
--
Fabio Porcedda
WARNING: multiple messages have this Message-ID (diff)
From: Fabio Porcedda <fabio.porcedda@gmail.com>
To: linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 10/10] drivers: misc: use module_platform_driver_probe()
Date: Fri, 15 Mar 2013 18:09:18 +0000 [thread overview]
Message-ID: <CAHkwnC_4kVGcs03_6RVNrye21aUHsCWf9rQe=2JP_Nkjk8Yczw@mail.gmail.com> (raw)
In-Reply-To: <201303151128.48432.arnd@arndb.de>
On Fri, Mar 15, 2013 at 12:28 PM, Arnd Bergmann <arnd@arndb.de> wrote:
> On Friday 15 March 2013, Fabio Porcedda wrote:
>> >> * Regarding the use of module_platform_driver_probe, I'm a little worried about
>> >> the interactions with deferred probing. I don't think there are any regressions,
>> >> but we should probably make people aware that one cannot return -EPROBE_DEFER
>> >> from a platform_driver_probe function.
>>
>> The use of module_platform_driver_probe() doesn't change anything about that,
>> it's exactly the same thing as using "return platform_driver_probe()".
>> I'm right or I'm missing something? Maybe are you just speaking about
>> the misuse of "platform_driver_probe"?
>
> Yes, that was what I meant. The point is that if we need to review or remove
> all uses of platform_driver_probe, it would be better not to introduce a
> module_platform_driver_probe() interface to make it easier to use.
Just to let you know, the module_platform_driver_probe() macro is
already in v3.9-rc1 and is already used by some drivers.
In linux-next there are already many patches that use that macro.
Best regards
--
Fabio Porcedda
WARNING: multiple messages have this Message-ID (diff)
From: fabio.porcedda@gmail.com (Fabio Porcedda)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 10/10] drivers: misc: use module_platform_driver_probe()
Date: Fri, 15 Mar 2013 19:09:18 +0100 [thread overview]
Message-ID: <CAHkwnC_4kVGcs03_6RVNrye21aUHsCWf9rQe=2JP_Nkjk8Yczw@mail.gmail.com> (raw)
In-Reply-To: <201303151128.48432.arnd@arndb.de>
On Fri, Mar 15, 2013 at 12:28 PM, Arnd Bergmann <arnd@arndb.de> wrote:
> On Friday 15 March 2013, Fabio Porcedda wrote:
>> >> * Regarding the use of module_platform_driver_probe, I'm a little worried about
>> >> the interactions with deferred probing. I don't think there are any regressions,
>> >> but we should probably make people aware that one cannot return -EPROBE_DEFER
>> >> from a platform_driver_probe function.
>>
>> The use of module_platform_driver_probe() doesn't change anything about that,
>> it's exactly the same thing as using "return platform_driver_probe()".
>> I'm right or I'm missing something? Maybe are you just speaking about
>> the misuse of "platform_driver_probe"?
>
> Yes, that was what I meant. The point is that if we need to review or remove
> all uses of platform_driver_probe, it would be better not to introduce a
> module_platform_driver_probe() interface to make it easier to use.
Just to let you know, the module_platform_driver_probe() macro is
already in v3.9-rc1 and is already used by some drivers.
In linux-next there are already many patches that use that macro.
Best regards
--
Fabio Porcedda
next prev parent reply other threads:[~2013-03-15 18:09 UTC|newest]
Thread overview: 148+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-14 13:11 [PATCH 00/10] Use module_platform_driver_probe() part 2 Fabio Porcedda
2013-03-14 13:11 ` [lm-sensors] " Fabio Porcedda
2013-03-14 13:11 ` Fabio Porcedda
2013-03-14 13:11 ` Fabio Porcedda
2013-03-14 13:11 ` [PATCH 01/10] drivers: media: use module_platform_driver_probe() Fabio Porcedda
2013-03-14 13:11 ` Fabio Porcedda
2013-03-14 13:11 ` Fabio Porcedda
2013-03-14 13:25 ` Guennadi Liakhovetski
2013-03-14 13:25 ` Guennadi Liakhovetski
2013-03-14 13:25 ` Guennadi Liakhovetski
2013-03-14 16:40 ` Fabio Porcedda
2013-03-14 16:40 ` Fabio Porcedda
2013-03-14 16:40 ` Fabio Porcedda
2013-03-14 13:11 ` [PATCH] drivers: misc: " Fabio Porcedda
2013-03-14 13:11 ` [lm-sensors] " Fabio Porcedda
2013-03-14 13:11 ` Fabio Porcedda
2013-03-14 13:11 ` Fabio Porcedda
2013-03-14 13:11 ` [PATCH 02/10] drivers: ata: " Fabio Porcedda
2013-03-14 13:11 ` [lm-sensors] " Fabio Porcedda
2013-03-14 13:11 ` Fabio Porcedda
2013-03-14 13:11 ` Fabio Porcedda
2013-03-14 13:11 ` [PATCH 03/10] drivers: char: " Fabio Porcedda
2013-03-14 13:11 ` Fabio Porcedda
2013-03-14 13:11 ` Fabio Porcedda
2013-03-14 13:11 ` Fabio Porcedda
2013-03-14 13:11 ` Fabio Porcedda
2013-03-14 13:11 ` [PATCH 04/10] drivers: hwmon: " Fabio Porcedda
2013-03-14 13:11 ` [lm-sensors] " Fabio Porcedda
2013-03-14 13:11 ` Fabio Porcedda
2013-03-14 13:11 ` Fabio Porcedda
2013-03-14 14:01 ` Guenter Roeck
2013-03-14 14:01 ` [lm-sensors] " Guenter Roeck
2013-03-14 14:01 ` Guenter Roeck
2013-03-14 14:01 ` Guenter Roeck
2013-03-14 16:42 ` Fabio Porcedda
2013-03-14 16:42 ` [lm-sensors] " Fabio Porcedda
2013-03-14 16:42 ` Fabio Porcedda
2013-03-14 16:42 ` Fabio Porcedda
2013-03-14 13:11 ` [PATCH 05/10] drivers: ide: " Fabio Porcedda
2013-03-14 13:11 ` [lm-sensors] " Fabio Porcedda
2013-03-14 13:11 ` Fabio Porcedda
2013-03-14 13:11 ` Fabio Porcedda
2013-03-14 13:11 ` [PATCH 06/10] drivers: input: " Fabio Porcedda
2013-03-14 13:11 ` Fabio Porcedda
2013-03-14 13:11 ` Fabio Porcedda
2013-03-14 13:11 ` [PATCH 07/10] drivers: memory: " Fabio Porcedda
2013-03-14 13:11 ` Fabio Porcedda
2013-03-14 13:11 ` Fabio Porcedda
2013-03-14 13:11 ` [PATCH 08/10] drivers: mfd: " Fabio Porcedda
2013-03-14 13:11 ` Fabio Porcedda
2013-03-14 13:11 ` Fabio Porcedda
2013-04-09 8:06 ` Samuel Ortiz
2013-04-09 8:06 ` Samuel Ortiz
2013-04-09 8:06 ` Samuel Ortiz
2013-04-09 9:23 ` Fabio Porcedda
2013-04-09 9:23 ` Fabio Porcedda
2013-04-09 9:23 ` Fabio Porcedda
2013-04-09 9:23 ` Fabio Porcedda
2013-04-09 9:23 ` Fabio Porcedda
2013-03-14 13:11 ` [PATCH 09/10] drivers: video: " Fabio Porcedda
2013-03-14 13:11 ` Fabio Porcedda
2013-03-14 13:11 ` Fabio Porcedda
2013-03-14 13:11 ` [PATCH 10/10] drivers: misc: " Fabio Porcedda
2013-03-14 13:11 ` [lm-sensors] " Fabio Porcedda
2013-03-14 13:11 ` Fabio Porcedda
2013-03-14 13:11 ` Fabio Porcedda
2013-03-14 13:58 ` Arnd Bergmann
2013-03-14 13:58 ` Arnd Bergmann
2013-03-14 13:58 ` Arnd Bergmann
2013-03-14 14:06 ` Sascha Hauer
2013-03-14 14:06 ` Sascha Hauer
2013-03-14 14:06 ` Sascha Hauer
2013-03-15 11:18 ` Fabio Porcedda
2013-03-15 11:18 ` Fabio Porcedda
2013-03-15 11:18 ` Fabio Porcedda
2013-03-15 11:28 ` Arnd Bergmann
2013-03-15 11:28 ` Arnd Bergmann
2013-03-15 11:28 ` Arnd Bergmann
2013-03-15 11:28 ` Arnd Bergmann
2013-03-15 18:09 ` Fabio Porcedda [this message]
2013-03-15 18:09 ` Fabio Porcedda
2013-03-15 18:09 ` Fabio Porcedda
2013-03-15 17:43 ` H Hartley Sweeten
2013-03-15 17:43 ` H Hartley Sweeten
2013-03-15 17:43 ` H Hartley Sweeten
2013-03-15 17:43 ` H Hartley Sweeten
2013-03-15 20:18 ` Arnd Bergmann
2013-03-15 20:18 ` Arnd Bergmann
2013-03-15 20:18 ` Arnd Bergmann
2013-03-15 20:18 ` Arnd Bergmann
2013-03-15 20:18 ` Arnd Bergmann
2013-03-18 10:03 ` Fabio Porcedda
2013-03-18 10:03 ` Fabio Porcedda
2013-03-18 10:03 ` Fabio Porcedda
2013-03-18 10:03 ` Fabio Porcedda
2013-03-18 10:58 ` Arnd Bergmann
2013-03-18 10:58 ` Arnd Bergmann
2013-03-18 10:58 ` Arnd Bergmann
2013-03-18 10:58 ` Arnd Bergmann
2013-03-18 10:58 ` Arnd Bergmann
2013-03-18 11:20 ` Fabio Porcedda
2013-03-18 11:20 ` Fabio Porcedda
2013-03-18 11:20 ` Fabio Porcedda
2013-03-18 11:20 ` Fabio Porcedda
2013-03-18 11:28 ` Arnd Bergmann
2013-03-18 11:28 ` Arnd Bergmann
2013-03-18 11:28 ` Arnd Bergmann
2013-03-18 11:28 ` Arnd Bergmann
2013-03-19 8:55 ` Fabio Porcedda
2013-03-19 8:55 ` Fabio Porcedda
2013-03-19 8:55 ` Fabio Porcedda
2013-03-19 8:55 ` Fabio Porcedda
2013-03-19 9:04 ` Geert Uytterhoeven
2013-03-19 9:04 ` Geert Uytterhoeven
2013-03-19 9:04 ` Geert Uytterhoeven
2013-03-19 9:04 ` Geert Uytterhoeven
2013-03-19 16:48 ` Arnd Bergmann
2013-03-19 16:48 ` Arnd Bergmann
2013-03-19 16:48 ` Arnd Bergmann
2013-03-19 16:48 ` Arnd Bergmann
2013-03-19 17:11 ` Fabio Porcedda
2013-03-19 17:11 ` Fabio Porcedda
2013-03-19 17:11 ` Fabio Porcedda
2013-03-19 17:11 ` Fabio Porcedda
2013-03-19 17:59 ` Arnd Bergmann
2013-03-19 17:59 ` Arnd Bergmann
2013-03-19 17:59 ` Arnd Bergmann
2013-03-19 17:59 ` Arnd Bergmann
2013-03-20 9:02 ` Fabio Porcedda
2013-03-20 9:02 ` Fabio Porcedda
2013-03-20 9:02 ` Fabio Porcedda
2013-03-20 9:02 ` Fabio Porcedda
2013-03-20 10:20 ` Arnd Bergmann
2013-03-20 10:20 ` Arnd Bergmann
2013-03-20 10:20 ` Arnd Bergmann
2013-03-20 10:20 ` Arnd Bergmann
2013-03-20 10:39 ` Fabio Porcedda
2013-03-20 10:39 ` Fabio Porcedda
2013-03-20 10:39 ` Fabio Porcedda
2013-03-20 10:39 ` Fabio Porcedda
2013-03-20 11:46 ` Arnd Bergmann
2013-03-20 11:46 ` Arnd Bergmann
2013-03-20 11:46 ` Arnd Bergmann
2013-03-20 11:46 ` Arnd Bergmann
2013-03-21 13:10 ` Fabio Porcedda
2013-03-21 13:10 ` Fabio Porcedda
2013-03-21 13:10 ` Fabio Porcedda
2013-03-21 13:10 ` Fabio Porcedda
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAHkwnC_4kVGcs03_6RVNrye21aUHsCWf9rQe=2JP_Nkjk8Yczw@mail.gmail.com' \
--to=fabio.porcedda@gmail.com \
--cc=arnd@arndb.de \
--cc=grant.likely@secretlab.ca \
--cc=gregkh@linuxfoundation.org \
--cc=hans-christian.egtvedt@atmel.com \
--cc=hsweeten@visionengravers.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-ide@vger.kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=lm-sensors@lm-sensors.org \
--cc=s.hauer@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.