* [Qemu-devel] [PATCH for-3.0] tcg/i386: Mark xmm registers call-clobbered
@ 2018-07-23 1:29 Richard Henderson
2018-07-23 12:08 ` Jason A. Donenfeld
0 siblings, 1 reply; 2+ messages in thread
From: Richard Henderson @ 2018-07-23 1:29 UTC (permalink / raw)
To: qemu-devel; +Cc: Jason, qemu-stable
When host vector registers and operations were introduced, I failed
to mark the registers call clobbered as required by the ABI.
Fixes: 770c2fc7bb7
Cc: qemu-stable@nongnu.org
Reported-by: Jason A. Donenfeld <Jason@zx2c4.com>
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
---
tcg/i386/tcg-target.inc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tcg/i386/tcg-target.inc.c b/tcg/i386/tcg-target.inc.c
index e87b0d445e..a91e4f1313 100644
--- a/tcg/i386/tcg-target.inc.c
+++ b/tcg/i386/tcg-target.inc.c
@@ -3532,7 +3532,7 @@ static void tcg_target_init(TCGContext *s)
tcg_target_available_regs[TCG_TYPE_V256] = ALL_VECTOR_REGS;
}
- tcg_target_call_clobber_regs = 0;
+ tcg_target_call_clobber_regs = ALL_VECTOR_REGS;
tcg_regset_set_reg(tcg_target_call_clobber_regs, TCG_REG_EAX);
tcg_regset_set_reg(tcg_target_call_clobber_regs, TCG_REG_EDX);
tcg_regset_set_reg(tcg_target_call_clobber_regs, TCG_REG_ECX);
--
2.17.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [Qemu-devel] [PATCH for-3.0] tcg/i386: Mark xmm registers call-clobbered
2018-07-23 1:29 [Qemu-devel] [PATCH for-3.0] tcg/i386: Mark xmm registers call-clobbered Richard Henderson
@ 2018-07-23 12:08 ` Jason A. Donenfeld
0 siblings, 0 replies; 2+ messages in thread
From: Jason A. Donenfeld @ 2018-07-23 12:08 UTC (permalink / raw)
To: richard.henderson; +Cc: QEMU Developers, qemu-stable
Hi Richard,
I can confirm this fixes the issue.
https://www.wireguard.com/build-status/ is now all green again.
Thanks,
Jason
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-07-23 12:08 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-07-23 1:29 [Qemu-devel] [PATCH for-3.0] tcg/i386: Mark xmm registers call-clobbered Richard Henderson
2018-07-23 12:08 ` Jason A. Donenfeld
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.