TX counters not updated on wireguard interface

TX counters not updated on wireguard interface

[Baptiste Jonglez]

[-- Attachment #1: Type: text/plain, Size: 613 bytes --]

Hi,

While trying 0.0.20170421-2 on Debian jessie, I noticed that the TX
counters are not updated:

$ ip -s link show
7: wg: <POINTOPOINT,NOARP,UP,LOWER_UP> mtu 1420 qdisc noqueue state UNKNOWN mode DEFAULT group default
    link/none
    RX: bytes  packets  errors  dropped overrun mcast
    4384059324 4073303  0       0       0       0
    TX: bytes  packets  errors  dropped carrier collsns
    0          0        0       0       0       0

This is after a bidirectional TCP iperf, so they has been some trafic in
both directions.  Bandwidth monitors like bmon also don't show any
outgoing trafic.

Baptiste

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

Re: TX counters not updated on wireguard interface

[Jason A. Donenfeld]

Hey Baptiste,

I'll try to reproduce this shortly. I did make a change to some compat
code [1] for kernels older than 3.12 to fix a similar bug. But Jesse
has a newer kernel than that, I think? I'll check into it and try to
fix. Thanks for reporting.

Jason

[1] https://git.zx2c4.com/WireGuard/patch/?id=1370d96432c2c7e86705ce99b1682a3b7c2ce1cd

Re: TX counters not updated on wireguard interface

[Jason A. Donenfeld]

Okay I figured it out. Upstream
039f50629b7f860f36644ed1f34b27da9aa62f43 only came in 4.5, so explicit
calls to iptunnel_xmit_stats is required. I'll play with this and see
if I can fix it.

Jason

Re: TX counters not updated on wireguard interface

[Jason A. Donenfeld]

Hey again,

I've committed a fix [1] for this which will be out in the next
snapshot. I've also added a test [2] for this to the automated test
suite on https://build.wireguard.io/ so that if the bug ever
resurfaces, it will be caught. Before reading [1], be sure to wear
protective eyewear, as your pupils are likely to start bleeding at the
sight of horrendous compatibility ifdef hackery.

Jason

[1] https://git.zx2c4.com/WireGuard/commit/?id=4c294b7ec676105abc3abb3a3dd65a63a3466eb2
[2] https://git.zx2c4.com/WireGuard/commit/?id=5437b87afcfed371b31eff25f15663f3d43ca065