All of lore.kernel.org
 help / color / mirror / Atom feed
* CentOS kernel module build failure
@ 2017-10-04 14:03 Andrey Petrov
  2017-10-05  4:37 ` Jason A. Donenfeld
  0 siblings, 1 reply; 5+ messages in thread
From: Andrey Petrov @ 2017-10-04 14:03 UTC (permalink / raw)
  To: wireguard

[-- Attachment #1: Type: text/plain, Size: 11364 bytes --]

Hi,


Up-to-date CentOS Linux release 7.4.1708

$ uname -r

3.10.0-693.2.2.el7.x86_64


Followed the official instructions at https://www.wireguard.com/install/ to install the latest wireguard snapshot on a fully up-to-date CentOS 7.4 but the kernel module compilation failed:

$ cat /var/lib/dkms/wireguard/0.0.20171001/build/make.log
DKMS make.log for wireguard-0.0.20171001 for kernel 3.10.0-693.2.2.el7.x86_64 (x86_64)
Wed Oct  4 13:57:39 UTC 2017
make: Entering directory `/usr/src/kernels/3.10.0-693.2.2.el7.x86_64'
  LD      /var/lib/dkms/wireguard/0.0.20171001/build/built-in.o
  CC [M]  /var/lib/dkms/wireguard/0.0.20171001/build/main.o
In file included from <command-line>:0:0:
/var/lib/dkms/wireguard/0.0.20171001/build/compat/compat.h:428:0: warning: "GENL_UNS_ADMIN_PERM" redefined [enabled by default]
 #define GENL_UNS_ADMIN_PERM GENL_ADMIN_PERM
 ^
In file included from include/linux/genetlink.h:4:0,
                 from include/net/genetlink.h:4,
                 from /var/lib/dkms/wireguard/0.0.20171001/build/compat/compat.h:406,
                 from <command-line>:0:
include/uapi/linux/genetlink.h:24:0: note: this is the location of the previous definition
 #define GENL_UNS_ADMIN_PERM 0x10
 ^
  CC [M]  /var/lib/dkms/wireguard/0.0.20171001/build/noise.o
In file included from <command-line>:0:0:
/var/lib/dkms/wireguard/0.0.20171001/build/compat/compat.h:428:0: warning: "GENL_UNS_ADMIN_PERM" redefined [enabled by default]
 #define GENL_UNS_ADMIN_PERM GENL_ADMIN_PERM
 ^
In file included from include/linux/genetlink.h:4:0,
                 from include/net/genetlink.h:4,
                 from /var/lib/dkms/wireguard/0.0.20171001/build/compat/compat.h:406,
                 from <command-line>:0:
include/uapi/linux/genetlink.h:24:0: note: this is the location of the previous definition
 #define GENL_UNS_ADMIN_PERM 0x10
 ^
  CC [M]  /var/lib/dkms/wireguard/0.0.20171001/build/device.o
In file included from <command-line>:0:0:
/var/lib/dkms/wireguard/0.0.20171001/build/compat/compat.h:428:0: warning: "GENL_UNS_ADMIN_PERM" redefined [enabled by default]
 #define GENL_UNS_ADMIN_PERM GENL_ADMIN_PERM
 ^
In file included from include/linux/genetlink.h:4:0,
                 from include/net/genetlink.h:4,
                 from /var/lib/dkms/wireguard/0.0.20171001/build/compat/compat.h:406,
                 from <command-line>:0:
include/uapi/linux/genetlink.h:24:0: note: this is the location of the previous definition
 #define GENL_UNS_ADMIN_PERM 0x10
 ^
  CC [M]  /var/lib/dkms/wireguard/0.0.20171001/build/peer.o
In file included from <command-line>:0:0:
/var/lib/dkms/wireguard/0.0.20171001/build/compat/compat.h:428:0: warning: "GENL_UNS_ADMIN_PERM" redefined [enabled by default]
 #define GENL_UNS_ADMIN_PERM GENL_ADMIN_PERM
 ^
In file included from include/linux/genetlink.h:4:0,
                 from include/net/genetlink.h:4,
                 from /var/lib/dkms/wireguard/0.0.20171001/build/compat/compat.h:406,
                 from <command-line>:0:
include/uapi/linux/genetlink.h:24:0: note: this is the location of the previous definition
 #define GENL_UNS_ADMIN_PERM 0x10
 ^
  CC [M]  /var/lib/dkms/wireguard/0.0.20171001/build/timers.o
In file included from <command-line>:0:0:
/var/lib/dkms/wireguard/0.0.20171001/build/compat/compat.h:428:0: warning: "GENL_UNS_ADMIN_PERM" redefined [enabled by default]
 #define GENL_UNS_ADMIN_PERM GENL_ADMIN_PERM
 ^
In file included from include/linux/genetlink.h:4:0,
                 from include/net/genetlink.h:4,
                 from /var/lib/dkms/wireguard/0.0.20171001/build/compat/compat.h:406,
                 from <command-line>:0:
include/uapi/linux/genetlink.h:24:0: note: this is the location of the previous definition
 #define GENL_UNS_ADMIN_PERM 0x10
 ^
  CC [M]  /var/lib/dkms/wireguard/0.0.20171001/build/queueing.o
In file included from <command-line>:0:0:
/var/lib/dkms/wireguard/0.0.20171001/build/compat/compat.h:428:0: warning: "GENL_UNS_ADMIN_PERM" redefined [enabled by default]
 #define GENL_UNS_ADMIN_PERM GENL_ADMIN_PERM
 ^
In file included from include/linux/genetlink.h:4:0,
                 from include/net/genetlink.h:4,
                 from /var/lib/dkms/wireguard/0.0.20171001/build/compat/compat.h:406,
                 from <command-line>:0:
include/uapi/linux/genetlink.h:24:0: note: this is the location of the previous definition
 #define GENL_UNS_ADMIN_PERM 0x10
 ^
  CC [M]  /var/lib/dkms/wireguard/0.0.20171001/build/send.o
In file included from <command-line>:0:0:
/var/lib/dkms/wireguard/0.0.20171001/build/compat/compat.h:428:0: warning: "GENL_UNS_ADMIN_PERM" redefined [enabled by default]
 #define GENL_UNS_ADMIN_PERM GENL_ADMIN_PERM
 ^
In file included from include/linux/genetlink.h:4:0,
                 from include/net/genetlink.h:4,
                 from /var/lib/dkms/wireguard/0.0.20171001/build/compat/compat.h:406,
                 from <command-line>:0:
include/uapi/linux/genetlink.h:24:0: note: this is the location of the previous definition
 #define GENL_UNS_ADMIN_PERM 0x10
 ^
  CC [M]  /var/lib/dkms/wireguard/0.0.20171001/build/receive.o
In file included from <command-line>:0:0:
/var/lib/dkms/wireguard/0.0.20171001/build/compat/compat.h:428:0: warning: "GENL_UNS_ADMIN_PERM" redefined [enabled by default]
 #define GENL_UNS_ADMIN_PERM GENL_ADMIN_PERM
 ^
In file included from include/linux/genetlink.h:4:0,
                 from include/net/genetlink.h:4,
                 from /var/lib/dkms/wireguard/0.0.20171001/build/compat/compat.h:406,
                 from <command-line>:0:
include/uapi/linux/genetlink.h:24:0: note: this is the location of the previous definition
 #define GENL_UNS_ADMIN_PERM 0x10
 ^
  CC [M]  /var/lib/dkms/wireguard/0.0.20171001/build/socket.o
In file included from <command-line>:0:0:
/var/lib/dkms/wireguard/0.0.20171001/build/compat/compat.h:428:0: warning: "GENL_UNS_ADMIN_PERM" redefined [enabled by default]
 #define GENL_UNS_ADMIN_PERM GENL_ADMIN_PERM
 ^
In file included from include/linux/genetlink.h:4:0,
                 from include/net/genetlink.h:4,
                 from /var/lib/dkms/wireguard/0.0.20171001/build/compat/compat.h:406,
                 from <command-line>:0:
include/uapi/linux/genetlink.h:24:0: note: this is the location of the previous definition
 #define GENL_UNS_ADMIN_PERM 0x10
 ^
  CC [M]  /var/lib/dkms/wireguard/0.0.20171001/build/hashtables.o
In file included from <command-line>:0:0:
/var/lib/dkms/wireguard/0.0.20171001/build/compat/compat.h:428:0: warning: "GENL_UNS_ADMIN_PERM" redefined [enabled by default]
 #define GENL_UNS_ADMIN_PERM GENL_ADMIN_PERM
 ^
In file included from include/linux/genetlink.h:4:0,
                 from include/net/genetlink.h:4,
                 from /var/lib/dkms/wireguard/0.0.20171001/build/compat/compat.h:406,
                 from <command-line>:0:
include/uapi/linux/genetlink.h:24:0: note: this is the location of the previous definition
 #define GENL_UNS_ADMIN_PERM 0x10
 ^
  CC [M]  /var/lib/dkms/wireguard/0.0.20171001/build/routingtable.o
In file included from <command-line>:0:0:
/var/lib/dkms/wireguard/0.0.20171001/build/compat/compat.h:428:0: warning: "GENL_UNS_ADMIN_PERM" redefined [enabled by default]
 #define GENL_UNS_ADMIN_PERM GENL_ADMIN_PERM
 ^
In file included from include/linux/genetlink.h:4:0,
                 from include/net/genetlink.h:4,
                 from /var/lib/dkms/wireguard/0.0.20171001/build/compat/compat.h:406,
                 from <command-line>:0:
include/uapi/linux/genetlink.h:24:0: note: this is the location of the previous definition
 #define GENL_UNS_ADMIN_PERM 0x10
 ^
  CC [M]  /var/lib/dkms/wireguard/0.0.20171001/build/ratelimiter.o
In file included from <command-line>:0:0:
/var/lib/dkms/wireguard/0.0.20171001/build/compat/compat.h:428:0: warning: "GENL_UNS_ADMIN_PERM" redefined [enabled by default]
 #define GENL_UNS_ADMIN_PERM GENL_ADMIN_PERM
 ^
In file included from include/linux/genetlink.h:4:0,
                 from include/net/genetlink.h:4,
                 from /var/lib/dkms/wireguard/0.0.20171001/build/compat/compat.h:406,
                 from <command-line>:0:
include/uapi/linux/genetlink.h:24:0: note: this is the location of the previous definition
 #define GENL_UNS_ADMIN_PERM 0x10
 ^
  CC [M]  /var/lib/dkms/wireguard/0.0.20171001/build/cookie.o
In file included from <command-line>:0:0:
/var/lib/dkms/wireguard/0.0.20171001/build/compat/compat.h:428:0: warning: "GENL_UNS_ADMIN_PERM" redefined [enabled by default]
 #define GENL_UNS_ADMIN_PERM GENL_ADMIN_PERM
 ^
In file included from include/linux/genetlink.h:4:0,
                 from include/net/genetlink.h:4,
                 from /var/lib/dkms/wireguard/0.0.20171001/build/compat/compat.h:406,
                 from <command-line>:0:
include/uapi/linux/genetlink.h:24:0: note: this is the location of the previous definition
 #define GENL_UNS_ADMIN_PERM 0x10
 ^
  CC [M]  /var/lib/dkms/wireguard/0.0.20171001/build/netlink.o
In file included from <command-line>:0:0:
/var/lib/dkms/wireguard/0.0.20171001/build/compat/compat.h:428:0: warning: "GENL_UNS_ADMIN_PERM" redefined [enabled by default]
 #define GENL_UNS_ADMIN_PERM GENL_ADMIN_PERM
 ^
In file included from include/linux/genetlink.h:4:0,
                 from include/net/genetlink.h:4,
                 from /var/lib/dkms/wireguard/0.0.20171001/build/compat/compat.h:406,
                 from <command-line>:0:
include/uapi/linux/genetlink.h:24:0: note: this is the location of the previous definition
 #define GENL_UNS_ADMIN_PERM 0x10
 ^
/var/lib/dkms/wireguard/0.0.20171001/build/netlink.c: In function ‘netlink_init’:
/var/lib/dkms/wireguard/0.0.20171001/build/netlink.c:488:42: error: macro "genl_register_family_with_ops" passed 3 arguments, but takes just 2
  return genl_register_family(&genl_family);
                                          ^
In file included from <command-line>:0:0:
/var/lib/dkms/wireguard/0.0.20171001/build/compat/compat.h:434:33: error: ‘genl_register_family_with_ops’ undeclared (first use in this function)
 #define genl_register_family(a) genl_register_family_with_ops(a, (struct genl_ops *)genl_ops, ARRAY_SIZE(genl_ops))
                                 ^
/var/lib/dkms/wireguard/0.0.20171001/build/netlink.c:488:9: note: in expansion of macro ‘genl_register_family’
  return genl_register_family(&genl_family);
         ^
/var/lib/dkms/wireguard/0.0.20171001/build/compat/compat.h:434:33: note: each undeclared identifier is reported only once for each function it appears in
 #define genl_register_family(a) genl_register_family_with_ops(a, (struct genl_ops *)genl_ops, ARRAY_SIZE(genl_ops))
                                 ^
/var/lib/dkms/wireguard/0.0.20171001/build/netlink.c:488:9: note: in expansion of macro ‘genl_register_family’
  return genl_register_family(&genl_family);
         ^
/var/lib/dkms/wireguard/0.0.20171001/build/netlink.c:489:1: warning: control reaches end of non-void function [-Wreturn-type]
 }
 ^
make[1]: *** [/var/lib/dkms/wireguard/0.0.20171001/build/netlink.o] Error 1
make: *** [_module_/var/lib/dkms/wireguard/0.0.20171001/build] Error 2
make: Leaving directory `/usr/src/kernels/3.10.0-693.2.2.el7.x86_64'



- A.

[-- Attachment #2: Type: text/html, Size: 17882 bytes --]

^ permalink raw reply	[flat|nested] 5+ messages in thread
* Re: CentOS kernel module build failure
  2017-10-04 14:03 CentOS kernel module build failure Andrey Petrov
@ 2017-10-05  4:37 ` Jason A. Donenfeld
  2017-10-05  8:12   ` Andrey Petrov
  0 siblings, 1 reply; 5+ messages in thread
From: Jason A. Donenfeld @ 2017-10-05  4:37 UTC (permalink / raw)
  To: Andrey Petrov; +Cc: wireguard

Hey Andrey,

Sorry about that. I fixed it yesterday in the master branch. I'll roll
a new snapshot soon.

https://git.zx2c4.com/WireGuard/patch/?id=24e742617e47bcdb65ba4ce37fa56a107d75d0f3

Jason

^ permalink raw reply	[flat|nested] 5+ messages in thread
* Re: CentOS kernel module build failure
  2017-10-05  4:37 ` Jason A. Donenfeld
@ 2017-10-05  8:12   ` Andrey Petrov
  2017-10-05 13:10     ` Jason A. Donenfeld
  0 siblings, 1 reply; 5+ messages in thread
From: Andrey Petrov @ 2017-10-05  8:12 UTC (permalink / raw)
  To: Jason A. Donenfeld; +Cc: wireguard

[-- Attachment #1: Type: text/plain, Size: 3545 bytes --]

Hi Jason,


After applying the patch with 'git apply' I got:

DKMS make.log for wireguard-0.0.20171001 for kernel 3.10.0-693.2.2.el7.x86_64 (x86_64)
Thu Oct  5 08:10:00 UTC 2017
make: Entering directory `/usr/src/kernels/3.10.0-693.2.2.el7.x86_64'
  LD      /var/lib/dkms/wireguard/0.0.20171001/build/built-in.o
  CC [M]  /var/lib/dkms/wireguard/0.0.20171001/build/main.o
  CC [M]  /var/lib/dkms/wireguard/0.0.20171001/build/noise.o
  CC [M]  /var/lib/dkms/wireguard/0.0.20171001/build/device.o
  CC [M]  /var/lib/dkms/wireguard/0.0.20171001/build/peer.o
  CC [M]  /var/lib/dkms/wireguard/0.0.20171001/build/timers.o
  CC [M]  /var/lib/dkms/wireguard/0.0.20171001/build/queueing.o
  CC [M]  /var/lib/dkms/wireguard/0.0.20171001/build/send.o
  CC [M]  /var/lib/dkms/wireguard/0.0.20171001/build/receive.o
  CC [M]  /var/lib/dkms/wireguard/0.0.20171001/build/socket.o
  CC [M]  /var/lib/dkms/wireguard/0.0.20171001/build/hashtables.o
  CC [M]  /var/lib/dkms/wireguard/0.0.20171001/build/routingtable.o
  CC [M]  /var/lib/dkms/wireguard/0.0.20171001/build/ratelimiter.o
  CC [M]  /var/lib/dkms/wireguard/0.0.20171001/build/cookie.o
  CC [M]  /var/lib/dkms/wireguard/0.0.20171001/build/netlink.o
/var/lib/dkms/wireguard/0.0.20171001/build/netlink.c: In function ‘netlink_init’:
/var/lib/dkms/wireguard/0.0.20171001/build/netlink.c:488:42: error: macro "genl_register_family_with_ops" passed 3 arguments, but takes just 2
  return genl_register_family(&genl_family);
                                          ^
In file included from <command-line>:0:0:
/var/lib/dkms/wireguard/0.0.20171001/build/compat/compat.h:437:33: error: ‘genl_register_family_with_ops’ undeclared (first use in this function)
 #define genl_register_family(a) genl_register_family_with_ops(a, (struct genl_ops *)genl_ops, ARRAY_SIZE(genl_ops))
                                 ^
/var/lib/dkms/wireguard/0.0.20171001/build/netlink.c:488:9: note: in expansion of macro ‘genl_register_family’
  return genl_register_family(&genl_family);
         ^
/var/lib/dkms/wireguard/0.0.20171001/build/compat/compat.h:437:33: note: each undeclared identifier is reported only once for each function it appears in
 #define genl_register_family(a) genl_register_family_with_ops(a, (struct genl_ops *)genl_ops, ARRAY_SIZE(genl_ops))
                                 ^
/var/lib/dkms/wireguard/0.0.20171001/build/netlink.c:488:9: note: in expansion of macro ‘genl_register_family’
  return genl_register_family(&genl_family);
         ^
/var/lib/dkms/wireguard/0.0.20171001/build/netlink.c:489:1: warning: control reaches end of non-void function [-Wreturn-type]
 }
 ^
make[1]: *** [/var/lib/dkms/wireguard/0.0.20171001/build/netlink.o] Error 1
make: *** [_module_/var/lib/dkms/wireguard/0.0.20171001/build] Error 2
make: Leaving directory `/usr/src/kernels/3.10.0-693.2.2.el7.x86_64'

- Andrey

________________________________
From: Jason A. Donenfeld <Jason@zx2c4.com>
Sent: Thursday, October 5, 2017 7:37:53 AM
To: Andrey Petrov
Cc: wireguard@lists.zx2c4.com
Subject: Re: CentOS kernel module build failure

Hey Andrey,

Sorry about that. I fixed it yesterday in the master branch. I'll roll
a new snapshot soon.

https://urldefense.proofpoint.com/v2/url?u=https-3A__git.zx2c4.com_WireGuard_patch_-3Fid-3D24e742617e47bcdb65ba4ce37fa56a107d75d0f3&d=DwIBaQ&c=uilaK90D4TOVoH58JNXRgQ&r=lWprCbBPq-RqvY_cTASTIoLEQCXNtlLeW_TMY-DsKcc&m=S_5FETsVfplUfCEryJzb6i4zFDpq7B5RqIFPinAKNms&s=tX5rcecy9pMG6HvpQ9xgyLoXmUOrwKFDUu4_UlY1X0M&e=

Jason

[-- Attachment #2: Type: text/html, Size: 5965 bytes --]

^ permalink raw reply	[flat|nested] 5+ messages in thread
* Re: CentOS kernel module build failure
  2017-10-05  8:12   ` Andrey Petrov
@ 2017-10-05 13:10     ` Jason A. Donenfeld
  2017-10-05 13:22       ` Jason A. Donenfeld
  0 siblings, 1 reply; 5+ messages in thread
From: Jason A. Donenfeld @ 2017-10-05 13:10 UTC (permalink / raw)
  To: Andrey Petrov; +Cc: wireguard

Hey Andrey,

Arg that's annoying. There are still evidently changes in recent
CentOS kernels. I'll spin up a VM now to try this all out and will
send you an updated patch shortly.

Jason

^ permalink raw reply	[flat|nested] 5+ messages in thread
* Re: CentOS kernel module build failure
  2017-10-05 13:10     ` Jason A. Donenfeld
@ 2017-10-05 13:22       ` Jason A. Donenfeld
  0 siblings, 0 replies; 5+ messages in thread
From: Jason A. Donenfeld @ 2017-10-05 13:22 UTC (permalink / raw)
  To: Andrey Petrov; +Cc: wireguard

Looks like you'll also need:
https://git.zx2c4.com/WireGuard/patch/?id=e3b70f72236c26cdda6f7538d7a5854c1d0d43f3

^ permalink raw reply	[flat|nested] 5+ messages in thread
end of thread, other threads:[~2017-10-05 12:53 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-10-04 14:03 CentOS kernel module build failure Andrey Petrov
2017-10-05  4:37 ` Jason A. Donenfeld
2017-10-05  8:12   ` Andrey Petrov
2017-10-05 13:10     ` Jason A. Donenfeld
2017-10-05 13:22       ` Jason A. Donenfeld

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.