All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Jason A. Donenfeld" <Jason@zx2c4.com>
To: Hannes Frederic Sowa <hannes@stressinduktion.org>
Cc: David Ahern <dsa@cumulusnetworks.com>,
	Netdev <netdev@vger.kernel.org>,
	WireGuard mailing list <wireguard@lists.zx2c4.com>,
	LKML <linux-kernel@vger.kernel.org>,
	YOSHIFUJI Hideaki <hideaki.yoshifuji@miraclelinux.com>
Subject: Re: Source address fib invalidation on IPv6
Date: Sun, 13 Nov 2016 02:00:38 +0100	[thread overview]
Message-ID: <CAHmME9qYYU-p5BhR0ReNSB+__wysuDK+eEk1SisCoyf4=2woxg@mail.gmail.com> (raw)
In-Reply-To: <1478998272.2299343.785875225.19237693@webmail.messagingengine.com>

Hi Hannes,

On Sun, Nov 13, 2016 at 1:51 AM, Hannes Frederic Sowa
<hannes@stressinduktion.org> wrote:
> You probably need some combination of ipv6_chk_addr and/or
> ipv6_check_addr_and_flags (where dev can also be NULL). Be careful if a
> IFA_HOST or IFA_LINK address switches from one interface to another.

I can confirm this trick works beautifully:
https://git.zx2c4.com/WireGuard/commit/?id=eb65810fc6350c50b42abedd1291b12337d3dc3d

I'll see if I can fold this into the routing function so that it
behaves the same as v4, unless David gets there first.

Regards,
Jason

WARNING: multiple messages have this Message-ID (diff)
From: "Jason A. Donenfeld" <Jason@zx2c4.com>
To: Hannes Frederic Sowa <hannes@stressinduktion.org>
Cc: David Ahern <dsa@cumulusnetworks.com>,
	YOSHIFUJI Hideaki <hideaki.yoshifuji@miraclelinux.com>,
	LKML <linux-kernel@vger.kernel.org>,
	WireGuard mailing list <wireguard@lists.zx2c4.com>,
	Netdev <netdev@vger.kernel.org>
Subject: Re: Source address fib invalidation on IPv6
Date: Sun, 13 Nov 2016 02:00:38 +0100	[thread overview]
Message-ID: <CAHmME9qYYU-p5BhR0ReNSB+__wysuDK+eEk1SisCoyf4=2woxg@mail.gmail.com> (raw)
In-Reply-To: <1478998272.2299343.785875225.19237693@webmail.messagingengine.com>

Hi Hannes,

On Sun, Nov 13, 2016 at 1:51 AM, Hannes Frederic Sowa
<hannes@stressinduktion.org> wrote:
> You probably need some combination of ipv6_chk_addr and/or
> ipv6_check_addr_and_flags (where dev can also be NULL). Be careful if a
> IFA_HOST or IFA_LINK address switches from one interface to another.

I can confirm this trick works beautifully:
https://git.zx2c4.com/WireGuard/commit/?id=eb65810fc6350c50b42abedd1291b12337d3dc3d

I'll see if I can fold this into the routing function so that it
behaves the same as v4, unless David gets there first.

Regards,
Jason

WARNING: multiple messages have this Message-ID (diff)
From: "Jason A. Donenfeld" <Jason@zx2c4.com>
To: Hannes Frederic Sowa <hannes@stressinduktion.org>
Cc: David Ahern <dsa@cumulusnetworks.com>,
	YOSHIFUJI Hideaki <hideaki.yoshifuji@miraclelinux.com>,
	LKML <linux-kernel@vger.kernel.org>,
	WireGuard mailing list <wireguard@lists.zx2c4.com>,
	Netdev <netdev@vger.kernel.org>
Subject: Re: [WireGuard] Source address fib invalidation on IPv6
Date: Sun, 13 Nov 2016 02:00:38 +0100	[thread overview]
Message-ID: <CAHmME9qYYU-p5BhR0ReNSB+__wysuDK+eEk1SisCoyf4=2woxg@mail.gmail.com> (raw)
In-Reply-To: <1478998272.2299343.785875225.19237693@webmail.messagingengine.com>

Hi Hannes,

On Sun, Nov 13, 2016 at 1:51 AM, Hannes Frederic Sowa
<hannes@stressinduktion.org> wrote:
> You probably need some combination of ipv6_chk_addr and/or
> ipv6_check_addr_and_flags (where dev can also be NULL). Be careful if a
> IFA_HOST or IFA_LINK address switches from one interface to another.

I can confirm this trick works beautifully:
https://git.zx2c4.com/WireGuard/commit/?id=eb65810fc6350c50b42abedd1291b12337d3dc3d

I'll see if I can fold this into the routing function so that it
behaves the same as v4, unless David gets there first.

Regards,
Jason

  reply	other threads:[~2016-11-13  1:00 UTC|newest]

Thread overview: 78+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-11-11 19:29 Source address fib invalidation on IPv6 Jason A. Donenfeld
2016-11-11 19:29 ` [WireGuard] " Jason A. Donenfeld
2016-11-11 19:29 ` Jason A. Donenfeld
2016-11-11 22:14 ` David Ahern
2016-11-11 22:14   ` [WireGuard] " David Ahern
2016-11-11 22:14   ` David Ahern
2016-11-12  2:18   ` Jason A. Donenfeld
2016-11-12  2:18     ` [WireGuard] " Jason A. Donenfeld
2016-11-12  2:18     ` Jason A. Donenfeld
2016-11-12 15:40     ` Jason A. Donenfeld
2016-11-12 15:40       ` [WireGuard] " Jason A. Donenfeld
2016-11-12 15:40       ` Jason A. Donenfeld
2016-11-12 18:14       ` David Ahern
2016-11-12 18:14         ` [WireGuard] " David Ahern
2016-11-12 18:14         ` David Ahern
2016-11-12 19:08         ` Jason A. Donenfeld
2016-11-12 19:08           ` [WireGuard] " Jason A. Donenfeld
2016-11-12 19:08           ` Jason A. Donenfeld
2016-11-13  0:43           ` Jason A. Donenfeld
2016-11-13  0:43             ` [WireGuard] " Jason A. Donenfeld
2016-11-13  0:51             ` Hannes Frederic Sowa
2016-11-13  0:51               ` [WireGuard] " Hannes Frederic Sowa
2016-11-13  0:51               ` Hannes Frederic Sowa
2016-11-13  1:00               ` Jason A. Donenfeld [this message]
2016-11-13  1:00                 ` [WireGuard] " Jason A. Donenfeld
2016-11-13  1:00                 ` Jason A. Donenfeld
2016-11-13 13:23                 ` [PATCH] ip6_output: ensure flow saddr actually belongs to device Jason A. Donenfeld
2016-11-13 13:23                   ` [WireGuard] " Jason A. Donenfeld
2016-11-13 13:23                   ` Jason A. Donenfeld
2016-11-13 16:30                   ` David Ahern
2016-11-13 16:30                     ` [WireGuard] " David Ahern
2016-11-13 19:02                     ` [PATCH v2] " Jason A. Donenfeld
2016-11-13 19:02                       ` [WireGuard] " Jason A. Donenfeld
2016-11-13 19:02                       ` Jason A. Donenfeld
2016-11-13 20:45                       ` David Ahern
2016-11-13 20:45                         ` [WireGuard] " David Ahern
2016-11-13 23:28                         ` [PATCH v3] " Jason A. Donenfeld
2016-11-13 23:28                           ` [WireGuard] " Jason A. Donenfeld
2016-11-13 23:28                           ` Jason A. Donenfeld
2016-11-14  1:36                           ` [WireGuard] Debugging AllowedIps John Huttley
2016-11-14  1:39                             ` Jason A. Donenfeld
2016-11-14  2:28                               ` John Huttley
2016-11-14  2:59                                 ` Jason A. Donenfeld
2016-11-14  3:10                                   ` John Huttley
2016-11-14 16:19                           ` [PATCH v3] ip6_output: ensure flow saddr actually belongs to device David Ahern
2016-11-14 16:19                             ` [WireGuard] " David Ahern
     [not found]                             ` <CAHmME9p6-mLSs84AwwfRXe8U3Z2sy6Dp9W9H0gKh0rcZuQAfZA@mail.gmail.com>
     [not found]                               ` <CAHmME9qC4xqGOwJnauXrJBDkAtmmuJ+kJKL6ufuU9_XWKNFdSA@mail.gmail.com>
2016-11-14 16:54                                 ` Jason A. Donenfeld
2016-11-14 16:54                                   ` [WireGuard] " Jason A. Donenfeld
2016-11-14 16:44                           ` Hannes Frederic Sowa
2016-11-14 16:44                             ` [WireGuard] " Hannes Frederic Sowa
2016-11-14 16:55                             ` David Ahern
2016-11-14 16:55                               ` [WireGuard] " David Ahern
2016-11-14 17:04                               ` Hannes Frederic Sowa
2016-11-14 17:04                                 ` [WireGuard] " Hannes Frederic Sowa
2016-11-14 17:17                                 ` David Ahern
2016-11-14 17:17                                   ` [WireGuard] " David Ahern
2016-11-14 17:33                                   ` Hannes Frederic Sowa
2016-11-14 17:33                                     ` [WireGuard] " Hannes Frederic Sowa
2016-11-14 17:48                                     ` David Ahern
2016-11-14 17:48                                       ` [WireGuard] " David Ahern
2016-11-14 18:33                                       ` Hannes Frederic Sowa
2016-11-14 18:33                                         ` [WireGuard] " Hannes Frederic Sowa
2016-11-15  0:45                                         ` Jason A. Donenfeld
2016-11-15  0:45                                           ` [WireGuard] " Jason A. Donenfeld
2016-11-15  0:45                                           ` Jason A. Donenfeld
2016-11-15 14:45                                           ` Hannes Frederic Sowa
2016-11-15 14:45                                             ` [WireGuard] " Hannes Frederic Sowa
2016-11-15 15:26                                             ` David Ahern
2016-11-15 15:26                                               ` [WireGuard] " David Ahern
2016-11-15 15:26                                               ` David Ahern
2016-11-13 20:19                     ` [PATCH] " Jason A. Donenfeld
2016-11-13 20:19                       ` [WireGuard] " Jason A. Donenfeld
2016-11-13 20:39                       ` David Ahern
2016-11-13 20:39                         ` [WireGuard] " David Ahern
2016-11-13 20:39                         ` David Ahern
2016-11-13  0:51             ` Source address fib invalidation on IPv6 Jason A. Donenfeld
2016-11-13  0:51               ` [WireGuard] " Jason A. Donenfeld
2016-11-13  0:51               ` Jason A. Donenfeld

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAHmME9qYYU-p5BhR0ReNSB+__wysuDK+eEk1SisCoyf4=2woxg@mail.gmail.com' \
    --to=jason@zx2c4.com \
    --cc=dsa@cumulusnetworks.com \
    --cc=hannes@stressinduktion.org \
    --cc=hideaki.yoshifuji@miraclelinux.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=wireguard@lists.zx2c4.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.