Build failure on NetBSD since "fio: Generalize zonemode=zbd"

Build failure on NetBSD since "fio: Generalize zonemode=zbd"

[Tomohiro Kusumi]

b76949618d557bd63181245aa522ead9b92d274b ("fio: Generalize zonemode=zbd")
which got rid of CONFIG_HAS_BLKZONED flag broke compilation on NetBSD,
as pthread in NetBSD doesn't have pthread_mutexattr_setpshared(3).
Looks like OpenBSD doesn't have it either.

--
ld: zbd.o: in function `parse_zone_info':
fio/zbd.c:422: undefined reference to `pthread_mutexattr_setpshared'
ld: zbd.o: in function `init_zone_info':
fio/zbd.c:378: undefined reference to `pthread_mutexattr_setpshared'
gmake: *** [Makefile:483: fio] Error 1

Re: Build failure on NetBSD since "fio: Generalize zonemode=zbd"

[Shinichiro Kawasaki]

On May 27, 2020 / 01:08, Tomohiro Kusumi wrote:
> b76949618d557bd63181245aa522ead9b92d274b ("fio: Generalize zonemode=zbd")
> which got rid of CONFIG_HAS_BLKZONED flag broke compilation on NetBSD,
> as pthread in NetBSD doesn't have pthread_mutexattr_setpshared(3).
> Looks like OpenBSD doesn't have it either.
> 
> --
> ld: zbd.o: in function `parse_zone_info':
> fio/zbd.c:422: undefined reference to `pthread_mutexattr_setpshared'
> ld: zbd.o: in function `init_zone_info':
> fio/zbd.c:378: undefined reference to `pthread_mutexattr_setpshared'
> gmake: *** [Makefile:483: fio] Error 1

Hello Tomohiro,

I have sent out a patch series with subject "Fix compilation error on BSD"
which tries to address the issue. I do not have BSD systems and can not confirm
the series fixes the issue. Could you help to check the fix with your system?

-- 
Best Regards,
Shin'ichiro Kawasaki

Re: Build failure on NetBSD since "fio: Generalize zonemode=zbd"

[Tomohiro Kusumi]

2020年5月28日(木) 22:02 Shinichiro Kawasaki <shinichiro.kawasaki@wdc.com>:
>
> On May 27, 2020 / 01:08, Tomohiro Kusumi wrote:
> > b76949618d557bd63181245aa522ead9b92d274b ("fio: Generalize zonemode=zbd")
> > which got rid of CONFIG_HAS_BLKZONED flag broke compilation on NetBSD,
> > as pthread in NetBSD doesn't have pthread_mutexattr_setpshared(3).
> > Looks like OpenBSD doesn't have it either.
> >
> > --
> > ld: zbd.o: in function `parse_zone_info':
> > fio/zbd.c:422: undefined reference to `pthread_mutexattr_setpshared'
> > ld: zbd.o: in function `init_zone_info':
> > fio/zbd.c:378: undefined reference to `pthread_mutexattr_setpshared'
> > gmake: *** [Makefile:483: fio] Error 1
>
> Hello Tomohiro,
>
> I have sent out a patch series with subject "Fix compilation error on BSD"
> which tries to address the issue. I do not have BSD systems and can not confirm
> the series fixes the issue. Could you help to check the fix with your system?

Hi

Thank you for taking a look at it.
The build failure on NetBSD and OpenBSD are both fixed now.

(I've also compiled it on FreeBSD and DragonFlyBSD which seem to support
pthread_mutexattr_setpshared(3) (at least compile), and they didn't have build
issue with your patch series as well.)

>
> --
> Best Regards,
> Shin'ichiro Kawasaki

Re: Build failure on NetBSD since "fio: Generalize zonemode=zbd"

[Shinichiro Kawasaki]

On May 29, 2020 / 01:46, Tomohiro Kusumi wrote:
> 2020年5月28日(木) 22:02 Shinichiro Kawasaki <shinichiro.kawasaki@wdc.com>:
> >
> > On May 27, 2020 / 01:08, Tomohiro Kusumi wrote:
> > > b76949618d557bd63181245aa522ead9b92d274b ("fio: Generalize zonemode=zbd")
> > > which got rid of CONFIG_HAS_BLKZONED flag broke compilation on NetBSD,
> > > as pthread in NetBSD doesn't have pthread_mutexattr_setpshared(3).
> > > Looks like OpenBSD doesn't have it either.
> > >
> > > --
> > > ld: zbd.o: in function `parse_zone_info':
> > > fio/zbd.c:422: undefined reference to `pthread_mutexattr_setpshared'
> > > ld: zbd.o: in function `init_zone_info':
> > > fio/zbd.c:378: undefined reference to `pthread_mutexattr_setpshared'
> > > gmake: *** [Makefile:483: fio] Error 1
> >
> > Hello Tomohiro,
> >
> > I have sent out a patch series with subject "Fix compilation error on BSD"
> > which tries to address the issue. I do not have BSD systems and can not confirm
> > the series fixes the issue. Could you help to check the fix with your system?
> 
> Hi
> 
> Thank you for taking a look at it.
> The build failure on NetBSD and OpenBSD are both fixed now.
> 
> (I've also compiled it on FreeBSD and DragonFlyBSD which seem to support
> pthread_mutexattr_setpshared(3) (at least compile), and they didn't have build
> issue with your patch series as well.)

Tomohiro, thanks for the confirmation. Sounds good.

Jens, thank you for the quick pick up.

-- 
Best Regards,
Shin'ichiro Kawasaki