All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH net] bnx2x: fix vector traveling while looking for an empty entry
@ 2012-03-27  7:08 Dmitry Kravkov
  2012-03-27 18:06 ` Maciej Żenczykowski
  2012-03-28  2:41 ` David Miller
  0 siblings, 2 replies; 3+ messages in thread
From: Dmitry Kravkov @ 2012-03-27  7:08 UTC (permalink / raw)
  To: davem, netdev, eilong, zenczykowski; +Cc: Dmitry Kravkov

Fixes the bug that may prevent from mac to be configured,
while there is an empty slot for it.

Reported-by: Maciej Żenczykowski <zenczykowski@gmail.com>
Signed-off-by: Dmitry Kravkov <dmitry@broadcom.com>
---
 drivers/net/ethernet/broadcom/bnx2x/bnx2x_sp.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/net/ethernet/broadcom/bnx2x/bnx2x_sp.c b/drivers/net/ethernet/broadcom/bnx2x/bnx2x_sp.c
index 3f52fad..5135733 100644
--- a/drivers/net/ethernet/broadcom/bnx2x/bnx2x_sp.c
+++ b/drivers/net/ethernet/broadcom/bnx2x/bnx2x_sp.c
@@ -3847,7 +3847,7 @@ static bool bnx2x_credit_pool_get_entry(
 			continue;
 
 		/* If we've got here we are going to find a free entry */
-		for (idx = vec * BNX2X_POOL_VEC_SIZE, i = 0;
+		for (idx = vec * BIT_VEC64_ELEM_SZ, i = 0;
 		      i < BIT_VEC64_ELEM_SZ; idx++, i++)
 
 			if (BIT_VEC64_TEST_BIT(o->pool_mirror, idx)) {
-- 
1.7.7.2

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH net] bnx2x: fix vector traveling while looking for an empty entry
  2012-03-27  7:08 [PATCH net] bnx2x: fix vector traveling while looking for an empty entry Dmitry Kravkov
@ 2012-03-27 18:06 ` Maciej Żenczykowski
  2012-03-28  2:41 ` David Miller
  1 sibling, 0 replies; 3+ messages in thread
From: Maciej Żenczykowski @ 2012-03-27 18:06 UTC (permalink / raw)
  To: Dmitry Kravkov; +Cc: davem, netdev, eilong

Ack.

On Tue, Mar 27, 2012 at 00:08, Dmitry Kravkov <dmitry@broadcom.com> wrote:
> Fixes the bug that may prevent from mac to be configured,
> while there is an empty slot for it.
>
> Reported-by: Maciej Żenczykowski <zenczykowski@gmail.com>
> Signed-off-by: Dmitry Kravkov <dmitry@broadcom.com>
> ---
>  drivers/net/ethernet/broadcom/bnx2x/bnx2x_sp.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/net/ethernet/broadcom/bnx2x/bnx2x_sp.c b/drivers/net/ethernet/broadcom/bnx2x/bnx2x_sp.c
> index 3f52fad..5135733 100644
> --- a/drivers/net/ethernet/broadcom/bnx2x/bnx2x_sp.c
> +++ b/drivers/net/ethernet/broadcom/bnx2x/bnx2x_sp.c
> @@ -3847,7 +3847,7 @@ static bool bnx2x_credit_pool_get_entry(
>                        continue;
>
>                /* If we've got here we are going to find a free entry */
> -               for (idx = vec * BNX2X_POOL_VEC_SIZE, i = 0;
> +               for (idx = vec * BIT_VEC64_ELEM_SZ, i = 0;
>                      i < BIT_VEC64_ELEM_SZ; idx++, i++)
>
>                        if (BIT_VEC64_TEST_BIT(o->pool_mirror, idx)) {
> --
> 1.7.7.2
>
>

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH net] bnx2x: fix vector traveling while looking for an empty entry
  2012-03-27  7:08 [PATCH net] bnx2x: fix vector traveling while looking for an empty entry Dmitry Kravkov
  2012-03-27 18:06 ` Maciej Żenczykowski
@ 2012-03-28  2:41 ` David Miller
  1 sibling, 0 replies; 3+ messages in thread
From: David Miller @ 2012-03-28  2:41 UTC (permalink / raw)
  To: dmitry; +Cc: netdev, eilong, zenczykowski

From: "Dmitry Kravkov" <dmitry@broadcom.com>
Date: Tue, 27 Mar 2012 09:08:55 +0200

> Fixes the bug that may prevent from mac to be configured,
> while there is an empty slot for it.
> 
> Reported-by: Maciej Żenczykowski <zenczykowski@gmail.com>
> Signed-off-by: Dmitry Kravkov <dmitry@broadcom.com>

Applied.

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2012-03-28  2:41 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-03-27  7:08 [PATCH net] bnx2x: fix vector traveling while looking for an empty entry Dmitry Kravkov
2012-03-27 18:06 ` Maciej Żenczykowski
2012-03-28  2:41 ` David Miller

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.