From: Andy Shevchenko <andy.shevchenko@gmail.com>
To: Bjorn Helgaas <helgaas@kernel.org>
Cc: linux-pci <linux-pci@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Mick Lorain <micklorain@protonmail.com>,
Alex Williamson <alex.williamson@redhat.com>,
Thomas Gleixner <tglx@linutronix.de>,
Bjorn Helgaas <bhelgaas@google.com>
Subject: Re: [PATCH] PCI: Avoid broken MSI on SB600 USB devices
Date: Wed, 23 Mar 2022 14:23:25 +0200 [thread overview]
Message-ID: <CAHp75VcQV8dCxhtsRRiy-UYcVDjzn3mPe3Hx-f7JS8CTxrQKqw@mail.gmail.com> (raw)
In-Reply-To: <20220323111131.GA1272756@bhelgaas>
On Wed, Mar 23, 2022 at 1:11 PM Bjorn Helgaas <helgaas@kernel.org> wrote:
> On Wed, Mar 23, 2022 at 10:03:38AM +0200, Andy Shevchenko wrote:
> > On Wed, Mar 23, 2022 at 4:26 AM Bjorn Helgaas <helgaas@kernel.org> wrote:
> > > On Mon, Mar 21, 2022 at 01:34:46PM -0500, Bjorn Helgaas wrote:
> > > > From: Bjorn Helgaas <bhelgaas@google.com>
> > > >
> > > > Some ATI SB600 USB adapters advertise MSI, but if INTx is disabled by
> > > > setting PCI_COMMAND_INTX_DISABLE,
> >
> > > > MSI doesn't work either.
> >
> > I think this is not correct.
>
> I'd like to make it correct. What would make this better?
MSI with the quirk (not in this patch) is working and has been tested.
That said, the part that I commented on is confusing and states the
opposite. I would change the patch if you ask me how to improve it,
> I was
> trying to say the same as your original commit log:
>
> ATI PCIe-USB adapter advertises MSI, but it doesn't work if INTx is
> disabled.
I'm not a native speaker, maybe I was wrong in formulating that MSI
enabling needs a quirk.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2022-03-23 12:24 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-21 18:34 [PATCH] PCI: Avoid broken MSI on SB600 USB devices Bjorn Helgaas
2022-03-23 2:26 ` Bjorn Helgaas
2022-03-23 8:03 ` Andy Shevchenko
2022-03-23 11:11 ` Bjorn Helgaas
2022-03-23 12:23 ` Andy Shevchenko [this message]
2022-03-23 12:43 ` David Woodhouse
2022-03-23 13:23 ` Bjorn Helgaas
2022-03-23 13:43 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAHp75VcQV8dCxhtsRRiy-UYcVDjzn3mPe3Hx-f7JS8CTxrQKqw@mail.gmail.com \
--to=andy.shevchenko@gmail.com \
--cc=alex.williamson@redhat.com \
--cc=bhelgaas@google.com \
--cc=helgaas@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=micklorain@protonmail.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.