From: Andy Shevchenko <andy.shevchenko@gmail.com>
To: David Woodhouse <dwmw2@infradead.org>
Cc: Bjorn Helgaas <helgaas@kernel.org>,
linux-pci <linux-pci@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Mick Lorain <micklorain@protonmail.com>,
Alex Williamson <alex.williamson@redhat.com>,
Thomas Gleixner <tglx@linutronix.de>,
Bjorn Helgaas <bhelgaas@google.com>
Subject: Re: [PATCH] PCI: Avoid broken MSI on SB600 USB devices
Date: Wed, 23 Mar 2022 15:43:29 +0200 [thread overview]
Message-ID: <CAHp75VdKOzgWgsTh-8sAEEey8iOLUUgnw=M-OeX+Dzhu2tnH1g@mail.gmail.com> (raw)
In-Reply-To: <a1bf31d6a8957b837b999c02875456b805efdff1.camel@infradead.org>
On Wed, Mar 23, 2022 at 2:43 PM David Woodhouse <dwmw2@infradead.org> wrote:
> On Wed, 2022-03-23 at 10:03 +0200, Andy Shevchenko wrote:
> > On Wed, Mar 23, 2022 at 4:26 AM Bjorn Helgaas <helgaas@kernel.org> wrote:
> > > On Mon, Mar 21, 2022 at 01:34:46PM -0500, Bjorn Helgaas wrote:
> > > > From: Bjorn Helgaas <bhelgaas@google.com>
> > > > Some ATI SB600 USB adapters advertise MSI, but if INTx is disabled by
> > > > setting PCI_COMMAND_INTX_DISABLE,
> >
> > > > MSI doesn't work either.
> >
> > I think this is not correct.
>
> I think it was perfectly correct until you added a couple of newlines
> in the middle of the sentence, then took it out of context. :)
>
> "If INTX is disabled, MSI doesn't work either".
Ah, I stand corrected. Thanks for the English lesson!
> But really, in that case surely the solution is *not* to disable INTX
> for this device. Then MSI will work, right?
That was my intention, but Bjorn has concerns.
--
With Best Regards,
Andy Shevchenko
prev parent reply other threads:[~2022-03-23 13:44 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-21 18:34 [PATCH] PCI: Avoid broken MSI on SB600 USB devices Bjorn Helgaas
2022-03-23 2:26 ` Bjorn Helgaas
2022-03-23 8:03 ` Andy Shevchenko
2022-03-23 11:11 ` Bjorn Helgaas
2022-03-23 12:23 ` Andy Shevchenko
2022-03-23 12:43 ` David Woodhouse
2022-03-23 13:23 ` Bjorn Helgaas
2022-03-23 13:43 ` Andy Shevchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAHp75VdKOzgWgsTh-8sAEEey8iOLUUgnw=M-OeX+Dzhu2tnH1g@mail.gmail.com' \
--to=andy.shevchenko@gmail.com \
--cc=alex.williamson@redhat.com \
--cc=bhelgaas@google.com \
--cc=dwmw2@infradead.org \
--cc=helgaas@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=micklorain@protonmail.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.