From: Andy Shevchenko <andy.shevchenko@gmail.com>
To: Gene Chen <gene.chen.richtek@gmail.com>
Cc: Jonathan Cameron <jic23@kernel.org>,
Matthias Brugger <matthias.bgg@gmail.com>,
Hartmut Knaack <knaack.h@gmx.de>,
Lars-Peter Clausen <lars@metafoo.de>,
Peter Meerwald <pmeerw@pmeerw.net>,
linux-iio <linux-iio@vger.kernel.org>,
linux-arm Mailing List <linux-arm-kernel@lists.infradead.org>,
"moderated list:ARM/Mediatek SoC support"
<linux-mediatek@lists.infradead.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Gene Chen <gene_chen@richtek.com>,
Wilma.Wu@mediatek.com, shufan_lee@richtek.com,
cy_huang@richtek.com, benjamin.chao@mediatek.com
Subject: Re: [PATCH v3 1/2] iio: adc: mt6360: Add ADC driver for MT6360
Date: Tue, 8 Sep 2020 10:43:47 +0300 [thread overview]
Message-ID: <CAHp75VcX6P9LOw=1=UgX4tWaxa2_PYPvanpDLG0TE2XzPBatAg@mail.gmail.com> (raw)
In-Reply-To: <CAE+NS36j4a6k-JSUbjxzpfbqtE-xMW7qxUUhHPAnc_9V-Lv7LQ@mail.gmail.com>
On Tue, Sep 8, 2020 at 9:19 AM Gene Chen <gene.chen.richtek@gmail.com> wrote:
> Jonathan Cameron <jic23@kernel.org> 於 2020年8月30日 週日 上午1:12寫道：
> > On Mon, 24 Aug 2020 17:06:24 +0800
> > Gene Chen <gene.chen.richtek@gmail.com> wrote:
> > A few comments inline. The big one centres on why we can't
> > expose the channels as _raw, _offset and _scale?
> >
>
> I think i have 3 reason for use real value,
> ADC is used to get real value rather than raw data which is not meaningful.
> And I can decide which formula needs apply according to different condition.
> Also the junction temperature channel _scale is floating point 1.05
> which is not easy to express.
It's easy to express. Like other values in IIO subsystem which are float.
--
With Best Regards,
Andy Shevchenko
WARNING: multiple messages have this Message-ID (diff)
From: Andy Shevchenko <andy.shevchenko@gmail.com>
To: Gene Chen <gene.chen.richtek@gmail.com>
Cc: Gene Chen <gene_chen@richtek.com>,
Lars-Peter Clausen <lars@metafoo.de>,
linux-iio <linux-iio@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
cy_huang@richtek.com, benjamin.chao@mediatek.com,
"moderated list:ARM/Mediatek SoC support"
<linux-mediatek@lists.infradead.org>,
linux-arm Mailing List <linux-arm-kernel@lists.infradead.org>,
Peter Meerwald <pmeerw@pmeerw.net>,
Hartmut Knaack <knaack.h@gmx.de>,
Matthias Brugger <matthias.bgg@gmail.com>,
Wilma.Wu@mediatek.com, Jonathan Cameron <jic23@kernel.org>,
shufan_lee@richtek.com
Subject: Re: [PATCH v3 1/2] iio: adc: mt6360: Add ADC driver for MT6360
Date: Tue, 8 Sep 2020 10:43:47 +0300 [thread overview]
Message-ID: <CAHp75VcX6P9LOw=1=UgX4tWaxa2_PYPvanpDLG0TE2XzPBatAg@mail.gmail.com> (raw)
In-Reply-To: <CAE+NS36j4a6k-JSUbjxzpfbqtE-xMW7qxUUhHPAnc_9V-Lv7LQ@mail.gmail.com>
On Tue, Sep 8, 2020 at 9:19 AM Gene Chen <gene.chen.richtek@gmail.com> wrote:
> Jonathan Cameron <jic23@kernel.org> 於 2020年8月30日 週日 上午1:12寫道：
> > On Mon, 24 Aug 2020 17:06:24 +0800
> > Gene Chen <gene.chen.richtek@gmail.com> wrote:
> > A few comments inline. The big one centres on why we can't
> > expose the channels as _raw, _offset and _scale?
> >
>
> I think i have 3 reason for use real value,
> ADC is used to get real value rather than raw data which is not meaningful.
> And I can decide which formula needs apply according to different condition.
> Also the junction temperature channel _scale is floating point 1.05
> which is not easy to express.
It's easy to express. Like other values in IIO subsystem which are float.
--
With Best Regards,
Andy Shevchenko
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
WARNING: multiple messages have this Message-ID (diff)
From: Andy Shevchenko <andy.shevchenko@gmail.com>
To: Gene Chen <gene.chen.richtek@gmail.com>
Cc: Gene Chen <gene_chen@richtek.com>,
Lars-Peter Clausen <lars@metafoo.de>,
linux-iio <linux-iio@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
cy_huang@richtek.com, benjamin.chao@mediatek.com,
"moderated list:ARM/Mediatek SoC support"
<linux-mediatek@lists.infradead.org>,
linux-arm Mailing List <linux-arm-kernel@lists.infradead.org>,
Peter Meerwald <pmeerw@pmeerw.net>,
Hartmut Knaack <knaack.h@gmx.de>,
Matthias Brugger <matthias.bgg@gmail.com>,
Wilma.Wu@mediatek.com, Jonathan Cameron <jic23@kernel.org>,
shufan_lee@richtek.com
Subject: Re: [PATCH v3 1/2] iio: adc: mt6360: Add ADC driver for MT6360
Date: Tue, 8 Sep 2020 10:43:47 +0300 [thread overview]
Message-ID: <CAHp75VcX6P9LOw=1=UgX4tWaxa2_PYPvanpDLG0TE2XzPBatAg@mail.gmail.com> (raw)
In-Reply-To: <CAE+NS36j4a6k-JSUbjxzpfbqtE-xMW7qxUUhHPAnc_9V-Lv7LQ@mail.gmail.com>
On Tue, Sep 8, 2020 at 9:19 AM Gene Chen <gene.chen.richtek@gmail.com> wrote:
> Jonathan Cameron <jic23@kernel.org> 於 2020年8月30日 週日 上午1:12寫道：
> > On Mon, 24 Aug 2020 17:06:24 +0800
> > Gene Chen <gene.chen.richtek@gmail.com> wrote:
> > A few comments inline. The big one centres on why we can't
> > expose the channels as _raw, _offset and _scale?
> >
>
> I think i have 3 reason for use real value,
> ADC is used to get real value rather than raw data which is not meaningful.
> And I can decide which formula needs apply according to different condition.
> Also the junction temperature channel _scale is floating point 1.05
> which is not easy to express.
It's easy to express. Like other values in IIO subsystem which are float.
--
With Best Regards,
Andy Shevchenko
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-09-08 7:44 UTC|newest]
Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-24 9:06 [PATCH v3 0/2] iio: adc: mt6360: Add ADC driver for MT6360 Gene Chen
2020-08-24 9:06 ` Gene Chen
2020-08-24 9:06 ` Gene Chen
2020-08-24 9:06 ` [PATCH v3 1/2] " Gene Chen
2020-08-24 9:06 ` Gene Chen
2020-08-24 9:06 ` Gene Chen
2020-08-27 12:16 ` kernel test robot
2020-08-27 12:16 ` kernel test robot
2020-08-27 12:16 ` kernel test robot
2020-08-27 12:16 ` kernel test robot
2020-08-29 17:11 ` Jonathan Cameron
2020-08-29 17:11 ` Jonathan Cameron
2020-08-29 17:11 ` Jonathan Cameron
2020-09-08 6:17 ` Gene Chen
2020-09-08 6:17 ` Gene Chen
2020-09-08 6:17 ` Gene Chen
2020-09-08 7:43 ` Andy Shevchenko [this message]
2020-09-08 7:43 ` Andy Shevchenko
2020-09-08 7:43 ` Andy Shevchenko
2020-09-08 9:07 ` Jonathan Cameron
2020-09-08 9:07 ` Jonathan Cameron
2020-09-08 9:07 ` Jonathan Cameron
2020-09-08 11:08 ` Gene Chen
2020-09-08 11:08 ` Gene Chen
2020-09-08 11:08 ` Gene Chen
2020-09-08 12:58 ` Jonathan Cameron
2020-09-08 12:58 ` Jonathan Cameron
2020-09-08 12:58 ` Jonathan Cameron
2020-09-08 23:39 ` Gene Chen
2020-09-08 23:39 ` Gene Chen
2020-09-08 23:39 ` Gene Chen
2020-09-09 9:34 ` Jonathan Cameron
2020-09-09 9:34 ` Jonathan Cameron
2020-09-09 9:34 ` Jonathan Cameron
2020-09-10 0:14 ` Gene Chen
2020-09-10 0:14 ` Gene Chen
2020-09-10 0:14 ` Gene Chen
2020-08-30 17:39 ` Andy Shevchenko
2020-08-30 17:39 ` Andy Shevchenko
2020-08-30 17:39 ` Andy Shevchenko
2020-08-24 9:06 ` [PATCH v3 2/2] Documentation: ABI: testing: mt6360: Add ADC sysfs guideline Gene Chen
2020-08-24 9:06 ` Gene Chen
2020-08-24 9:06 ` Gene Chen
2020-08-29 17:15 ` Jonathan Cameron
2020-08-29 17:15 ` Jonathan Cameron
2020-08-29 17:15 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAHp75VcX6P9LOw=1=UgX4tWaxa2_PYPvanpDLG0TE2XzPBatAg@mail.gmail.com' \
--to=andy.shevchenko@gmail.com \
--cc=Wilma.Wu@mediatek.com \
--cc=benjamin.chao@mediatek.com \
--cc=cy_huang@richtek.com \
--cc=gene.chen.richtek@gmail.com \
--cc=gene_chen@richtek.com \
--cc=jic23@kernel.org \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=pmeerw@pmeerw.net \
--cc=shufan_lee@richtek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.