From: Andy Shevchenko <andy.shevchenko@gmail.com>
To: David Lechner <david@lechnology.com>
Cc: dri-devel@lists.freedesktop.org,
devicetree <devicetree@vger.kernel.org>,
"Noralf Trønnes" <noralf@tronnes.org>,
"David Airlie" <airlied@linux.ie>,
"Rob Herring" <robh+dt@kernel.org>,
"Mark Rutland" <mark.rutland@arm.com>,
"Sekhar Nori" <nsekhar@ti.com>,
"Kevin Hilman" <khilman@kernel.org>,
linux-fbdev@vger.kernel.org,
"linux-arm Mailing List" <linux-arm-kernel@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 4/6] drm/tinydrm: mipi-panel: refactor to use driver id
Date: Sun, 30 Jul 2017 21:24:03 +0300 [thread overview]
Message-ID: <CAHp75VcdGi=TkB_7fPHROYoKJFUPZPGi=HvUAHuAvgZy-1_Epw@mail.gmail.com> (raw)
In-Reply-To: <1501355870-13960-5-git-send-email-david@lechnology.com>
On Sat, Jul 29, 2017 at 10:17 PM, David Lechner <david@lechnology.com> wrote:
> This refactors the mipi-panel module to use the driver id for panel-specific
> data. This is in preparation for adding additional panels.
>
Wouldn't be better to split glue driver from what looks like more
generic in the first place? Then you will not need to spread some
stuff
over generic files.
Are we going to disrupt genericy of the framework already with second driver?!
--
With Best Regards,
Andy Shevchenko
WARNING: multiple messages have this Message-ID (diff)
From: Andy Shevchenko <andy.shevchenko-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
To: David Lechner <david-nq/r/kbU++upp/zk7JDF2g@public.gmane.org>
Cc: dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org,
devicetree <devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
"Noralf Trønnes" <noralf-L59+Z2yzLopAfugRpC6u6w@public.gmane.org>,
"David Airlie" <airlied-cv59FeDIM0c@public.gmane.org>,
"Rob Herring" <robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
"Mark Rutland" <mark.rutland-5wv7dgnIgG8@public.gmane.org>,
"Sekhar Nori" <nsekhar-l0cyMroinI0@public.gmane.org>,
"Kevin Hilman" <khilman-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
linux-fbdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
"linux-arm Mailing List"
<linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org>,
"linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Subject: Re: [PATCH 4/6] drm/tinydrm: mipi-panel: refactor to use driver id
Date: Sun, 30 Jul 2017 21:24:03 +0300 [thread overview]
Message-ID: <CAHp75VcdGi=TkB_7fPHROYoKJFUPZPGi=HvUAHuAvgZy-1_Epw@mail.gmail.com> (raw)
In-Reply-To: <1501355870-13960-5-git-send-email-david-nq/r/kbU++upp/zk7JDF2g@public.gmane.org>
On Sat, Jul 29, 2017 at 10:17 PM, David Lechner <david-nq/r/kbU++upp/zk7JDF2g@public.gmane.org> wrote:
> This refactors the mipi-panel module to use the driver id for panel-specific
> data. This is in preparation for adding additional panels.
>
Wouldn't be better to split glue driver from what looks like more
generic in the first place? Then you will not need to spread some
stuff
over generic files.
Are we going to disrupt genericy of the framework already with second driver?!
--
With Best Regards,
Andy Shevchenko
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: Andy Shevchenko <andy.shevchenko@gmail.com>
To: David Lechner <david-nq/r/kbU++upp/zk7JDF2g@public.gmane.org>
Cc: dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org,
devicetree <devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
"Noralf Trønnes" <noralf-L59+Z2yzLopAfugRpC6u6w@public.gmane.org>,
"David Airlie" <airlied-cv59FeDIM0c@public.gmane.org>,
"Rob Herring" <robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
"Mark Rutland" <mark.rutland-5wv7dgnIgG8@public.gmane.org>,
"Sekhar Nori" <nsekhar-l0cyMroinI0@public.gmane.org>,
"Kevin Hilman" <khilman-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
linux-fbdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
"linux-arm Mailing List"
<linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org>,
"linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Subject: Re: [PATCH 4/6] drm/tinydrm: mipi-panel: refactor to use driver id
Date: Sun, 30 Jul 2017 18:24:03 +0000 [thread overview]
Message-ID: <CAHp75VcdGi=TkB_7fPHROYoKJFUPZPGi=HvUAHuAvgZy-1_Epw@mail.gmail.com> (raw)
In-Reply-To: <1501355870-13960-5-git-send-email-david-nq/r/kbU++upp/zk7JDF2g@public.gmane.org>
On Sat, Jul 29, 2017 at 10:17 PM, David Lechner <david@lechnology.com> wrote:
> This refactors the mipi-panel module to use the driver id for panel-specific
> data. This is in preparation for adding additional panels.
>
Wouldn't be better to split glue driver from what looks like more
generic in the first place? Then you will not need to spread some
stuff
over generic files.
Are we going to disrupt genericy of the framework already with second driver?!
--
With Best Regards,
Andy Shevchenko
WARNING: multiple messages have this Message-ID (diff)
From: andy.shevchenko@gmail.com (Andy Shevchenko)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 4/6] drm/tinydrm: mipi-panel: refactor to use driver id
Date: Sun, 30 Jul 2017 21:24:03 +0300 [thread overview]
Message-ID: <CAHp75VcdGi=TkB_7fPHROYoKJFUPZPGi=HvUAHuAvgZy-1_Epw@mail.gmail.com> (raw)
In-Reply-To: <1501355870-13960-5-git-send-email-david@lechnology.com>
On Sat, Jul 29, 2017 at 10:17 PM, David Lechner <david@lechnology.com> wrote:
> This refactors the mipi-panel module to use the driver id for panel-specific
> data. This is in preparation for adding additional panels.
>
Wouldn't be better to split glue driver from what looks like more
generic in the first place? Then you will not need to spread some
stuff
over generic files.
Are we going to disrupt genericy of the framework already with second driver?!
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2017-07-30 18:24 UTC|newest]
Thread overview: 112+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-29 19:17 [PATCH 0/6] Support for LEGO MINDSTORMS EV3 LCD display David Lechner
2017-07-29 19:17 ` David Lechner
2017-07-29 19:17 ` David Lechner
2017-07-29 19:17 ` [PATCH 1/6] drm/tinydrm: Add parameter for MIPI DCS pixel format David Lechner
2017-07-29 19:17 ` David Lechner
2017-07-29 19:17 ` David Lechner
2017-07-29 19:17 ` David Lechner
2017-07-30 18:10 ` Andy Shevchenko
2017-07-30 18:10 ` Andy Shevchenko
2017-07-30 18:10 ` Andy Shevchenko
2017-07-30 18:10 ` Andy Shevchenko
2017-07-29 19:17 ` [PATCH 2/6] drm/tinydrm: add helpers for ST7586 controllers David Lechner
2017-07-29 19:17 ` David Lechner
2017-07-29 19:17 ` David Lechner
2017-07-30 18:19 ` Andy Shevchenko
2017-07-30 18:19 ` Andy Shevchenko
2017-07-30 18:19 ` Andy Shevchenko
2017-07-30 18:19 ` Andy Shevchenko
2017-07-29 19:17 ` [PATCH 3/6] drm/tinydrm: rename mi028qt module to mipi-panel David Lechner
2017-07-29 19:17 ` David Lechner
2017-07-29 19:17 ` David Lechner
2017-07-29 19:17 ` David Lechner
2017-07-29 19:30 ` David Lechner
2017-07-29 19:30 ` David Lechner
2017-07-29 19:30 ` David Lechner
2017-07-29 19:30 ` David Lechner
2017-07-29 19:17 ` [PATCH 4/6] drm/tinydrm: mipi-panel: refactor to use driver id David Lechner
2017-07-29 19:17 ` David Lechner
2017-07-29 19:17 ` David Lechner
2017-07-30 18:24 ` Andy Shevchenko [this message]
2017-07-30 18:24 ` Andy Shevchenko
2017-07-30 18:24 ` Andy Shevchenko
2017-07-30 18:24 ` Andy Shevchenko
2017-07-29 19:17 ` [PATCH 5/6] drm/tinydrm: add support for LEGO MINDSTORMS EV3 LCD David Lechner
2017-07-29 19:17 ` David Lechner
2017-07-29 19:17 ` David Lechner
2017-07-30 18:26 ` Andy Shevchenko
2017-07-30 18:26 ` Andy Shevchenko
2017-07-30 18:26 ` Andy Shevchenko
2017-07-30 18:26 ` Andy Shevchenko
2017-07-29 19:17 ` [PATCH 6/6] ARM: dts: da850-lego-ev3: Add node for LCD display David Lechner
2017-07-29 19:17 ` David Lechner
2017-07-29 19:17 ` David Lechner
2017-07-29 19:40 ` [PATCH 0/6] Support for LEGO MINDSTORMS EV3 " David Lechner
2017-07-29 19:40 ` David Lechner
2017-07-29 19:40 ` David Lechner
2017-07-30 17:14 ` Noralf Trønnes
2017-07-30 17:14 ` Noralf Trønnes
2017-07-30 17:14 ` Noralf Trønnes
2017-07-30 17:14 ` Noralf Trønnes
2017-08-01 16:51 ` David Lechner
2017-08-01 16:51 ` David Lechner
2017-08-01 16:51 ` David Lechner
2017-08-01 16:51 ` David Lechner
2017-08-01 18:08 ` Noralf Trønnes
2017-08-01 18:08 ` Noralf Trønnes
2017-08-01 18:08 ` Noralf Trønnes
2017-08-01 18:08 ` Noralf Trønnes
2017-08-01 22:26 ` David Lechner
2017-08-01 22:26 ` David Lechner
2017-08-01 22:26 ` David Lechner
2017-08-01 22:26 ` David Lechner
2017-08-02 8:05 ` Noralf Trønnes
2017-08-02 8:05 ` Noralf Trønnes
2017-08-02 8:05 ` Noralf Trønnes
2017-08-02 8:05 ` Noralf Trønnes
2017-08-02 16:05 ` David Lechner
2017-08-02 16:05 ` David Lechner
2017-08-02 16:05 ` David Lechner
2017-08-03 10:05 ` Daniel Vetter
2017-08-03 10:05 ` Daniel Vetter
2017-08-03 10:05 ` Daniel Vetter
2017-08-03 10:05 ` Daniel Vetter
2017-08-03 14:07 ` Noralf Trønnes
2017-08-03 14:07 ` Noralf Trønnes
2017-08-03 14:07 ` Noralf Trønnes
2017-08-03 14:07 ` Noralf Trønnes
2017-08-03 15:18 ` David Lechner
2017-08-03 15:18 ` David Lechner
2017-08-03 15:18 ` David Lechner
2017-08-03 15:18 ` David Lechner
2017-08-03 17:09 ` Andy Shevchenko
2017-08-03 17:09 ` Andy Shevchenko
2017-08-03 17:09 ` Andy Shevchenko
2017-08-03 17:09 ` Andy Shevchenko
2017-08-03 17:11 ` Andy Shevchenko
2017-08-03 17:11 ` Andy Shevchenko
2017-08-03 17:11 ` Andy Shevchenko
2017-08-03 17:11 ` Andy Shevchenko
2017-08-03 20:11 ` Noralf Trønnes
2017-08-03 20:11 ` Noralf Trønnes
2017-08-03 20:11 ` Noralf Trønnes
2017-08-03 20:11 ` Noralf Trønnes
2017-08-04 1:08 ` David Lechner
2017-08-04 1:08 ` David Lechner
2017-08-04 1:08 ` David Lechner
2017-08-04 1:08 ` David Lechner
2017-08-04 1:16 ` David Lechner
2017-08-04 1:16 ` David Lechner
2017-08-04 1:16 ` David Lechner
2017-08-04 1:16 ` David Lechner
2017-07-30 17:12 ` Noralf Trønnes
2017-07-30 17:12 ` Noralf Trønnes
2017-07-30 17:12 ` Noralf Trønnes
2017-07-30 18:27 ` Andy Shevchenko
2017-07-30 18:27 ` Andy Shevchenko
2017-07-30 18:27 ` Andy Shevchenko
2017-07-30 18:27 ` Andy Shevchenko
2017-07-30 18:27 ` Andy Shevchenko
2017-07-30 18:27 ` Andy Shevchenko
2017-07-30 18:27 ` Andy Shevchenko
2017-07-30 18:27 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAHp75VcdGi=TkB_7fPHROYoKJFUPZPGi=HvUAHuAvgZy-1_Epw@mail.gmail.com' \
--to=andy.shevchenko@gmail.com \
--cc=airlied@linux.ie \
--cc=david@lechnology.com \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=khilman@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=noralf@tronnes.org \
--cc=nsekhar@ti.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.