* [PATCH 1/1] asus-wireless: Fix identation
@ 2017-01-26 14:25 João Paulo Rechi Vita
2017-01-27 15:28 ` Andy Shevchenko
0 siblings, 1 reply; 9+ messages in thread
From: João Paulo Rechi Vita @ 2017-01-26 14:25 UTC (permalink / raw)
To: Darren Hart
Cc: platform-driver-x86, acpi4asus-user, linux-kernel, linux,
João Paulo Rechi Vita
Signed-off-by: João Paulo Rechi Vita <jprvita@endlessm.com>
---
drivers/platform/x86/asus-wireless.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/platform/x86/asus-wireless.c b/drivers/platform/x86/asus-wireless.c
index 9f31bc1a47d0..c9b5ac152cf1 100644
--- a/drivers/platform/x86/asus-wireless.c
+++ b/drivers/platform/x86/asus-wireless.c
@@ -77,7 +77,7 @@ static void led_state_update(struct work_struct *work)
}
static void led_state_set(struct led_classdev *led,
- enum led_brightness value)
+ enum led_brightness value)
{
struct asus_wireless_data *data;
--
2.11.0
^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: [PATCH 1/1] asus-wireless: Fix identation
2017-01-26 14:25 [PATCH 1/1] asus-wireless: Fix identation João Paulo Rechi Vita
@ 2017-01-27 15:28 ` Andy Shevchenko
2017-02-01 12:24 ` João Paulo Rechi Vita
0 siblings, 1 reply; 9+ messages in thread
From: Andy Shevchenko @ 2017-01-27 15:28 UTC (permalink / raw)
To: João Paulo Rechi Vita
Cc: Darren Hart, Platform Driver, acpi4asus-user, linux-kernel,
linux, João Paulo Rechi Vita
On Thu, Jan 26, 2017 at 4:25 PM, João Paulo Rechi Vita
<jprvita@gmail.com> wrote:
> Signed-off-by: João Paulo Rechi Vita <jprvita@endlessm.com>
> ---
> drivers/platform/x86/asus-wireless.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/platform/x86/asus-wireless.c b/drivers/platform/x86/asus-wireless.c
> index 9f31bc1a47d0..c9b5ac152cf1 100644
> --- a/drivers/platform/x86/asus-wireless.c
> +++ b/drivers/platform/x86/asus-wireless.c
> @@ -77,7 +77,7 @@ static void led_state_update(struct work_struct *work)
> }
>
> static void led_state_set(struct led_classdev *led,
> - enum led_brightness value)
> + enum led_brightness value)
I would see benefit if it would be one line.
> {
> struct asus_wireless_data *data;
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH 1/1] asus-wireless: Fix identation
2017-01-27 15:28 ` Andy Shevchenko
@ 2017-02-01 12:24 ` João Paulo Rechi Vita
0 siblings, 0 replies; 9+ messages in thread
From: João Paulo Rechi Vita @ 2017-02-01 12:24 UTC (permalink / raw)
To: Andy Shevchenko
Cc: Darren Hart, Platform Driver, acpi4asus-user, linux-kernel,
linux, João Paulo Rechi Vita
On 27 January 2017 at 10:28, Andy Shevchenko <andy.shevchenko@gmail.com> wrote:
> On Thu, Jan 26, 2017 at 4:25 PM, João Paulo Rechi Vita
> <jprvita@gmail.com> wrote:
>> Signed-off-by: João Paulo Rechi Vita <jprvita@endlessm.com>
>> ---
>> drivers/platform/x86/asus-wireless.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/platform/x86/asus-wireless.c b/drivers/platform/x86/asus-wireless.c
>> index 9f31bc1a47d0..c9b5ac152cf1 100644
>> --- a/drivers/platform/x86/asus-wireless.c
>> +++ b/drivers/platform/x86/asus-wireless.c
>> @@ -77,7 +77,7 @@ static void led_state_update(struct work_struct *work)
>> }
>>
>> static void led_state_set(struct led_classdev *led,
>> - enum led_brightness value)
>> + enum led_brightness value)
>
> I would see benefit if it would be one line.
>
Yes, I fixed this in a hurry and missed it actually fits in one line.
Thanks for catching it! I'll reply with an updated patch.
--
João Paulo Rechi Vita
http://about.me/jprvita
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH 1/1] asus-wireless: Fix identation
@ 2017-02-01 12:24 ` João Paulo Rechi Vita
0 siblings, 0 replies; 9+ messages in thread
From: João Paulo Rechi Vita @ 2017-02-01 12:24 UTC (permalink / raw)
To: Andy Shevchenko
Cc: Darren Hart, Platform Driver, acpi4asus-user, linux-kernel,
linux, João Paulo Rechi Vita
On 27 January 2017 at 10:28, Andy Shevchenko <andy.shevchenko@gmail.com> wrote:
> On Thu, Jan 26, 2017 at 4:25 PM, João Paulo Rechi Vita
> <jprvita@gmail.com> wrote:
>> Signed-off-by: João Paulo Rechi Vita <jprvita@endlessm.com>
>> ---
>> drivers/platform/x86/asus-wireless.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/platform/x86/asus-wireless.c b/drivers/platform/x86/asus-wireless.c
>> index 9f31bc1a47d0..c9b5ac152cf1 100644
>> --- a/drivers/platform/x86/asus-wireless.c
>> +++ b/drivers/platform/x86/asus-wireless.c
>> @@ -77,7 +77,7 @@ static void led_state_update(struct work_struct *work)
>> }
>>
>> static void led_state_set(struct led_classdev *led,
>> - enum led_brightness value)
>> + enum led_brightness value)
>
> I would see benefit if it would be one line.
>
Yes, I fixed this in a hurry and missed it actually fits in one line.
Thanks for catching it! I'll reply with an updated patch.
^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH] asus-wireless: Fix identation
2017-02-01 12:24 ` João Paulo Rechi Vita
(?)
@ 2017-02-01 12:27 ` João Paulo Rechi Vita
2017-02-04 15:08 ` Andy Shevchenko
-1 siblings, 1 reply; 9+ messages in thread
From: João Paulo Rechi Vita @ 2017-02-01 12:27 UTC (permalink / raw)
To: Darren Hart, Andy Shevchenko
Cc: platform-driver-x86, acpi4asus-user, linux-kernel, linux,
João Paulo Rechi Vita
Signed-off-by: João Paulo Rechi Vita <jprvita@endlessm.com>
---
drivers/platform/x86/asus-wireless.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/platform/x86/asus-wireless.c b/drivers/platform/x86/asus-wireless.c
index 9f31bc1a47d0..a7ee18383146 100644
--- a/drivers/platform/x86/asus-wireless.c
+++ b/drivers/platform/x86/asus-wireless.c
@@ -76,8 +76,7 @@ static void led_state_update(struct work_struct *work)
data->led_state);
}
-static void led_state_set(struct led_classdev *led,
- enum led_brightness value)
+static void led_state_set(struct led_classdev *led, enum led_brightness value)
{
struct asus_wireless_data *data;
--
2.11.0
^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: [PATCH] asus-wireless: Fix identation
2017-02-01 12:27 ` [PATCH] " João Paulo Rechi Vita
@ 2017-02-04 15:08 ` Andy Shevchenko
2017-02-04 15:10 ` Andy Shevchenko
0 siblings, 1 reply; 9+ messages in thread
From: Andy Shevchenko @ 2017-02-04 15:08 UTC (permalink / raw)
To: João Paulo Rechi Vita
Cc: Darren Hart, Platform Driver, acpi4asus-user, linux-kernel,
linux, João Paulo Rechi Vita
On Wed, Feb 1, 2017 at 2:27 PM, João Paulo Rechi Vita <jprvita@gmail.com> wrote:
Do not leave empty commit message. Describe your changes here in a few words.
For the drivers/platform/x86 use a pattern in subject
platform/x86: asus-wireless: ...
> Signed-off-by: João Paulo Rechi Vita <jprvita@endlessm.com>
> ---
> drivers/platform/x86/asus-wireless.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/platform/x86/asus-wireless.c b/drivers/platform/x86/asus-wireless.c
> index 9f31bc1a47d0..a7ee18383146 100644
> --- a/drivers/platform/x86/asus-wireless.c
> +++ b/drivers/platform/x86/asus-wireless.c
> @@ -76,8 +76,7 @@ static void led_state_update(struct work_struct *work)
> data->led_state);
> }
>
> -static void led_state_set(struct led_classdev *led,
> - enum led_brightness value)
> +static void led_state_set(struct led_classdev *led, enum led_brightness value)
> {
> struct asus_wireless_data *data;
>
> --
> 2.11.0
>
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] asus-wireless: Fix identation
2017-02-04 15:08 ` Andy Shevchenko
@ 2017-02-04 15:10 ` Andy Shevchenko
2017-02-06 15:20 ` [PATCHv3] platform/x86: " João Paulo Rechi Vita
0 siblings, 1 reply; 9+ messages in thread
From: Andy Shevchenko @ 2017-02-04 15:10 UTC (permalink / raw)
To: João Paulo Rechi Vita
Cc: Darren Hart, Platform Driver, acpi4asus-user, linux-kernel,
linux, João Paulo Rechi Vita
On Sat, Feb 4, 2017 at 5:08 PM, Andy Shevchenko
<andy.shevchenko@gmail.com> wrote:
> On Wed, Feb 1, 2017 at 2:27 PM, João Paulo Rechi Vita <jprvita@gmail.com> wrote:
>
> Do not leave empty commit message. Describe your changes here in a few words.
>
> For the drivers/platform/x86 use a pattern in subject
>
> platform/x86: asus-wireless: ...
And one more, use versioning of your patches: PATCHv1, PATCHv2, ...
>
>> Signed-off-by: João Paulo Rechi Vita <jprvita@endlessm.com>
>> ---
>> drivers/platform/x86/asus-wireless.c | 3 +--
>> 1 file changed, 1 insertion(+), 2 deletions(-)
>>
>> diff --git a/drivers/platform/x86/asus-wireless.c b/drivers/platform/x86/asus-wireless.c
>> index 9f31bc1a47d0..a7ee18383146 100644
>> --- a/drivers/platform/x86/asus-wireless.c
>> +++ b/drivers/platform/x86/asus-wireless.c
>> @@ -76,8 +76,7 @@ static void led_state_update(struct work_struct *work)
>> data->led_state);
>> }
>>
>> -static void led_state_set(struct led_classdev *led,
>> - enum led_brightness value)
>> +static void led_state_set(struct led_classdev *led, enum led_brightness value)
>> {
>> struct asus_wireless_data *data;
>>
>> --
>> 2.11.0
>>
>
>
>
> --
> With Best Regards,
> Andy Shevchenko
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCHv3] platform/x86: asus-wireless: Fix identation
2017-02-04 15:10 ` Andy Shevchenko
@ 2017-02-06 15:20 ` João Paulo Rechi Vita
2017-02-07 10:22 ` Andy Shevchenko
0 siblings, 1 reply; 9+ messages in thread
From: João Paulo Rechi Vita @ 2017-02-06 15:20 UTC (permalink / raw)
To: Darren Hart, Andy Shevchenko
Cc: platform-driver-x86, acpi4asus-user, linux-kernel, linux,
João Paulo Rechi Vita
Fix identation problem introduced when this driver was first merged into
the kernel.
Signed-off-by: João Paulo Rechi Vita <jprvita@endlessm.com>
---
drivers/platform/x86/asus-wireless.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/platform/x86/asus-wireless.c b/drivers/platform/x86/asus-wireless.c
index 9f31bc1a47d0..a7ee18383146 100644
--- a/drivers/platform/x86/asus-wireless.c
+++ b/drivers/platform/x86/asus-wireless.c
@@ -76,8 +76,7 @@ static void led_state_update(struct work_struct *work)
data->led_state);
}
-static void led_state_set(struct led_classdev *led,
- enum led_brightness value)
+static void led_state_set(struct led_classdev *led, enum led_brightness value)
{
struct asus_wireless_data *data;
--
2.11.0
^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: [PATCHv3] platform/x86: asus-wireless: Fix identation
2017-02-06 15:20 ` [PATCHv3] platform/x86: " João Paulo Rechi Vita
@ 2017-02-07 10:22 ` Andy Shevchenko
0 siblings, 0 replies; 9+ messages in thread
From: Andy Shevchenko @ 2017-02-07 10:22 UTC (permalink / raw)
To: João Paulo Rechi Vita
Cc: Darren Hart, Platform Driver, acpi4asus-user, linux-kernel,
linux, João Paulo Rechi Vita
On Mon, Feb 6, 2017 at 5:20 PM, João Paulo Rechi Vita <jprvita@gmail.com> wrote:
> Fix identation problem introduced when this driver was first merged into
> the kernel.
Thanks, pushed to testing.
>
> Signed-off-by: João Paulo Rechi Vita <jprvita@endlessm.com>
> ---
> drivers/platform/x86/asus-wireless.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/platform/x86/asus-wireless.c b/drivers/platform/x86/asus-wireless.c
> index 9f31bc1a47d0..a7ee18383146 100644
> --- a/drivers/platform/x86/asus-wireless.c
> +++ b/drivers/platform/x86/asus-wireless.c
> @@ -76,8 +76,7 @@ static void led_state_update(struct work_struct *work)
> data->led_state);
> }
>
> -static void led_state_set(struct led_classdev *led,
> - enum led_brightness value)
> +static void led_state_set(struct led_classdev *led, enum led_brightness value)
> {
> struct asus_wireless_data *data;
>
> --
> 2.11.0
>
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2017-02-07 10:22 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-01-26 14:25 [PATCH 1/1] asus-wireless: Fix identation João Paulo Rechi Vita
2017-01-27 15:28 ` Andy Shevchenko
2017-02-01 12:24 ` João Paulo Rechi Vita
2017-02-01 12:24 ` João Paulo Rechi Vita
2017-02-01 12:27 ` [PATCH] " João Paulo Rechi Vita
2017-02-04 15:08 ` Andy Shevchenko
2017-02-04 15:10 ` Andy Shevchenko
2017-02-06 15:20 ` [PATCHv3] platform/x86: " João Paulo Rechi Vita
2017-02-07 10:22 ` Andy Shevchenko
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.