From: Andy Shevchenko <andy.shevchenko@gmail.com>
To: Joakim Tjernlund <Joakim.Tjernlund@infinera.com>
Cc: "chris.packham@alliedtelesis.co.nz"
<chris.packham@alliedtelesis.co.nz>,
"linuxppc-dev@lists.ozlabs.org" <linuxppc-dev@lists.ozlabs.org>,
"linux-i2c@vger.kernel.org" <linux-i2c@vger.kernel.org>,
"andriy.shevchenko@linux.intel.com"
<andriy.shevchenko@linux.intel.com>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"wsa@kernel.org" <wsa@kernel.org>,
"robh+dt@kernel.org" <robh+dt@kernel.org>
Subject: Re: [PATCH v2 3/3] i2c: mpc: implement erratum A-004447 workaround
Date: Fri, 7 May 2021 18:36:56 +0300 [thread overview]
Message-ID: <CAHp75Vcu-k=uzY_JYhtMp=Oe7fph3jH=t41pStUGc+bpSZeA3w@mail.gmail.com> (raw)
In-Reply-To: <c4fa78e8f2c43da240c932618b87b34ba2d1d046.camel@infinera.com>
On Fri, May 7, 2021 at 5:52 PM Joakim Tjernlund
<Joakim.Tjernlund@infinera.com> wrote:
> On Fri, 2021-05-07 at 14:46 +0300, Andy Shevchenko wrote:
> > On Fri, May 7, 2021 at 3:40 AM Chris Packham
> > <chris.packham@alliedtelesis.co.nz> wrote:
...
> > So, now you may shrink it even further, i.e.
> >
> > void __iomem *sr = i2c->base + MPC_I2C_SR;
> > u8 val;
> >
> > return readb_poll_timeout(sr, val, val & mask, 0, 100);
> >
>
> val looks uninitialised before use?
Nope.
Thinking about naming, perhaps
void __iomem *addr = i2c->base + MPC_I2C_SR;
u8 sr; // or leave as val?
return readb_poll_timeout(addr, sr, sr & mask, 0, 100);
would be more clear.
--
With Best Regards,
Andy Shevchenko
WARNING: multiple messages have this Message-ID (diff)
From: Andy Shevchenko <andy.shevchenko@gmail.com>
To: Joakim Tjernlund <Joakim.Tjernlund@infinera.com>
Cc: "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"robh+dt@kernel.org" <robh+dt@kernel.org>,
"wsa@kernel.org" <wsa@kernel.org>,
"chris.packham@alliedtelesis.co.nz"
<chris.packham@alliedtelesis.co.nz>,
"linux-i2c@vger.kernel.org" <linux-i2c@vger.kernel.org>,
"andriy.shevchenko@linux.intel.com"
<andriy.shevchenko@linux.intel.com>,
"linuxppc-dev@lists.ozlabs.org" <linuxppc-dev@lists.ozlabs.org>
Subject: Re: [PATCH v2 3/3] i2c: mpc: implement erratum A-004447 workaround
Date: Fri, 7 May 2021 18:36:56 +0300 [thread overview]
Message-ID: <CAHp75Vcu-k=uzY_JYhtMp=Oe7fph3jH=t41pStUGc+bpSZeA3w@mail.gmail.com> (raw)
In-Reply-To: <c4fa78e8f2c43da240c932618b87b34ba2d1d046.camel@infinera.com>
On Fri, May 7, 2021 at 5:52 PM Joakim Tjernlund
<Joakim.Tjernlund@infinera.com> wrote:
> On Fri, 2021-05-07 at 14:46 +0300, Andy Shevchenko wrote:
> > On Fri, May 7, 2021 at 3:40 AM Chris Packham
> > <chris.packham@alliedtelesis.co.nz> wrote:
...
> > So, now you may shrink it even further, i.e.
> >
> > void __iomem *sr = i2c->base + MPC_I2C_SR;
> > u8 val;
> >
> > return readb_poll_timeout(sr, val, val & mask, 0, 100);
> >
>
> val looks uninitialised before use?
Nope.
Thinking about naming, perhaps
void __iomem *addr = i2c->base + MPC_I2C_SR;
u8 sr; // or leave as val?
return readb_poll_timeout(addr, sr, sr & mask, 0, 100);
would be more clear.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2021-05-07 15:37 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-07 0:40 [PATCH v2 0/3] P2040/P2041 i2c recovery erratum Chris Packham
2021-05-07 0:40 ` Chris Packham
2021-05-07 0:40 ` [PATCH v2 1/3] dt-bindings: i2c: mpc: Add fsl,i2c-erratum-a004447 flag Chris Packham
2021-05-07 0:40 ` [PATCH v2 1/3] dt-bindings: i2c: mpc: Add fsl, i2c-erratum-a004447 flag Chris Packham
2021-05-07 21:49 ` [PATCH v2 1/3] dt-bindings: i2c: mpc: Add fsl,i2c-erratum-a004447 flag Rob Herring
2021-05-07 21:49 ` Rob Herring
2021-05-09 21:08 ` Chris Packham
2021-05-09 21:08 ` [PATCH v2 1/3] dt-bindings: i2c: mpc: Add fsl, i2c-erratum-a004447 flag Chris Packham
2021-05-11 15:33 ` [PATCH v2 1/3] dt-bindings: i2c: mpc: Add fsl,i2c-erratum-a004447 flag Rob Herring
2021-05-11 15:33 ` [PATCH v2 1/3] dt-bindings: i2c: mpc: Add fsl, i2c-erratum-a004447 flag Rob Herring
2021-05-07 0:40 ` [PATCH v2 2/3] powerpc/fsl: set fsl,i2c-erratum-a004447 flag for P2041 i2c controllers Chris Packham
2021-05-07 0:40 ` [PATCH v2 2/3] powerpc/fsl: set fsl, i2c-erratum-a004447 " Chris Packham
2021-05-07 8:04 ` Joakim Tjernlund
2021-05-07 8:04 ` Joakim Tjernlund
2021-05-07 8:24 ` Joakim Tjernlund
2021-05-07 8:24 ` Joakim Tjernlund
2021-05-09 21:11 ` Chris Packham
2021-05-09 21:11 ` Chris Packham
2021-05-07 0:40 ` [PATCH v2 3/3] i2c: mpc: implement erratum A-004447 workaround Chris Packham
2021-05-07 0:40 ` Chris Packham
2021-05-07 11:46 ` Andy Shevchenko
2021-05-07 11:46 ` Andy Shevchenko
2021-05-07 14:52 ` Joakim Tjernlund
2021-05-07 14:52 ` Joakim Tjernlund
2021-05-07 15:36 ` Andy Shevchenko [this message]
2021-05-07 15:36 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAHp75Vcu-k=uzY_JYhtMp=Oe7fph3jH=t41pStUGc+bpSZeA3w@mail.gmail.com' \
--to=andy.shevchenko@gmail.com \
--cc=Joakim.Tjernlund@infinera.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=chris.packham@alliedtelesis.co.nz \
--cc=devicetree@vger.kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=robh+dt@kernel.org \
--cc=wsa@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.