All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andy Shevchenko <andy.shevchenko@gmail.com>
To: Nicolas Pitre <nicolas.pitre@linaro.org>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Jiri Slaby <jslaby@suse.com>,
	"linux-serial@vger.kernel.org" <linux-serial@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	linux-arm Mailing List <linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH v2 3/5] serial: small Makefile reordering
Date: Sun, 2 Apr 2017 15:55:58 +0300	[thread overview]
Message-ID: <CAHp75VdFBSWmEk9e3bFKu3Kx7EjigrrFrL82+iRsxrW7dC1FoA@mail.gmail.com> (raw)
In-Reply-To: <20170401222119.25106-4-nicolas.pitre@linaro.org>

On Sun, Apr 2, 2017 at 1:21 AM, Nicolas Pitre <nicolas.pitre@linaro.org> wrote:
> Move 21285 entry down alongside other UART drivers to be more consistent
> with the rest of the file. It is kept before 8250 though, to preserve the
> existing link ordering between those two.

I did once for entire Makefile (some logical reordering), but Greg
objected it. Perhaps you can sell it better.

http://www.spinics.net/lists/linux-serial/msg23616.html

>
> Signed-off-by: Nicolas Pitre <nico@linaro.org>
> ---
>  drivers/tty/serial/Makefile | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/tty/serial/Makefile b/drivers/tty/serial/Makefile
> index 2d6288bc45..53c03e0051 100644
> --- a/drivers/tty/serial/Makefile
> +++ b/drivers/tty/serial/Makefile
> @@ -3,7 +3,6 @@
>  #
>
>  obj-$(CONFIG_SERIAL_CORE) += serial_core.o
> -obj-$(CONFIG_SERIAL_21285) += 21285.o
>
>  obj-$(CONFIG_SERIAL_EARLYCON) += earlycon.o
>  obj-$(CONFIG_SERIAL_EARLYCON_ARM_SEMIHOST) += earlycon-arm-semihost.o
> @@ -17,6 +16,8 @@ obj-$(CONFIG_SERIAL_SUNZILOG) += sunzilog.o
>  obj-$(CONFIG_SERIAL_SUNSU) += sunsu.o
>  obj-$(CONFIG_SERIAL_SUNSAB) += sunsab.o
>
> +obj-$(CONFIG_SERIAL_21285) += 21285.o
> +
>  # Now bring in any enabled 8250/16450/16550 type drivers.
>  obj-$(CONFIG_SERIAL_8250) += 8250/
>
> --
> 2.9.3
>



-- 
With Best Regards,
Andy Shevchenko

WARNING: multiple messages have this Message-ID (diff)
From: andy.shevchenko@gmail.com (Andy Shevchenko)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 3/5] serial: small Makefile reordering
Date: Sun, 2 Apr 2017 15:55:58 +0300	[thread overview]
Message-ID: <CAHp75VdFBSWmEk9e3bFKu3Kx7EjigrrFrL82+iRsxrW7dC1FoA@mail.gmail.com> (raw)
In-Reply-To: <20170401222119.25106-4-nicolas.pitre@linaro.org>

On Sun, Apr 2, 2017 at 1:21 AM, Nicolas Pitre <nicolas.pitre@linaro.org> wrote:
> Move 21285 entry down alongside other UART drivers to be more consistent
> with the rest of the file. It is kept before 8250 though, to preserve the
> existing link ordering between those two.

I did once for entire Makefile (some logical reordering), but Greg
objected it. Perhaps you can sell it better.

http://www.spinics.net/lists/linux-serial/msg23616.html

>
> Signed-off-by: Nicolas Pitre <nico@linaro.org>
> ---
>  drivers/tty/serial/Makefile | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/tty/serial/Makefile b/drivers/tty/serial/Makefile
> index 2d6288bc45..53c03e0051 100644
> --- a/drivers/tty/serial/Makefile
> +++ b/drivers/tty/serial/Makefile
> @@ -3,7 +3,6 @@
>  #
>
>  obj-$(CONFIG_SERIAL_CORE) += serial_core.o
> -obj-$(CONFIG_SERIAL_21285) += 21285.o
>
>  obj-$(CONFIG_SERIAL_EARLYCON) += earlycon.o
>  obj-$(CONFIG_SERIAL_EARLYCON_ARM_SEMIHOST) += earlycon-arm-semihost.o
> @@ -17,6 +16,8 @@ obj-$(CONFIG_SERIAL_SUNZILOG) += sunzilog.o
>  obj-$(CONFIG_SERIAL_SUNSU) += sunsu.o
>  obj-$(CONFIG_SERIAL_SUNSAB) += sunsab.o
>
> +obj-$(CONFIG_SERIAL_21285) += 21285.o
> +
>  # Now bring in any enabled 8250/16450/16550 type drivers.
>  obj-$(CONFIG_SERIAL_8250) += 8250/
>
> --
> 2.9.3
>



-- 
With Best Regards,
Andy Shevchenko

  reply	other threads:[~2017-04-02 12:56 UTC|newest]

Thread overview: 103+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-04-01 22:21 [PATCH v2 0/5] minitty: a minimal TTY layer alternative for embedded systems Nicolas Pitre
2017-04-01 22:21 ` Nicolas Pitre
2017-04-01 22:21 ` [PATCH v2 1/5] console: move console_init() out of tty_io.c Nicolas Pitre
2017-04-01 22:21   ` Nicolas Pitre
2017-04-01 22:21 ` [PATCH v2 2/5] tty: move baudrate handling code to a file of its own Nicolas Pitre
2017-04-01 22:21   ` Nicolas Pitre
2017-04-01 22:21 ` [PATCH v2 3/5] serial: small Makefile reordering Nicolas Pitre
2017-04-01 22:21   ` Nicolas Pitre
2017-04-02 12:55   ` Andy Shevchenko [this message]
2017-04-02 12:55     ` Andy Shevchenko
2017-04-02 15:49     ` Nicolas Pitre
2017-04-02 15:49       ` Nicolas Pitre
2017-04-01 22:21 ` [PATCH v2 4/5] serial: split generic UART driver helper functions into a separate file Nicolas Pitre
2017-04-01 22:21   ` Nicolas Pitre
2017-04-02 13:16   ` Andy Shevchenko
2017-04-02 13:16     ` Andy Shevchenko
2017-04-02 15:44     ` Nicolas Pitre
2017-04-02 15:44       ` Nicolas Pitre
2017-04-03  7:35   ` kbuild test robot
2017-04-03  7:35     ` kbuild test robot
2017-04-01 22:21 ` [PATCH v2 5/5] minitty: minimal TTY support alternative for serial ports Nicolas Pitre
2017-04-01 22:21   ` Nicolas Pitre
2017-04-02 13:22 ` [PATCH v2 0/5] minitty: a minimal TTY layer alternative for embedded systems Andy Shevchenko
2017-04-02 13:22   ` Andy Shevchenko
2017-04-02 15:55   ` Nicolas Pitre
2017-04-02 15:55     ` Nicolas Pitre
2017-04-03 12:56     ` Alan Cox
2017-04-03 12:56       ` Alan Cox
2017-04-03 16:06       ` Nicolas Pitre
2017-04-03 16:06         ` Nicolas Pitre
2017-04-03 16:06         ` Nicolas Pitre
2017-04-03 18:05         ` Alan Cox
2017-04-03 18:05           ` Alan Cox
2017-04-03 19:50           ` Nicolas Pitre
2017-04-03 19:50             ` Nicolas Pitre
2017-04-04 13:40             ` Alan Cox
2017-04-04 13:40               ` Alan Cox
2017-04-04 19:26               ` Nicolas Pitre
2017-04-04 19:26                 ` Nicolas Pitre
2017-04-02 20:47 ` Andi Kleen
2017-04-02 20:47   ` Andi Kleen
2017-04-02 21:41   ` Nicolas Pitre
2017-04-02 21:41     ` Nicolas Pitre
2017-04-02 22:44     ` Stuart Longland
2017-04-02 22:44       ` Stuart Longland
2017-04-02 22:44       ` Stuart Longland
2017-04-03  1:01       ` Nicolas Pitre
2017-04-03  1:01         ` Nicolas Pitre
2017-04-04  0:39         ` Stuart Longland
2017-04-04  0:39           ` Stuart Longland
2017-04-04  0:39           ` Stuart Longland
2017-04-03 18:14       ` Geert Uytterhoeven
2017-04-03 18:14         ` Geert Uytterhoeven
2017-04-03 18:14         ` Geert Uytterhoeven
2017-04-03 18:57         ` Rob Herring
2017-04-03 18:57           ` Rob Herring
2017-04-03 18:57           ` Rob Herring
2017-04-03 19:46           ` Geert Uytterhoeven
2017-04-03 19:46             ` Geert Uytterhoeven
2017-04-03 19:46             ` Geert Uytterhoeven
2017-04-03 21:05         ` Andy Shevchenko
2017-04-03 21:05           ` Andy Shevchenko
2017-04-03 21:05           ` Andy Shevchenko
2017-04-04 16:59           ` Tom Zanussi
2017-04-04 16:59             ` Tom Zanussi
2017-04-04 16:59             ` Tom Zanussi
2017-04-04 17:08             ` Andy Shevchenko
2017-04-04 17:08               ` Andy Shevchenko
2017-04-04 17:08               ` Andy Shevchenko
2017-04-04 17:59               ` Tom Zanussi
2017-04-04 17:59                 ` Tom Zanussi
2017-04-04 17:59                 ` Tom Zanussi
2017-04-04 18:04                 ` Andy Shevchenko
2017-04-04 18:04                   ` Andy Shevchenko
2017-04-04 18:04                   ` Andy Shevchenko
2017-04-04 18:31                   ` Nicolas Pitre
2017-04-04 18:31                     ` Nicolas Pitre
2017-04-04 18:31                     ` Nicolas Pitre
2017-04-04 19:58                   ` Tom Zanussi
2017-04-04 19:58                     ` Tom Zanussi
2017-04-04 19:58                     ` Tom Zanussi
2017-04-04 20:27                     ` Nicolas Pitre
2017-04-04 20:27                       ` Nicolas Pitre
2017-04-04 20:27                       ` Nicolas Pitre
2017-04-04 18:53             ` Nicolas Pitre
2017-04-04 18:53               ` Nicolas Pitre
2017-04-04 18:53               ` Nicolas Pitre
2017-04-03  7:54     ` Andy Shevchenko
2017-04-03  7:54       ` Andy Shevchenko
2017-04-03 15:31       ` Andi Kleen
2017-04-03 15:31         ` Andi Kleen
2017-04-03 17:27         ` Nicolas Pitre
2017-04-03 17:27           ` Nicolas Pitre
2017-04-03 19:57         ` Adam Borowski
2017-04-03 19:57           ` Adam Borowski
2017-04-03 20:09           ` Nicolas Pitre
2017-04-03 20:09             ` Nicolas Pitre
2017-04-03 20:32             ` Adam Borowski
2017-04-03 20:32               ` Adam Borowski
2017-04-03 16:40       ` Nicolas Pitre
2017-04-03 16:40         ` Nicolas Pitre
2017-04-03  7:44 ` Greg Kroah-Hartman
2017-04-03  7:44   ` Greg Kroah-Hartman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAHp75VdFBSWmEk9e3bFKu3Kx7EjigrrFrL82+iRsxrW7dC1FoA@mail.gmail.com \
    --to=andy.shevchenko@gmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=jslaby@suse.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-serial@vger.kernel.org \
    --cc=nicolas.pitre@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.