From: Andy Shevchenko <andy.shevchenko@gmail.com>
To: Hans de Goede <hdegoede@redhat.com>
Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Benjamin Tissoires <benjamin.tissoires@redhat.com>,
Darren Hart <dvhart@infradead.org>,
Andy Shevchenko <andy@infradead.org>,
linux-input <linux-input@vger.kernel.org>,
Platform Driver <platform-driver-x86@vger.kernel.org>
Subject: Re: [PATCH v2 2/2] platform/x86: silead_dmi: Add silead,home-button property to some tablets
Date: Fri, 17 Nov 2017 18:15:55 +0200 [thread overview]
Message-ID: <CAHp75VdG2xRiy-eKuXRy29kfbONU1bDJUYpyOjX37Yjt=1meAQ@mail.gmail.com> (raw)
In-Reply-To: <fc1a0310-8944-27dc-a464-4ac6409b359b@redhat.com>
On Thu, Nov 16, 2017 at 4:02 PM, Hans de Goede <hdegoede@redhat.com> wrote:
> On 27-10-17 17:26, Hans de Goede wrote:
>> On 27-10-17 16:39, Andy Shevchenko wrote:
>>> On Tue, Oct 17, 2017 at 6:45 PM, Hans de Goede <hdegoede@redhat.com>
>>> wrote:
>>>> Add "silead,home-button" property to entries for tablets which have
>>>> a capacitive home button (typically a windows logo on the front).
>>>>
>>>> This new property is checked for by the new capacitive home button
>>>> support in the silead touchscreen driver.
>>>>
>>>
>>> Acked-by: Andy Shevchenko <andy.shevchenko@gmail.com>
>>>
>>> I suppose it's going through input subsystem as dependent patch?
>>
>>
>> Since silead_dmi tends to see several patches each cycle I don't
>> think that is a good idea, both patches can be merged independently.
>>
>> Either patch will not do anything until the other one is merged,
>> having just one or the other present will not cause any problems,
>> so IMHO merging each patch separately is best.
>>
>> It is probably a good idea to wait for an ack from RobH on the
>> property name before merging this though.
>
>
> This has been Acked by Rob now, so this patch is ready for merging.
> As discussed before both patches can be merged independently of
> each other.
Pushed to my review and testing queue, thanks!
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2017-11-17 16:15 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-17 15:45 [PATCH v2 1/2] Input: silead - Add support for capactive home button found on some x86 tablets Hans de Goede
2017-10-17 15:45 ` [PATCH v2 2/2] platform/x86: silead_dmi: Add silead,home-button property to some tablets Hans de Goede
2017-10-27 14:39 ` Andy Shevchenko
2017-10-27 15:26 ` Hans de Goede
2017-10-27 15:36 ` Andy Shevchenko
2017-11-16 14:02 ` Hans de Goede
2017-11-17 16:15 ` Andy Shevchenko [this message]
2017-10-17 20:13 ` [PATCH v2 1/2] Input: silead - Add support for capactive home button found on some x86 tablets Dmitry Torokhov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAHp75VdG2xRiy-eKuXRy29kfbONU1bDJUYpyOjX37Yjt=1meAQ@mail.gmail.com' \
--to=andy.shevchenko@gmail.com \
--cc=andy@infradead.org \
--cc=benjamin.tissoires@redhat.com \
--cc=dmitry.torokhov@gmail.com \
--cc=dvhart@infradead.org \
--cc=hdegoede@redhat.com \
--cc=linux-input@vger.kernel.org \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.