All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Hans de Goede <hdegoede@redhat.com>
Cc: Benjamin Tissoires <benjamin.tissoires@redhat.com>,
	Darren Hart <dvhart@infradead.org>,
	Andy Shevchenko <andy@infradead.org>,
	"linux-input@vger.kernel.org" <linux-input@vger.kernel.org>,
	Platform Driver <platform-driver-x86@vger.kernel.org>
Subject: Re: [PATCH v2 1/2] Input: silead - Add support for capactive home button found on some x86 tablets
Date: Tue, 17 Oct 2017 13:13:52 -0700	[thread overview]
Message-ID: <CAKdAkRT63uOtsFS-+WuOuzZSGVHPRxDFLg7oCJZkwbA6uBPr4w@mail.gmail.com> (raw)
In-Reply-To: <20171017154512.30524-1-hdegoede@redhat.com>

Hi Hans,

On Tue, Oct 17, 2017 at 8:45 AM, Hans de Goede <hdegoede@redhat.com> wrote:
> On some x86 tablets with a silead touchscreen the windows logo on the
> front is a capacitive home button. Touching this button results in a touch
> with bits 12-15 of the Y coordinates set, while normally only the lower 12
> are used.
>
> Detect this and report a KEY_LEFTMETA press when this happens. Note for
> now we only respond to the Y coordinate bits 12-15 containing 0x01, on some
> tablets *without* a capacative button I've noticed these bits containing
> 0x04 when crossing the edges of the screen.
>
> Signed-off-by: Hans de Goede <hdegoede@redhat.com>
> ---
> Changes in v2:
> -Only enable support for the home-button if a "silead,home-button"
>  boolean device-property is set on the device

You need to add this new property to
Documentation/devicetree/bindings/input/touchscreen/silead_gsl1680.txt
and CC Rob.

Thanks!

-- 
Dmitry

      parent reply	other threads:[~2017-10-17 20:13 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-10-17 15:45 [PATCH v2 1/2] Input: silead - Add support for capactive home button found on some x86 tablets Hans de Goede
2017-10-17 15:45 ` [PATCH v2 2/2] platform/x86: silead_dmi: Add silead,home-button property to some tablets Hans de Goede
2017-10-27 14:39   ` Andy Shevchenko
2017-10-27 15:26     ` Hans de Goede
2017-10-27 15:36       ` Andy Shevchenko
2017-11-16 14:02       ` Hans de Goede
2017-11-17 16:15         ` Andy Shevchenko
2017-10-17 20:13 ` Dmitry Torokhov [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAKdAkRT63uOtsFS-+WuOuzZSGVHPRxDFLg7oCJZkwbA6uBPr4w@mail.gmail.com \
    --to=dmitry.torokhov@gmail.com \
    --cc=andy@infradead.org \
    --cc=benjamin.tissoires@redhat.com \
    --cc=dvhart@infradead.org \
    --cc=hdegoede@redhat.com \
    --cc=linux-input@vger.kernel.org \
    --cc=platform-driver-x86@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.