From: Andy Shevchenko <andy.shevchenko@gmail.com>
To: Janusz Krzysztofik <jmkrzyszt@gmail.com>
Cc: Tony Lindgren <tony@atomide.com>,
Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Boris Brezillon <boris.brezillon@bootlin.com>,
Tomi Valkeinen <tomi.valkeinen@ti.com>,
Mark Brown <broonie@kernel.org>,
Aaro Koskinen <aaro.koskinen@iki.fi>,
Richard Weinberger <richard@nod.at>,
Peter Ujfalusi <peter.ujfalusi@ti.com>,
Jarkko Nikula <jarkko.nikula@bitmer.com>,
Liam Girdwood <lgirdwood@gmail.com>,
linux-arm Mailing List <linux-arm-kernel@lists.infradead.org>,
Linux OMAP Mailing List <linux-omap@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
linux-input <linux-input@vger.kernel.org>,
"open list:MEMORY TECHNOLOGY..." <linux-mtd@lists.infradead.org>,
linux-fbdev@vger.kernel.org,
ALSA Development Mailing List <alsa-devel@alsa-project.org>
Subject: Re: [PATCH 5/6] mtd: rawnand: ams-delta: use GPIO lookup table
Date: Sat, 19 May 2018 00:21:14 +0300 [thread overview]
Message-ID: <CAHp75VdNUW6KoM6oupyQ80A1WVRk7vewwDt6WEZOyjrAUifqRg@mail.gmail.com> (raw)
In-Reply-To: <20180518210954.29044-5-jmkrzyszt@gmail.com>
On Sat, May 19, 2018 at 12:09 AM, Janusz Krzysztofik
<jmkrzyszt@gmail.com> wrote:
> + gpiod_rdy = devm_gpiod_get_optional(&pdev->dev, "rdy", GPIOD_IN);
> + if (!IS_ERR_OR_NULL(gpiod_rdy)) {
So, is it optional or not at the end?
If it is, why do we check for NULL?
> this->dev_ready = ams_delta_nand_ready;
> } else {
> this->dev_ready = NULL;
> pr_notice("Couldn't request gpio for Delta NAND ready.\n");
dev_notice() ?
> }
> +err_gpiod:
> + if (err == -ENODEV || err == -ENOENT)
> + err = -EPROBE_DEFER;
Hmm...
--
With Best Regards,
Andy Shevchenko
WARNING: multiple messages have this Message-ID (diff)
From: Andy Shevchenko <andy.shevchenko@gmail.com>
To: Janusz Krzysztofik <jmkrzyszt@gmail.com>
Cc: Tony Lindgren <tony@atomide.com>,
Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Boris Brezillon <boris.brezillon@bootlin.com>,
Tomi Valkeinen <tomi.valkeinen@ti.com>,
Mark Brown <broonie@kernel.org>,
Aaro Koskinen <aaro.koskinen@iki.fi>,
Richard Weinberger <richard@nod.at>,
Peter Ujfalusi <peter.ujfalusi@ti.com>,
Jarkko Nikula <jarkko.nikula@bitmer.com>,
Liam Girdwood <lgirdwood@gmail.com>,
linux-arm Mailing List <linux-arm-kernel@lists.infradead.org>,
Linux OMAP Mailing List <linux-omap@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
linux-input <linux-input@vger.kernel.org>,
"open list:MEMORY TECHNOLOGY..." <linux-mtd@lists.infradead.org>,
linux-fbdev@vger.kernel.org,
ALSA Development Mailing List <alsa-devel@alsa-project.org>
Subject: Re: [PATCH 5/6] mtd: rawnand: ams-delta: use GPIO lookup table
Date: Fri, 18 May 2018 21:21:14 +0000 [thread overview]
Message-ID: <CAHp75VdNUW6KoM6oupyQ80A1WVRk7vewwDt6WEZOyjrAUifqRg@mail.gmail.com> (raw)
In-Reply-To: <20180518210954.29044-5-jmkrzyszt@gmail.com>
On Sat, May 19, 2018 at 12:09 AM, Janusz Krzysztofik
<jmkrzyszt@gmail.com> wrote:
> + gpiod_rdy = devm_gpiod_get_optional(&pdev->dev, "rdy", GPIOD_IN);
> + if (!IS_ERR_OR_NULL(gpiod_rdy)) {
So, is it optional or not at the end?
If it is, why do we check for NULL?
> this->dev_ready = ams_delta_nand_ready;
> } else {
> this->dev_ready = NULL;
> pr_notice("Couldn't request gpio for Delta NAND ready.\n");
dev_notice() ?
> }
> +err_gpiod:
> + if (err = -ENODEV || err = -ENOENT)
> + err = -EPROBE_DEFER;
Hmm...
--
With Best Regards,
Andy Shevchenko
WARNING: multiple messages have this Message-ID (diff)
From: andy.shevchenko@gmail.com (Andy Shevchenko)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 5/6] mtd: rawnand: ams-delta: use GPIO lookup table
Date: Sat, 19 May 2018 00:21:14 +0300 [thread overview]
Message-ID: <CAHp75VdNUW6KoM6oupyQ80A1WVRk7vewwDt6WEZOyjrAUifqRg@mail.gmail.com> (raw)
In-Reply-To: <20180518210954.29044-5-jmkrzyszt@gmail.com>
On Sat, May 19, 2018 at 12:09 AM, Janusz Krzysztofik
<jmkrzyszt@gmail.com> wrote:
> + gpiod_rdy = devm_gpiod_get_optional(&pdev->dev, "rdy", GPIOD_IN);
> + if (!IS_ERR_OR_NULL(gpiod_rdy)) {
So, is it optional or not at the end?
If it is, why do we check for NULL?
> this->dev_ready = ams_delta_nand_ready;
> } else {
> this->dev_ready = NULL;
> pr_notice("Couldn't request gpio for Delta NAND ready.\n");
dev_notice() ?
> }
> +err_gpiod:
> + if (err == -ENODEV || err == -ENOENT)
> + err = -EPROBE_DEFER;
Hmm...
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2018-05-18 21:21 UTC|newest]
Thread overview: 167+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-18 21:09 [PATCH 1/6] ARM: OMAP1: ams-delta: add GPIO lookup tables Janusz Krzysztofik
2018-05-18 21:09 ` Janusz Krzysztofik
2018-05-18 21:09 ` Janusz Krzysztofik
2018-05-18 21:09 ` [PATCH 2/6] Input: ams_delta_serio: use GPIO lookup table Janusz Krzysztofik
2018-05-18 21:09 ` Janusz Krzysztofik
2018-05-18 21:09 ` Janusz Krzysztofik
2018-05-20 20:17 ` Dmitry Torokhov
2018-05-20 20:17 ` Dmitry Torokhov
2018-05-20 20:17 ` Dmitry Torokhov
2018-05-20 20:17 ` Dmitry Torokhov
2018-05-18 21:09 ` [PATCH 3/6] ASoC: ams_delta: " Janusz Krzysztofik
2018-05-18 21:09 ` Janusz Krzysztofik
2018-05-18 21:09 ` Janusz Krzysztofik
2018-05-21 10:05 ` Mark Brown
2018-05-21 10:05 ` Mark Brown
2018-05-21 10:05 ` Mark Brown
2018-05-23 18:52 ` Tony Lindgren
2018-05-23 18:52 ` Tony Lindgren
2018-05-23 18:52 ` Tony Lindgren
2018-05-24 20:35 ` Janusz Krzysztofik
2018-05-24 20:35 ` Janusz Krzysztofik
2018-05-24 20:35 ` Janusz Krzysztofik
2018-05-24 20:35 ` Janusz Krzysztofik
2018-05-18 21:09 ` [PATCH 4/6] fbdev: omapfb: lcd_ams_delta: " Janusz Krzysztofik
2018-05-18 21:09 ` Janusz Krzysztofik
2018-05-18 21:09 ` Janusz Krzysztofik
2018-05-18 21:09 ` Janusz Krzysztofik
2018-05-25 22:49 ` [Resend] " Janusz Krzysztofik
2018-05-25 22:49 ` Janusz Krzysztofik
2018-07-09 19:16 ` [PATCH v2] video: " Janusz Krzysztofik
2018-07-09 19:16 ` Janusz Krzysztofik
2018-07-17 16:54 ` [PATCH RESEND " Janusz Krzysztofik
2018-07-17 16:54 ` Janusz Krzysztofik
2018-07-17 21:40 ` Janusz Krzysztofik
2018-07-17 21:40 ` Janusz Krzysztofik
2018-05-18 21:09 ` [PATCH 5/6] mtd: rawnand: ams-delta: " Janusz Krzysztofik
2018-05-18 21:09 ` Janusz Krzysztofik
2018-05-18 21:09 ` Janusz Krzysztofik
2018-05-18 21:21 ` Andy Shevchenko [this message]
2018-05-18 21:21 ` Andy Shevchenko
2018-05-18 21:21 ` Andy Shevchenko
2018-05-18 23:15 ` Janusz Krzysztofik
2018-05-18 23:15 ` Janusz Krzysztofik
2018-05-18 23:15 ` Janusz Krzysztofik
2018-05-18 23:15 ` Janusz Krzysztofik
2018-05-19 18:00 ` Andy Shevchenko
2018-05-19 18:00 ` Andy Shevchenko
2018-05-19 18:00 ` Andy Shevchenko
2018-05-19 18:00 ` Andy Shevchenko
2018-05-19 21:55 ` Janusz Krzysztofik
2018-05-19 21:55 ` Janusz Krzysztofik
2018-05-19 21:55 ` Janusz Krzysztofik
2018-05-19 21:55 ` Janusz Krzysztofik
2018-05-20 14:44 ` Andy Shevchenko
2018-05-20 14:44 ` Andy Shevchenko
2018-05-20 14:44 ` Andy Shevchenko
2018-05-20 14:44 ` Andy Shevchenko
2018-05-20 15:37 ` Janusz Krzysztofik
2018-05-20 15:37 ` Janusz Krzysztofik
2018-05-20 15:37 ` Janusz Krzysztofik
2018-05-20 15:37 ` Janusz Krzysztofik
2018-05-20 16:17 ` Andy Shevchenko
2018-05-20 16:17 ` Andy Shevchenko
2018-05-20 16:17 ` Andy Shevchenko
2018-05-20 16:17 ` Andy Shevchenko
2018-05-20 17:25 ` Miquel Raynal
2018-05-20 17:25 ` Miquel Raynal
2018-05-21 6:44 ` Andy Shevchenko
2018-05-21 6:44 ` Andy Shevchenko
2018-05-25 22:20 ` [PATCH 5/6 v2] " Janusz Krzysztofik
2018-05-30 9:05 ` Boris Brezillon
2018-05-30 17:43 ` Janusz Krzysztofik
2018-05-30 17:52 ` Boris Brezillon
2018-05-30 20:39 ` Janusz Krzysztofik
2018-06-04 9:55 ` Boris Brezillon
2018-06-04 16:48 ` Janusz Krzysztofik
2018-06-04 23:09 ` Boris Brezillon
2018-06-04 23:30 ` Boris Brezillon
2018-07-09 19:38 ` [PATCH v3] " Janusz Krzysztofik
2018-07-17 17:05 ` [PATCH RESEND " Janusz Krzysztofik
2018-07-17 20:31 ` Boris Brezillon
2018-07-17 19:37 ` [PATCH " Boris Brezillon
2018-07-17 20:20 ` Janusz Krzysztofik
2018-07-17 20:22 ` Boris Brezillon
2018-05-20 19:27 ` [alsa-devel] [PATCH 5/6] " Ladislav Michl
2018-05-20 19:27 ` Ladislav Michl
2018-05-20 19:27 ` Ladislav Michl
2018-05-20 19:27 ` Ladislav Michl
2018-05-20 20:08 ` Dmitry Torokhov
2018-05-20 20:08 ` Dmitry Torokhov
2018-05-20 20:08 ` Dmitry Torokhov
2018-05-20 20:08 ` Dmitry Torokhov
2018-05-21 20:21 ` Janusz Krzysztofik
2018-05-21 20:21 ` Janusz Krzysztofik
2018-05-21 20:21 ` Janusz Krzysztofik
2018-05-21 20:21 ` Janusz Krzysztofik
2018-05-21 20:57 ` Dmitry Torokhov
2018-05-21 20:57 ` Dmitry Torokhov
2018-05-21 20:57 ` Dmitry Torokhov
2018-05-21 20:57 ` Dmitry Torokhov
2018-05-18 21:09 ` [PATCH 6/6] ARM: OMAP1: ams-delta: make board header file local to mach-omap1 Janusz Krzysztofik
2018-05-18 21:09 ` Janusz Krzysztofik
2018-05-18 21:09 ` Janusz Krzysztofik
2018-05-21 17:35 ` [PATCH 1/6] ARM: OMAP1: ams-delta: add GPIO lookup tables Tony Lindgren
2018-05-21 17:35 ` Tony Lindgren
2018-05-21 17:35 ` Tony Lindgren
2018-05-21 18:10 ` Janusz Krzysztofik
2018-05-21 18:10 ` Janusz Krzysztofik
2018-05-21 18:10 ` Janusz Krzysztofik
2018-07-17 23:14 ` [PATCH v2 0/3] ARM: OMAP1: ams-delta: Complete driver gpiod migration Janusz Krzysztofik
2018-07-17 23:14 ` Janusz Krzysztofik
2018-07-17 23:14 ` Janusz Krzysztofik
2018-07-17 23:14 ` Janusz Krzysztofik
2018-07-17 23:14 ` [PATCH v2 1/3 v2] video: fbdev: omapfb: lcd_ams_delta: use GPIO lookup table Janusz Krzysztofik
2018-07-17 23:14 ` Janusz Krzysztofik
2018-07-17 23:14 ` Janusz Krzysztofik
2018-07-17 23:14 ` Janusz Krzysztofik
2018-07-17 23:14 ` [PATCH v2 2/3 v4] mtd: rawnand: ams-delta: " Janusz Krzysztofik
2018-07-17 23:14 ` Janusz Krzysztofik
2018-07-17 23:14 ` Janusz Krzysztofik
2018-07-17 23:14 ` Janusz Krzysztofik
2018-07-18 7:20 ` Miquel Raynal
2018-07-18 7:20 ` Miquel Raynal
2018-07-18 7:20 ` Miquel Raynal
2018-07-18 7:20 ` Miquel Raynal
2018-07-19 6:39 ` Tony Lindgren
2018-07-19 6:39 ` Tony Lindgren
2018-07-19 6:39 ` Tony Lindgren
2018-07-19 6:39 ` Tony Lindgren
2018-07-17 23:14 ` [PATCH v2 3/3] ARM: OMAP1: ams-delta: make board header file local to mach-omap1 Janusz Krzysztofik
2018-07-17 23:14 ` Janusz Krzysztofik
2018-07-17 23:14 ` Janusz Krzysztofik
2018-07-17 23:14 ` Janusz Krzysztofik
2018-07-18 14:18 ` [PATCH v2 0/3] ARM: OMAP1: ams-delta: Complete driver gpiod migration Gregory CLEMENT
2018-07-18 14:18 ` Gregory CLEMENT
2018-07-18 14:18 ` Gregory CLEMENT
2018-07-18 14:18 ` Gregory CLEMENT
2018-09-09 22:56 ` [PATCH v3 " Janusz Krzysztofik
2018-09-09 22:56 ` Janusz Krzysztofik
2018-09-09 22:56 ` Janusz Krzysztofik
2018-09-09 22:56 ` Janusz Krzysztofik
2018-09-09 22:56 ` [PATCH v3 1/3] video: fbdev: omapfb: lcd_ams_delta: use GPIO lookup table Janusz Krzysztofik
2018-09-09 22:56 ` Janusz Krzysztofik
2018-09-09 22:56 ` Janusz Krzysztofik
2018-09-09 22:56 ` Janusz Krzysztofik
2018-09-10 7:15 ` Linus Walleij
2018-09-10 7:15 ` Linus Walleij
2018-09-10 7:15 ` Linus Walleij
2018-10-03 13:03 ` [PATCH v4] " Janusz Krzysztofik
2018-10-08 10:50 ` Bartlomiej Zolnierkiewicz
2018-09-09 22:56 ` [PATCH v3 2/3] mtd: rawnand: ams-delta: " Janusz Krzysztofik
2018-09-09 22:56 ` Janusz Krzysztofik
2018-09-09 22:56 ` Janusz Krzysztofik
2018-09-09 22:56 ` Janusz Krzysztofik
2018-09-19 22:17 ` [PATCH v5] " Janusz Krzysztofik
2018-09-20 15:33 ` Linus Walleij
2018-09-23 11:35 ` Miquel Raynal
2018-09-09 22:56 ` [PATCH v3 3/3] ARM: OMAP1: ams-delta: make board header file local to mach-omap1 Janusz Krzysztofik
2018-09-09 22:56 ` Janusz Krzysztofik
2018-09-09 22:56 ` Janusz Krzysztofik
2018-09-09 22:56 ` Janusz Krzysztofik
2018-09-19 18:10 ` [PATCH v3 0/3] ARM: OMAP1: ams-delta: Complete driver gpiod migration Janusz Krzysztofik
2018-09-19 18:10 ` Janusz Krzysztofik
2018-09-19 18:10 ` Janusz Krzysztofik
2018-09-20 20:58 ` Tony Lindgren
2018-09-20 20:58 ` Tony Lindgren
2018-09-20 20:58 ` Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAHp75VdNUW6KoM6oupyQ80A1WVRk7vewwDt6WEZOyjrAUifqRg@mail.gmail.com \
--to=andy.shevchenko@gmail.com \
--cc=aaro.koskinen@iki.fi \
--cc=alsa-devel@alsa-project.org \
--cc=boris.brezillon@bootlin.com \
--cc=broonie@kernel.org \
--cc=dmitry.torokhov@gmail.com \
--cc=jarkko.nikula@bitmer.com \
--cc=jmkrzyszt@gmail.com \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=peter.ujfalusi@ti.com \
--cc=richard@nod.at \
--cc=tomi.valkeinen@ti.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.