From: Andy Shevchenko <andy.shevchenko@gmail.com>
To: David Wu <david.wu@rock-chips.com>
Cc: "Heiko Stübner" <heiko@sntech.de>,
"Wolfram Sang" <wsa@the-dreams.de>,
"Doug Anderson" <dianders@chromium.org>,
"Tao Huang" <huangtao@rock-chips.com>,
"Lin Huang" <hl@rock-chips.com>,
"Jianqun Xu" <xjq@rock-chips.com>,
"Chris Zhong" <zyw@rock-chips.com>,
"Eddie Cai" <cf@rock-chips.com>,
"linux-arm Mailing List" <linux-arm-kernel@lists.infradead.org>,
linux-rockchip@lists.infradead.org, linux-i2c@vger.kernel.org,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"David Wu" <wdc@rock-chips.com>
Subject: Re: [PATCH v6] i2c: rk3x: add i2c support for rk3399 soc
Date: Fri, 22 Apr 2016 01:00:08 +0300 [thread overview]
Message-ID: <CAHp75VdWz2sgWmBW30Jb5D4YCgUyM-LQQxzmGZ_3uW=iKUuKKQ@mail.gmail.com> (raw)
In-Reply-To: <1461074137-23899-1-git-send-email-david.wu@rock-chips.com>
On Tue, Apr 19, 2016 at 4:55 PM, David Wu <david.wu@rock-chips.com> wrote:
> From: David Wu <wdc@rock-chips.com>
>
> - new method to caculate i2c timings for rk3399:
> There was an timing issue about "repeated start" time at the I2C
> controller of version0, controller appears to drop SDA at .875x (7/8)
> programmed clk high. On version 1 of the controller, the rule(.875x)
> isn't enough to meet tSU;STA
> requirements on 100k's Standard-mode. To resolve this issue,
> sda_update_config, start_setup_config and stop_setup_config for I2C
> timing information are added, new rules are designed to calculate
> the timing information at new v1.
> - pclk and function clk are separated at rk3399.
> - support i2c highspeed mode: 1.7MHz for rk3399
>
Remove redundant parens in cases like
1. x * (a->b)
2. x = (a + b);
Don't touch pieces of code that are not related (you removed one empty
line without any reason).
--
With Best Regards,
Andy Shevchenko
WARNING: multiple messages have this Message-ID (diff)
From: andy.shevchenko@gmail.com (Andy Shevchenko)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v6] i2c: rk3x: add i2c support for rk3399 soc
Date: Fri, 22 Apr 2016 01:00:08 +0300 [thread overview]
Message-ID: <CAHp75VdWz2sgWmBW30Jb5D4YCgUyM-LQQxzmGZ_3uW=iKUuKKQ@mail.gmail.com> (raw)
In-Reply-To: <1461074137-23899-1-git-send-email-david.wu@rock-chips.com>
On Tue, Apr 19, 2016 at 4:55 PM, David Wu <david.wu@rock-chips.com> wrote:
> From: David Wu <wdc@rock-chips.com>
>
> - new method to caculate i2c timings for rk3399:
> There was an timing issue about "repeated start" time at the I2C
> controller of version0, controller appears to drop SDA at .875x (7/8)
> programmed clk high. On version 1 of the controller, the rule(.875x)
> isn't enough to meet tSU;STA
> requirements on 100k's Standard-mode. To resolve this issue,
> sda_update_config, start_setup_config and stop_setup_config for I2C
> timing information are added, new rules are designed to calculate
> the timing information at new v1.
> - pclk and function clk are separated at rk3399.
> - support i2c highspeed mode: 1.7MHz for rk3399
>
Remove redundant parens in cases like
1. x * (a->b)
2. x = (a + b);
Don't touch pieces of code that are not related (you removed one empty
line without any reason).
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2016-04-21 22:00 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-16 16:57 [PATCH v5 0/2] updates for rk3399 i2c support David Wu
2016-03-16 16:57 ` David Wu
2016-03-16 16:57 ` [PATCH v5 1/2] i2c: rk3x: switch to i2c generic dt parsing David Wu
2016-03-16 16:57 ` David Wu
2016-04-14 18:39 ` Wolfram Sang
2016-04-14 18:39 ` Wolfram Sang
2016-03-16 16:57 ` [PATCH v5 2/2] i2c: rk3x: add i2c support for rk3399 soc David Wu
2016-03-16 16:57 ` David Wu
2016-04-14 18:48 ` Wolfram Sang
2016-04-14 18:48 ` Wolfram Sang
2016-04-15 7:31 ` Heiko Stübner
2016-04-15 7:31 ` Heiko Stübner
2016-04-15 12:12 ` David.Wu
2016-04-15 12:12 ` David.Wu
2016-04-15 12:10 ` David.Wu
2016-04-15 12:10 ` David.Wu
2016-04-15 17:58 ` Wolfram Sang
2016-04-15 17:58 ` Wolfram Sang
2016-04-18 13:15 ` David.Wu
2016-04-18 13:15 ` David.Wu
2016-04-15 12:17 ` Heiko Stübner
2016-04-15 12:17 ` Heiko Stübner
2016-04-19 13:55 ` [PATCH v6] " David Wu
2016-04-19 13:55 ` David Wu
2016-04-21 22:00 ` Andy Shevchenko [this message]
2016-04-21 22:00 ` Andy Shevchenko
2016-04-27 20:56 ` Doug Anderson
2016-04-27 20:56 ` Doug Anderson
2016-04-27 20:56 ` Doug Anderson
[not found] ` <572212AE.5060904@rock-chips.com>
2016-04-28 21:28 ` Doug Anderson
2016-04-28 21:28 ` Doug Anderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAHp75VdWz2sgWmBW30Jb5D4YCgUyM-LQQxzmGZ_3uW=iKUuKKQ@mail.gmail.com' \
--to=andy.shevchenko@gmail.com \
--cc=cf@rock-chips.com \
--cc=david.wu@rock-chips.com \
--cc=dianders@chromium.org \
--cc=heiko@sntech.de \
--cc=hl@rock-chips.com \
--cc=huangtao@rock-chips.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=wdc@rock-chips.com \
--cc=wsa@the-dreams.de \
--cc=xjq@rock-chips.com \
--cc=zyw@rock-chips.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.