All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH gpio] gpio: vf610: fix compilation error
@ 2022-07-05 10:21 Tariq Toukan
  2022-07-05 10:31 ` Andy Shevchenko
                   ` (2 more replies)
  0 siblings, 3 replies; 4+ messages in thread
From: Tariq Toukan @ 2022-07-05 10:21 UTC (permalink / raw)
  To: linux-gpio, Bartosz Golaszewski, Linus Walleij, Peng Fan,
	Andy Shevchenko
  Cc: Tariq Toukan, Ran Rozenstein, gal, Leon Romanovsky, Saeed Mahameed

From: Leon Romanovsky <leonro@nvidia.com>

Fix compilation error by explicitly adding the missing include.

drivers/gpio/gpio-vf610.c: In function ‘vf610_gpio_direction_input’:
drivers/gpio/gpio-vf610.c:120:9: error: implicit declaration of function ‘pinctrl_gpio_direction_input’; did you mean ‘vf610_gpio_direction_input’? [-Werror=implicit-function-declaration]
  120 |  return pinctrl_gpio_direction_input(chip->base + gpio);
      |         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
      |         vf610_gpio_direction_input

Fixes: 30a35c07d9e9 ("gpio: vf610: drop the SOC_VF610 dependency for GPIO_VF610")
Signed-off-by: Leon Romanovsky <leonro@nvidia.com>
Signed-off-by: Tariq Toukan <tariqt@nvidia.com>
---
 drivers/gpio/gpio-vf610.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/gpio/gpio-vf610.c b/drivers/gpio/gpio-vf610.c
index 23cddb265a0d..9db42f6a2043 100644
--- a/drivers/gpio/gpio-vf610.c
+++ b/drivers/gpio/gpio-vf610.c
@@ -19,6 +19,7 @@
 #include <linux/of.h>
 #include <linux/of_device.h>
 #include <linux/of_irq.h>
+#include <linux/pinctrl/consumer.h>
 
 #define VF610_GPIO_PER_PORT		32
 
-- 
2.21.0


^ permalink raw reply related	[flat|nested] 4+ messages in thread
* Re: [PATCH gpio] gpio: vf610: fix compilation error
  2022-07-05 10:21 [PATCH gpio] gpio: vf610: fix compilation error Tariq Toukan
@ 2022-07-05 10:31 ` Andy Shevchenko
  2022-07-05 12:52 ` Peng Fan
  2022-07-05 13:59 ` Bartosz Golaszewski
  2 siblings, 0 replies; 4+ messages in thread
From: Andy Shevchenko @ 2022-07-05 10:31 UTC (permalink / raw)
  To: Tariq Toukan
  Cc: open list:GPIO SUBSYSTEM, Bartosz Golaszewski, Linus Walleij,
	Peng Fan, Ran Rozenstein, gal, Leon Romanovsky, Saeed Mahameed

On Tue, Jul 5, 2022 at 12:21 PM Tariq Toukan <tariqt@nvidia.com> wrote:
>
> From: Leon Romanovsky <leonro@nvidia.com>
>
> Fix compilation error by explicitly adding the missing include.
>
> drivers/gpio/gpio-vf610.c: In function ‘vf610_gpio_direction_input’:
> drivers/gpio/gpio-vf610.c:120:9: error: implicit declaration of function ‘pinctrl_gpio_direction_input’; did you mean ‘vf610_gpio_direction_input’? [-Werror=implicit-function-declaration]
>   120 |  return pinctrl_gpio_direction_input(chip->base + gpio);
>       |         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
>       |         vf610_gpio_direction_input


Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>

> Fixes: 30a35c07d9e9 ("gpio: vf610: drop the SOC_VF610 dependency for GPIO_VF610")
> Signed-off-by: Leon Romanovsky <leonro@nvidia.com>
> Signed-off-by: Tariq Toukan <tariqt@nvidia.com>
> ---
>  drivers/gpio/gpio-vf610.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpio/gpio-vf610.c b/drivers/gpio/gpio-vf610.c
> index 23cddb265a0d..9db42f6a2043 100644
> --- a/drivers/gpio/gpio-vf610.c
> +++ b/drivers/gpio/gpio-vf610.c
> @@ -19,6 +19,7 @@
>  #include <linux/of.h>
>  #include <linux/of_device.h>
>  #include <linux/of_irq.h>
> +#include <linux/pinctrl/consumer.h>
>
>  #define VF610_GPIO_PER_PORT            32
>
> --
> 2.21.0
>


-- 
With Best Regards,
Andy Shevchenko

^ permalink raw reply	[flat|nested] 4+ messages in thread
* RE: [PATCH gpio] gpio: vf610: fix compilation error
  2022-07-05 10:21 [PATCH gpio] gpio: vf610: fix compilation error Tariq Toukan
  2022-07-05 10:31 ` Andy Shevchenko
@ 2022-07-05 12:52 ` Peng Fan
  2022-07-05 13:59 ` Bartosz Golaszewski
  2 siblings, 0 replies; 4+ messages in thread
From: Peng Fan @ 2022-07-05 12:52 UTC (permalink / raw)
  To: Tariq Toukan, linux-gpio, Bartosz Golaszewski, Linus Walleij,
	Andy Shevchenko
  Cc: Ran Rozenstein, gal, Leon Romanovsky, Saeed Mahameed

> Subject: [PATCH gpio] gpio: vf610: fix compilation error
> 
> From: Leon Romanovsky <leonro@nvidia.com>
> 
> Fix compilation error by explicitly adding the missing include.
> 
> drivers/gpio/gpio-vf610.c: In function ‘vf610_gpio_direction_input’:
> drivers/gpio/gpio-vf610.c:120:9: error: implicit declaration of function
> ‘pinctrl_gpio_direction_input’; did you mean ‘vf610_gpio_direction_input’?
> [-Werror=implicit-function-declaration]
>   120 |  return pinctrl_gpio_direction_input(chip->base + gpio);
>       |         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
>       |         vf610_gpio_direction_input
> 
> Fixes: 30a35c07d9e9 ("gpio: vf610: drop the SOC_VF610 dependency for
> GPIO_VF610")
> Signed-off-by: Leon Romanovsky <leonro@nvidia.com>
> Signed-off-by: Tariq Toukan <tariqt@nvidia.com>

Reviewed-by: Peng Fan <peng.fan@nxp.com>
> ---
>  drivers/gpio/gpio-vf610.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/gpio/gpio-vf610.c b/drivers/gpio/gpio-vf610.c index
> 23cddb265a0d..9db42f6a2043 100644
> --- a/drivers/gpio/gpio-vf610.c
> +++ b/drivers/gpio/gpio-vf610.c
> @@ -19,6 +19,7 @@
>  #include <linux/of.h>
>  #include <linux/of_device.h>
>  #include <linux/of_irq.h>
> +#include <linux/pinctrl/consumer.h>
> 
>  #define VF610_GPIO_PER_PORT		32
> 
> --
> 2.21.0


^ permalink raw reply	[flat|nested] 4+ messages in thread
* Re: [PATCH gpio] gpio: vf610: fix compilation error
  2022-07-05 10:21 [PATCH gpio] gpio: vf610: fix compilation error Tariq Toukan
  2022-07-05 10:31 ` Andy Shevchenko
  2022-07-05 12:52 ` Peng Fan
@ 2022-07-05 13:59 ` Bartosz Golaszewski
  2 siblings, 0 replies; 4+ messages in thread
From: Bartosz Golaszewski @ 2022-07-05 13:59 UTC (permalink / raw)
  To: Tariq Toukan
  Cc: open list:GPIO SUBSYSTEM, Linus Walleij, Peng Fan,
	Andy Shevchenko, Ran Rozenstein, gal, Leon Romanovsky,
	Saeed Mahameed

On Tue, Jul 5, 2022 at 12:21 PM Tariq Toukan <tariqt@nvidia.com> wrote:
>
> From: Leon Romanovsky <leonro@nvidia.com>
>
> Fix compilation error by explicitly adding the missing include.
>
> drivers/gpio/gpio-vf610.c: In function ‘vf610_gpio_direction_input’:
> drivers/gpio/gpio-vf610.c:120:9: error: implicit declaration of function ‘pinctrl_gpio_direction_input’; did you mean ‘vf610_gpio_direction_input’? [-Werror=implicit-function-declaration]
>   120 |  return pinctrl_gpio_direction_input(chip->base + gpio);
>       |         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
>       |         vf610_gpio_direction_input
>
> Fixes: 30a35c07d9e9 ("gpio: vf610: drop the SOC_VF610 dependency for GPIO_VF610")
> Signed-off-by: Leon Romanovsky <leonro@nvidia.com>
> Signed-off-by: Tariq Toukan <tariqt@nvidia.com>
> ---
>  drivers/gpio/gpio-vf610.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpio/gpio-vf610.c b/drivers/gpio/gpio-vf610.c
> index 23cddb265a0d..9db42f6a2043 100644
> --- a/drivers/gpio/gpio-vf610.c
> +++ b/drivers/gpio/gpio-vf610.c
> @@ -19,6 +19,7 @@
>  #include <linux/of.h>
>  #include <linux/of_device.h>
>  #include <linux/of_irq.h>
> +#include <linux/pinctrl/consumer.h>
>
>  #define VF610_GPIO_PER_PORT            32
>
> --
> 2.21.0
>

Applied, thanks!

Bart

^ permalink raw reply	[flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-07-05 14:09 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-07-05 10:21 [PATCH gpio] gpio: vf610: fix compilation error Tariq Toukan
2022-07-05 10:31 ` Andy Shevchenko
2022-07-05 12:52 ` Peng Fan
2022-07-05 13:59 ` Bartosz Golaszewski

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.