From: Andy Shevchenko <andy.shevchenko@gmail.com> To: Akinobu Mita <akinobu.mita@gmail.com> Cc: Linux NVMe Mailinglist <linux-nvme@lists.infradead.org>, linux-hwmon@vger.kernel.org, Linux PM <linux-pm@vger.kernel.org>, Linux Kernel Mailing List <linux-kernel@vger.kernel.org>, Sujith Thomas <sujith.thomas@intel.com>, Darren Hart <dvhart@infradead.org>, Andy Shevchenko <andy@infradead.org>, Zhang Rui <rui.zhang@intel.com>, Eduardo Valentin <edubezval@gmail.com>, Daniel Lezcano <daniel.lezcano@linaro.org>, Amit Kucheria <amit.kucheria@verdurent.com>, Jean Delvare <jdelvare@suse.com>, Guenter Roeck <linux@roeck-us.net>, Keith Busch <kbusch@kernel.org>, Jens Axboe <axboe@fb.com>, Christoph Hellwig <hch@lst.de>, Sagi Grimberg <sagi@grimberg.me> Subject: Re: [PATCH 3/8] platform/x86: asus-wmi: switch to use <linux/temperature.h> helpers Date: Sun, 24 Nov 2019 21:54:26 +0200 [thread overview] Message-ID: <CAHp75VdkhFJZ71FS+DhrKTDPEW7Z-6imRSePm8EhgGF2sgTThg@mail.gmail.com> (raw) In-Reply-To: <1574604530-9024-4-git-send-email-akinobu.mita@gmail.com> On Sun, Nov 24, 2019 at 4:09 PM Akinobu Mita <akinobu.mita@gmail.com> wrote: > > The asus-wmi driver doesn't implement the thermal device functionality > directly, so including <linux/thermal.h> just for DECI_KELVIN_TO_CELSIUS() > is a bit odd. > > This switches the asus-wmi driver to use deci_kelvin_to_millicelsius() in > <linux/temperature.h>. > > Cc: Sujith Thomas <sujith.thomas@intel.com> > Cc: Darren Hart <dvhart@infradead.org> > Cc: Andy Shevchenko <andy@infradead.org> > Cc: Zhang Rui <rui.zhang@intel.com> > Cc: Eduardo Valentin <edubezval@gmail.com> > Cc: Daniel Lezcano <daniel.lezcano@linaro.org> > Cc: Amit Kucheria <amit.kucheria@verdurent.com> > Cc: Jean Delvare <jdelvare@suse.com> > Cc: Guenter Roeck <linux@roeck-us.net> > Cc: Keith Busch <kbusch@kernel.org> > Cc: Jens Axboe <axboe@fb.com> > Cc: Christoph Hellwig <hch@lst.de> > Cc: Sagi Grimberg <sagi@grimberg.me> > Signed-off-by: Akinobu Mita <akinobu.mita@gmail.com> > --- > drivers/platform/x86/asus-wmi.c | 7 +++---- > 1 file changed, 3 insertions(+), 4 deletions(-) > > diff --git a/drivers/platform/x86/asus-wmi.c b/drivers/platform/x86/asus-wmi.c > index 821b08e..6a1a2f9 100644 > --- a/drivers/platform/x86/asus-wmi.c > +++ b/drivers/platform/x86/asus-wmi.c > @@ -33,7 +33,7 @@ > #include <linux/seq_file.h> > #include <linux/platform_data/x86/asus-wmi.h> > #include <linux/platform_device.h> > -#include <linux/thermal.h> > +#include <linux/temperature.h> > #include <linux/acpi.h> > #include <linux/dmi.h> > > @@ -1512,9 +1512,8 @@ static ssize_t asus_hwmon_temp1(struct device *dev, > if (err < 0) > return err; > > - value = DECI_KELVIN_TO_CELSIUS((value & 0xFFFF)) * 1000; > - > - return sprintf(buf, "%d\n", value); > + return sprintf(buf, "%ld\n", > + deci_kelvin_to_millicelsius(value & 0xFFFF)); Leave it in one line. With above, Acked-by: Andy Shevchenko <andy.shevchenko@gmail.com> > } > > /* Fan1 */ > -- > 2.7.4 > -- With Best Regards, Andy Shevchenko
WARNING: multiple messages have this Message-ID (diff)
From: Andy Shevchenko <andy.shevchenko@gmail.com> To: Akinobu Mita <akinobu.mita@gmail.com> Cc: linux-hwmon@vger.kernel.org, Jens Axboe <axboe@fb.com>, Amit Kucheria <amit.kucheria@verdurent.com>, Jean Delvare <jdelvare@suse.com>, Sagi Grimberg <sagi@grimberg.me>, Linux PM <linux-pm@vger.kernel.org>, Sujith Thomas <sujith.thomas@intel.com>, Daniel Lezcano <daniel.lezcano@linaro.org>, Linux Kernel Mailing List <linux-kernel@vger.kernel.org>, Linux NVMe Mailinglist <linux-nvme@lists.infradead.org>, Eduardo Valentin <edubezval@gmail.com>, Guenter Roeck <linux@roeck-us.net>, Keith Busch <kbusch@kernel.org>, Darren Hart <dvhart@infradead.org>, Zhang Rui <rui.zhang@intel.com>, Christoph Hellwig <hch@lst.de>, Andy Shevchenko <andy@infradead.org> Subject: Re: [PATCH 3/8] platform/x86: asus-wmi: switch to use <linux/temperature.h> helpers Date: Sun, 24 Nov 2019 21:54:26 +0200 [thread overview] Message-ID: <CAHp75VdkhFJZ71FS+DhrKTDPEW7Z-6imRSePm8EhgGF2sgTThg@mail.gmail.com> (raw) In-Reply-To: <1574604530-9024-4-git-send-email-akinobu.mita@gmail.com> On Sun, Nov 24, 2019 at 4:09 PM Akinobu Mita <akinobu.mita@gmail.com> wrote: > > The asus-wmi driver doesn't implement the thermal device functionality > directly, so including <linux/thermal.h> just for DECI_KELVIN_TO_CELSIUS() > is a bit odd. > > This switches the asus-wmi driver to use deci_kelvin_to_millicelsius() in > <linux/temperature.h>. > > Cc: Sujith Thomas <sujith.thomas@intel.com> > Cc: Darren Hart <dvhart@infradead.org> > Cc: Andy Shevchenko <andy@infradead.org> > Cc: Zhang Rui <rui.zhang@intel.com> > Cc: Eduardo Valentin <edubezval@gmail.com> > Cc: Daniel Lezcano <daniel.lezcano@linaro.org> > Cc: Amit Kucheria <amit.kucheria@verdurent.com> > Cc: Jean Delvare <jdelvare@suse.com> > Cc: Guenter Roeck <linux@roeck-us.net> > Cc: Keith Busch <kbusch@kernel.org> > Cc: Jens Axboe <axboe@fb.com> > Cc: Christoph Hellwig <hch@lst.de> > Cc: Sagi Grimberg <sagi@grimberg.me> > Signed-off-by: Akinobu Mita <akinobu.mita@gmail.com> > --- > drivers/platform/x86/asus-wmi.c | 7 +++---- > 1 file changed, 3 insertions(+), 4 deletions(-) > > diff --git a/drivers/platform/x86/asus-wmi.c b/drivers/platform/x86/asus-wmi.c > index 821b08e..6a1a2f9 100644 > --- a/drivers/platform/x86/asus-wmi.c > +++ b/drivers/platform/x86/asus-wmi.c > @@ -33,7 +33,7 @@ > #include <linux/seq_file.h> > #include <linux/platform_data/x86/asus-wmi.h> > #include <linux/platform_device.h> > -#include <linux/thermal.h> > +#include <linux/temperature.h> > #include <linux/acpi.h> > #include <linux/dmi.h> > > @@ -1512,9 +1512,8 @@ static ssize_t asus_hwmon_temp1(struct device *dev, > if (err < 0) > return err; > > - value = DECI_KELVIN_TO_CELSIUS((value & 0xFFFF)) * 1000; > - > - return sprintf(buf, "%d\n", value); > + return sprintf(buf, "%ld\n", > + deci_kelvin_to_millicelsius(value & 0xFFFF)); Leave it in one line. With above, Acked-by: Andy Shevchenko <andy.shevchenko@gmail.com> > } > > /* Fan1 */ > -- > 2.7.4 > -- With Best Regards, Andy Shevchenko _______________________________________________ Linux-nvme mailing list Linux-nvme@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-nvme
next prev parent reply other threads:[~2019-11-24 19:54 UTC|newest] Thread overview: 52+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-11-24 14:08 [PATCH 0/8] add header file for kelvin to/from Celsius conversion helpers Akinobu Mita 2019-11-24 14:08 ` Akinobu Mita 2019-11-24 14:08 ` [PATCH 1/8] " Akinobu Mita 2019-11-24 14:08 ` Akinobu Mita 2019-11-24 14:57 ` Andy Shevchenko 2019-11-24 14:57 ` Andy Shevchenko 2019-11-25 14:29 ` Akinobu Mita 2019-11-25 14:29 ` Akinobu Mita 2019-11-25 19:05 ` Andy Shevchenko 2019-11-25 19:05 ` Andy Shevchenko 2019-11-24 14:08 ` [PATCH 2/8] ACPI: thermal: switch to use <linux/temperature.h> helpers Akinobu Mita 2019-11-24 14:08 ` Akinobu Mita 2019-11-24 15:17 ` Guenter Roeck 2019-11-24 15:17 ` Guenter Roeck 2019-11-25 14:31 ` Akinobu Mita 2019-11-25 14:31 ` Akinobu Mita 2019-11-24 14:08 ` [PATCH 3/8] platform/x86: asus-wmi: " Akinobu Mita 2019-11-24 14:08 ` Akinobu Mita 2019-11-24 19:54 ` Andy Shevchenko [this message] 2019-11-24 19:54 ` Andy Shevchenko 2019-11-25 14:31 ` Akinobu Mita 2019-11-25 14:31 ` Akinobu Mita 2019-11-25 19:06 ` Andy Shevchenko 2019-11-25 19:06 ` Andy Shevchenko 2019-11-24 14:08 ` [PATCH 4/8] platform/x86: intel_menlow: " Akinobu Mita 2019-11-24 14:08 ` Akinobu Mita 2019-11-24 19:57 ` Andy Shevchenko 2019-11-24 19:57 ` Andy Shevchenko 2019-11-25 14:34 ` Akinobu Mita 2019-11-25 14:34 ` Akinobu Mita 2019-11-25 19:07 ` Andy Shevchenko 2019-11-25 19:07 ` Andy Shevchenko 2019-11-26 14:34 ` Akinobu Mita 2019-11-26 14:34 ` Akinobu Mita 2019-11-24 14:08 ` [PATCH 5/8] thermal: int340x: " Akinobu Mita 2019-11-24 14:08 ` Akinobu Mita 2019-11-24 14:08 ` [PATCH 6/8] thermal: intel_pch: " Akinobu Mita 2019-11-24 14:08 ` Akinobu Mita 2019-11-24 15:15 ` Guenter Roeck 2019-11-24 15:15 ` Guenter Roeck 2019-11-24 14:08 ` [PATCH 7/8] nvme: hwmon: " Akinobu Mita 2019-11-24 14:08 ` Akinobu Mita 2019-11-25 6:59 ` Christoph Hellwig 2019-11-25 6:59 ` Christoph Hellwig 2019-11-24 14:08 ` [PATCH 8/8] thermal: remove kelvin to/from Celsius conversion helpers from <linux/thermal.h> Akinobu Mita 2019-11-24 14:08 ` Akinobu Mita 2019-11-24 20:00 ` Andy Shevchenko 2019-11-24 20:00 ` Andy Shevchenko 2019-11-25 14:39 ` Akinobu Mita 2019-11-25 14:39 ` Akinobu Mita 2019-11-25 19:08 ` Andy Shevchenko 2019-11-25 19:08 ` Andy Shevchenko
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=CAHp75VdkhFJZ71FS+DhrKTDPEW7Z-6imRSePm8EhgGF2sgTThg@mail.gmail.com \ --to=andy.shevchenko@gmail.com \ --cc=akinobu.mita@gmail.com \ --cc=amit.kucheria@verdurent.com \ --cc=andy@infradead.org \ --cc=axboe@fb.com \ --cc=daniel.lezcano@linaro.org \ --cc=dvhart@infradead.org \ --cc=edubezval@gmail.com \ --cc=hch@lst.de \ --cc=jdelvare@suse.com \ --cc=kbusch@kernel.org \ --cc=linux-hwmon@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-nvme@lists.infradead.org \ --cc=linux-pm@vger.kernel.org \ --cc=linux@roeck-us.net \ --cc=rui.zhang@intel.com \ --cc=sagi@grimberg.me \ --cc=sujith.thomas@intel.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.