* [pavel-linux-leds:for-next 24/30] drivers/leds/leds-lm36274.c:77:6: error: implicit declaration of function 'device_get_child_node_count'
@ 2021-05-29 14:30 ` kernel test robot
0 siblings, 0 replies; 3+ messages in thread
From: kernel test robot @ 2021-05-29 14:30 UTC (permalink / raw)
To: Andy Shevchenko; +Cc: kbuild-all, linux-leds, Pavel Machek
[-- Attachment #1: Type: text/plain, Size: 5748 bytes --]
tree: git://git.kernel.org/pub/scm/linux/kernel/git/pavel/linux-leds.git for-next
head: e1012160bbbca92d67c729f68108734b7d679db9
commit: e2e8e4e8187509a77cb6328d876d9c09c07c2e82 [24/30] leds: lm36274: Correct headers (of*.h -> mod_devicetable.h)
config: m68k-randconfig-r032-20210529 (attached as .config)
compiler: m68k-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://git.kernel.org/pub/scm/linux/kernel/git/pavel/linux-leds.git/commit/?id=e2e8e4e8187509a77cb6328d876d9c09c07c2e82
git remote add pavel-linux-leds git://git.kernel.org/pub/scm/linux/kernel/git/pavel/linux-leds.git
git fetch --no-tags pavel-linux-leds for-next
git checkout e2e8e4e8187509a77cb6328d876d9c09c07c2e82
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=m68k
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
All error/warnings (new ones prefixed by >>):
drivers/leds/leds-lm36274.c: In function 'lm36274_parse_dt':
>> drivers/leds/leds-lm36274.c:77:6: error: implicit declaration of function 'device_get_child_node_count' [-Werror=implicit-function-declaration]
77 | if (device_get_child_node_count(dev) != 1)
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~
>> drivers/leds/leds-lm36274.c:80:10: error: implicit declaration of function 'device_get_next_child_node' [-Werror=implicit-function-declaration]
80 | child = device_get_next_child_node(dev, NULL);
| ^~~~~~~~~~~~~~~~~~~~~~~~~~
>> drivers/leds/leds-lm36274.c:80:8: warning: assignment to 'struct fwnode_handle *' from 'int' makes pointer from integer without a cast [-Wint-conversion]
80 | child = device_get_next_child_node(dev, NULL);
| ^
>> drivers/leds/leds-lm36274.c:87:19: error: implicit declaration of function 'fwnode_property_count_u32' [-Werror=implicit-function-declaration]
87 | chip->num_leds = fwnode_property_count_u32(child, "led-sources");
| ^~~~~~~~~~~~~~~~~~~~~~~~~
>> drivers/leds/leds-lm36274.c:93:8: error: implicit declaration of function 'fwnode_property_read_u32_array' [-Werror=implicit-function-declaration]
93 | ret = fwnode_property_read_u32_array(child, "led-sources",
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>> drivers/leds/leds-lm36274.c:102:2: error: implicit declaration of function 'fwnode_handle_put' [-Werror=implicit-function-declaration]
102 | fwnode_handle_put(child);
| ^~~~~~~~~~~~~~~~~
cc1: some warnings being treated as errors
vim +/device_get_child_node_count +77 drivers/leds/leds-lm36274.c
11e1bbc116a75d Dan Murphy 2019-06-05 68
1aeef38c6a4a87 Marek Behún 2020-09-19 69 static int lm36274_parse_dt(struct lm36274 *chip,
1aeef38c6a4a87 Marek Behún 2020-09-19 70 struct led_init_data *init_data)
11e1bbc116a75d Dan Murphy 2019-06-05 71 {
5c0d20a968ae87 Marek Behún 2020-09-19 72 struct device *dev = chip->dev;
1aeef38c6a4a87 Marek Behún 2020-09-19 73 struct fwnode_handle *child;
a448fcf19c9c5d Marek Behún 2020-09-19 74 int ret;
11e1bbc116a75d Dan Murphy 2019-06-05 75
11e1bbc116a75d Dan Murphy 2019-06-05 76 /* There should only be 1 node */
a448fcf19c9c5d Marek Behún 2020-09-19 @77 if (device_get_child_node_count(dev) != 1)
11e1bbc116a75d Dan Murphy 2019-06-05 78 return -EINVAL;
11e1bbc116a75d Dan Murphy 2019-06-05 79
a448fcf19c9c5d Marek Behún 2020-09-19 @80 child = device_get_next_child_node(dev, NULL);
a448fcf19c9c5d Marek Behún 2020-09-19 81
1aeef38c6a4a87 Marek Behún 2020-09-19 82 init_data->fwnode = child;
1aeef38c6a4a87 Marek Behún 2020-09-19 83 init_data->devicename = chip->pdev->name;
1aeef38c6a4a87 Marek Behún 2020-09-19 84 /* for backwards compatibility when `label` property is not present */
1aeef38c6a4a87 Marek Behún 2020-09-19 85 init_data->default_label = ":";
11e1bbc116a75d Dan Murphy 2019-06-05 86
d3ab963cf98015 Marek Behún 2020-09-19 @87 chip->num_leds = fwnode_property_count_u32(child, "led-sources");
1aeef38c6a4a87 Marek Behún 2020-09-19 88 if (chip->num_leds <= 0) {
1aeef38c6a4a87 Marek Behún 2020-09-19 89 ret = -ENODEV;
1aeef38c6a4a87 Marek Behún 2020-09-19 90 goto err;
1aeef38c6a4a87 Marek Behún 2020-09-19 91 }
11e1bbc116a75d Dan Murphy 2019-06-05 92
11e1bbc116a75d Dan Murphy 2019-06-05 @93 ret = fwnode_property_read_u32_array(child, "led-sources",
a448fcf19c9c5d Marek Behún 2020-09-19 94 chip->led_sources, chip->num_leds);
11e1bbc116a75d Dan Murphy 2019-06-05 95 if (ret) {
11e1bbc116a75d Dan Murphy 2019-06-05 96 dev_err(dev, "led-sources property missing\n");
1aeef38c6a4a87 Marek Behún 2020-09-19 97 goto err;
11e1bbc116a75d Dan Murphy 2019-06-05 98 }
11e1bbc116a75d Dan Murphy 2019-06-05 99
11e1bbc116a75d Dan Murphy 2019-06-05 100 return 0;
1aeef38c6a4a87 Marek Behún 2020-09-19 101 err:
1aeef38c6a4a87 Marek Behún 2020-09-19 @102 fwnode_handle_put(child);
1aeef38c6a4a87 Marek Behún 2020-09-19 103 return ret;
11e1bbc116a75d Dan Murphy 2019-06-05 104 }
11e1bbc116a75d Dan Murphy 2019-06-05 105
:::::: The code at line 77 was first introduced by commit
:::::: a448fcf19c9c5d3ddd9066accbd8d28c4950bb9f leds: lm36274: don't iterate through children since there is only one
:::::: TO: Marek Behún <marek.behun@nic.cz>
:::::: CC: Pavel Machek <pavel@ucw.cz>
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 17865 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
* [pavel-linux-leds:for-next 24/30] drivers/leds/leds-lm36274.c:77:6: error: implicit declaration of function 'device_get_child_node_count'
@ 2021-05-29 14:30 ` kernel test robot
0 siblings, 0 replies; 3+ messages in thread
From: kernel test robot @ 2021-05-29 14:30 UTC (permalink / raw)
To: kbuild-all
[-- Attachment #1: Type: text/plain, Size: 5865 bytes --]
tree: git://git.kernel.org/pub/scm/linux/kernel/git/pavel/linux-leds.git for-next
head: e1012160bbbca92d67c729f68108734b7d679db9
commit: e2e8e4e8187509a77cb6328d876d9c09c07c2e82 [24/30] leds: lm36274: Correct headers (of*.h -> mod_devicetable.h)
config: m68k-randconfig-r032-20210529 (attached as .config)
compiler: m68k-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://git.kernel.org/pub/scm/linux/kernel/git/pavel/linux-leds.git/commit/?id=e2e8e4e8187509a77cb6328d876d9c09c07c2e82
git remote add pavel-linux-leds git://git.kernel.org/pub/scm/linux/kernel/git/pavel/linux-leds.git
git fetch --no-tags pavel-linux-leds for-next
git checkout e2e8e4e8187509a77cb6328d876d9c09c07c2e82
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=m68k
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
All error/warnings (new ones prefixed by >>):
drivers/leds/leds-lm36274.c: In function 'lm36274_parse_dt':
>> drivers/leds/leds-lm36274.c:77:6: error: implicit declaration of function 'device_get_child_node_count' [-Werror=implicit-function-declaration]
77 | if (device_get_child_node_count(dev) != 1)
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~
>> drivers/leds/leds-lm36274.c:80:10: error: implicit declaration of function 'device_get_next_child_node' [-Werror=implicit-function-declaration]
80 | child = device_get_next_child_node(dev, NULL);
| ^~~~~~~~~~~~~~~~~~~~~~~~~~
>> drivers/leds/leds-lm36274.c:80:8: warning: assignment to 'struct fwnode_handle *' from 'int' makes pointer from integer without a cast [-Wint-conversion]
80 | child = device_get_next_child_node(dev, NULL);
| ^
>> drivers/leds/leds-lm36274.c:87:19: error: implicit declaration of function 'fwnode_property_count_u32' [-Werror=implicit-function-declaration]
87 | chip->num_leds = fwnode_property_count_u32(child, "led-sources");
| ^~~~~~~~~~~~~~~~~~~~~~~~~
>> drivers/leds/leds-lm36274.c:93:8: error: implicit declaration of function 'fwnode_property_read_u32_array' [-Werror=implicit-function-declaration]
93 | ret = fwnode_property_read_u32_array(child, "led-sources",
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>> drivers/leds/leds-lm36274.c:102:2: error: implicit declaration of function 'fwnode_handle_put' [-Werror=implicit-function-declaration]
102 | fwnode_handle_put(child);
| ^~~~~~~~~~~~~~~~~
cc1: some warnings being treated as errors
vim +/device_get_child_node_count +77 drivers/leds/leds-lm36274.c
11e1bbc116a75d Dan Murphy 2019-06-05 68
1aeef38c6a4a87 Marek Behún 2020-09-19 69 static int lm36274_parse_dt(struct lm36274 *chip,
1aeef38c6a4a87 Marek Behún 2020-09-19 70 struct led_init_data *init_data)
11e1bbc116a75d Dan Murphy 2019-06-05 71 {
5c0d20a968ae87 Marek Behún 2020-09-19 72 struct device *dev = chip->dev;
1aeef38c6a4a87 Marek Behún 2020-09-19 73 struct fwnode_handle *child;
a448fcf19c9c5d Marek Behún 2020-09-19 74 int ret;
11e1bbc116a75d Dan Murphy 2019-06-05 75
11e1bbc116a75d Dan Murphy 2019-06-05 76 /* There should only be 1 node */
a448fcf19c9c5d Marek Behún 2020-09-19 @77 if (device_get_child_node_count(dev) != 1)
11e1bbc116a75d Dan Murphy 2019-06-05 78 return -EINVAL;
11e1bbc116a75d Dan Murphy 2019-06-05 79
a448fcf19c9c5d Marek Behún 2020-09-19 @80 child = device_get_next_child_node(dev, NULL);
a448fcf19c9c5d Marek Behún 2020-09-19 81
1aeef38c6a4a87 Marek Behún 2020-09-19 82 init_data->fwnode = child;
1aeef38c6a4a87 Marek Behún 2020-09-19 83 init_data->devicename = chip->pdev->name;
1aeef38c6a4a87 Marek Behún 2020-09-19 84 /* for backwards compatibility when `label` property is not present */
1aeef38c6a4a87 Marek Behún 2020-09-19 85 init_data->default_label = ":";
11e1bbc116a75d Dan Murphy 2019-06-05 86
d3ab963cf98015 Marek Behún 2020-09-19 @87 chip->num_leds = fwnode_property_count_u32(child, "led-sources");
1aeef38c6a4a87 Marek Behún 2020-09-19 88 if (chip->num_leds <= 0) {
1aeef38c6a4a87 Marek Behún 2020-09-19 89 ret = -ENODEV;
1aeef38c6a4a87 Marek Behún 2020-09-19 90 goto err;
1aeef38c6a4a87 Marek Behún 2020-09-19 91 }
11e1bbc116a75d Dan Murphy 2019-06-05 92
11e1bbc116a75d Dan Murphy 2019-06-05 @93 ret = fwnode_property_read_u32_array(child, "led-sources",
a448fcf19c9c5d Marek Behún 2020-09-19 94 chip->led_sources, chip->num_leds);
11e1bbc116a75d Dan Murphy 2019-06-05 95 if (ret) {
11e1bbc116a75d Dan Murphy 2019-06-05 96 dev_err(dev, "led-sources property missing\n");
1aeef38c6a4a87 Marek Behún 2020-09-19 97 goto err;
11e1bbc116a75d Dan Murphy 2019-06-05 98 }
11e1bbc116a75d Dan Murphy 2019-06-05 99
11e1bbc116a75d Dan Murphy 2019-06-05 100 return 0;
1aeef38c6a4a87 Marek Behún 2020-09-19 101 err:
1aeef38c6a4a87 Marek Behún 2020-09-19 @102 fwnode_handle_put(child);
1aeef38c6a4a87 Marek Behún 2020-09-19 103 return ret;
11e1bbc116a75d Dan Murphy 2019-06-05 104 }
11e1bbc116a75d Dan Murphy 2019-06-05 105
:::::: The code at line 77 was first introduced by commit
:::::: a448fcf19c9c5d3ddd9066accbd8d28c4950bb9f leds: lm36274: don't iterate through children since there is only one
:::::: TO: Marek Behún <marek.behun@nic.cz>
:::::: CC: Pavel Machek <pavel@ucw.cz>
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org
[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 17865 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [pavel-linux-leds:for-next 24/30] drivers/leds/leds-lm36274.c:77:6: error: implicit declaration of function 'device_get_child_node_count'
2021-05-29 14:30 ` kernel test robot
(?)
@ 2021-05-30 0:03 ` Andy Shevchenko
-1 siblings, 0 replies; 3+ messages in thread
From: Andy Shevchenko @ 2021-05-30 0:03 UTC (permalink / raw)
To: kbuild-all
[-- Attachment #1: Type: text/plain, Size: 6573 bytes --]
On Saturday, May 29, 2021, kernel test robot <lkp@intel.com> wrote:
> tree: git://git.kernel.org/pub/scm/linux/kernel/git/pavel/linux-leds.git
> for-next
> head: e1012160bbbca92d67c729f68108734b7d679db9
> commit: e2e8e4e8187509a77cb6328d876d9c09c07c2e82 [24/30] leds: lm36274:
> Correct headers (of*.h -> mod_devicetable.h)
> config: m68k-randconfig-r032-20210529 (attached as .config)
> compiler: m68k-linux-gcc (GCC) 9.3.0
> reproduce (this is a W=1 build):
> wget https://raw.githubusercontent.com/intel/lkp-tests/master/
> sbin/make.cross -O ~/bin/make.cross
> chmod +x ~/bin/make.cross
> # https://git.kernel.org/pub/scm/linux/kernel/git/pavel/
> linux-leds.git/commit/?id=e2e8e4e8187509a77cb6328d876d9c09c07c2e82
> git remote add pavel-linux-leds git://git.kernel.org/pub/scm/
> linux/kernel/git/pavel/linux-leds.git
> git fetch --no-tags pavel-linux-leds for-next
> git checkout e2e8e4e8187509a77cb6328d876d9c09c07c2e82
> # save the attached .config to linux build tree
> COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross
> ARCH=m68k
>
> If you fix the issue, kindly add following tag as appropriate
> Reported-by: kernel test robot <lkp@intel.com>
>
> All error/warnings (new ones prefixed by >>):
I understand that it seems due to missed property.h. What I don’t
understand right now is why I missed it during my test compilation... Okay,
I will check it later on and send a fix.
>
> drivers/leds/leds-lm36274.c: In function 'lm36274_parse_dt':
> >> drivers/leds/leds-lm36274.c:77:6: error: implicit declaration of
> function 'device_get_child_node_count' [-Werror=implicit-function-
> declaration]
> 77 | if (device_get_child_node_count(dev) != 1)
> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~
> >> drivers/leds/leds-lm36274.c:80:10: error: implicit declaration of
> function 'device_get_next_child_node' [-Werror=implicit-function-
> declaration]
> 80 | child = device_get_next_child_node(dev, NULL);
> | ^~~~~~~~~~~~~~~~~~~~~~~~~~
> >> drivers/leds/leds-lm36274.c:80:8: warning: assignment to 'struct
> fwnode_handle *' from 'int' makes pointer from integer without a cast
> [-Wint-conversion]
> 80 | child = device_get_next_child_node(dev, NULL);
> | ^
> >> drivers/leds/leds-lm36274.c:87:19: error: implicit declaration of
> function 'fwnode_property_count_u32' [-Werror=implicit-function-
> declaration]
> 87 | chip->num_leds = fwnode_property_count_u32(child,
> "led-sources");
> | ^~~~~~~~~~~~~~~~~~~~~~~~~
> >> drivers/leds/leds-lm36274.c:93:8: error: implicit declaration of
> function 'fwnode_property_read_u32_array' [-Werror=implicit-function-
> declaration]
> 93 | ret = fwnode_property_read_u32_array(child, "led-sources",
> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> >> drivers/leds/leds-lm36274.c:102:2: error: implicit declaration of
> function 'fwnode_handle_put' [-Werror=implicit-function-declaration]
> 102 | fwnode_handle_put(child);
> | ^~~~~~~~~~~~~~~~~
> cc1: some warnings being treated as errors
>
>
> vim +/device_get_child_node_count +77 drivers/leds/leds-lm36274.c
>
> 11e1bbc116a75d Dan Murphy 2019-06-05 68
> 1aeef38c6a4a87 Marek Behún 2020-09-19 69 static int
> lm36274_parse_dt(struct lm36274 *chip,
> 1aeef38c6a4a87 Marek Behún 2020-09-19 70 struct
> led_init_data *init_data)
> 11e1bbc116a75d Dan Murphy 2019-06-05 71 {
> 5c0d20a968ae87 Marek Behún 2020-09-19 72 struct device *dev =
> chip->dev;
> 1aeef38c6a4a87 Marek Behún 2020-09-19 73 struct fwnode_handle
> *child;
> a448fcf19c9c5d Marek Behún 2020-09-19 74 int ret;
> 11e1bbc116a75d Dan Murphy 2019-06-05 75
> 11e1bbc116a75d Dan Murphy 2019-06-05 76 /* There should only be 1
> node */
> a448fcf19c9c5d Marek Behún 2020-09-19 @77 if
> (device_get_child_node_count(dev) != 1)
> 11e1bbc116a75d Dan Murphy 2019-06-05 78 return -EINVAL;
> 11e1bbc116a75d Dan Murphy 2019-06-05 79
> a448fcf19c9c5d Marek Behún 2020-09-19 @80 child =
> device_get_next_child_node(dev, NULL);
> a448fcf19c9c5d Marek Behún 2020-09-19 81
> 1aeef38c6a4a87 Marek Behún 2020-09-19 82 init_data->fwnode = child;
> 1aeef38c6a4a87 Marek Behún 2020-09-19 83 init_data->devicename =
> chip->pdev->name;
> 1aeef38c6a4a87 Marek Behún 2020-09-19 84 /* for backwards
> compatibility when `label` property is not present */
> 1aeef38c6a4a87 Marek Behún 2020-09-19 85 init_data->default_label =
> ":";
> 11e1bbc116a75d Dan Murphy 2019-06-05 86
> d3ab963cf98015 Marek Behún 2020-09-19 @87 chip->num_leds =
> fwnode_property_count_u32(child, "led-sources");
> 1aeef38c6a4a87 Marek Behún 2020-09-19 88 if (chip->num_leds <= 0) {
> 1aeef38c6a4a87 Marek Behún 2020-09-19 89 ret = -ENODEV;
> 1aeef38c6a4a87 Marek Behún 2020-09-19 90 goto err;
> 1aeef38c6a4a87 Marek Behún 2020-09-19 91 }
> 11e1bbc116a75d Dan Murphy 2019-06-05 92
> 11e1bbc116a75d Dan Murphy 2019-06-05 @93 ret =
> fwnode_property_read_u32_array(child, "led-sources",
> a448fcf19c9c5d Marek Behún 2020-09-19 94
> chip->led_sources, chip->num_leds);
> 11e1bbc116a75d Dan Murphy 2019-06-05 95 if (ret) {
> 11e1bbc116a75d Dan Murphy 2019-06-05 96 dev_err(dev,
> "led-sources property missing\n");
> 1aeef38c6a4a87 Marek Behún 2020-09-19 97 goto err;
> 11e1bbc116a75d Dan Murphy 2019-06-05 98 }
> 11e1bbc116a75d Dan Murphy 2019-06-05 99
> 11e1bbc116a75d Dan Murphy 2019-06-05 100 return 0;
> 1aeef38c6a4a87 Marek Behún 2020-09-19 101 err:
> 1aeef38c6a4a87 Marek Behún 2020-09-19 @102 fwnode_handle_put(child);
> 1aeef38c6a4a87 Marek Behún 2020-09-19 103 return ret;
> 11e1bbc116a75d Dan Murphy 2019-06-05 104 }
> 11e1bbc116a75d Dan Murphy 2019-06-05 105
>
> :::::: The code at line 77 was first introduced by commit
> :::::: a448fcf19c9c5d3ddd9066accbd8d28c4950bb9f leds: lm36274: don't
> iterate through children since there is only one
>
> :::::: TO: Marek Behún <marek.behun@nic.cz>
> :::::: CC: Pavel Machek <pavel@ucw.cz>
>
> ---
> 0-DAY CI Kernel Test Service, Intel Corporation
> https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org
>
--
With Best Regards,
Andy Shevchenko
[-- Attachment #2: attachment.htm --]
[-- Type: text/html, Size: 8366 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-05-30 0:03 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-05-29 14:30 [pavel-linux-leds:for-next 24/30] drivers/leds/leds-lm36274.c:77:6: error: implicit declaration of function 'device_get_child_node_count' kernel test robot
2021-05-29 14:30 ` kernel test robot
2021-05-30 0:03 ` Andy Shevchenko
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.