* [U-Boot] [PATCH v2] arch/x86: Select USB before selecting host driver
@ 2017-07-22 4:18 Bin Meng
2017-07-22 5:15 ` Bin Meng
0 siblings, 1 reply; 5+ messages in thread
From: Bin Meng @ 2017-07-22 4:18 UTC (permalink / raw)
To: u-boot
From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Kbuild complains if USB is not selected before any of host driver.
warning: (X86) selects USB_EHCI_HCD which has unmet direct dependencies (USB)
warning: (X86) selects USB_EHCI_HCD which has unmet direct dependencies (USB)
Select it for X86.
Fixes: 64d6ac5bc4a9 ("Kconfig: USB: Migrate CONFIG_USB_EHCI_HCD users to Kconfig")
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
[bmeng: Update all x86 boards' defconfig files to remove CONFIG_USB]
Signed-off-by: Bin Meng <bmeng.cn@gmail.com>
---
Changes in v2:
- Update all x86 boards' defconfig files to remove CONFIG_USB
arch/Kconfig | 1 +
configs/bayleybay_defconfig | 1 -
configs/chromebook_link64_defconfig | 1 -
configs/chromebook_link_defconfig | 1 -
configs/chromebook_samus_defconfig | 1 -
configs/chromebox_panther_defconfig | 1 -
configs/conga-qeval20-qa3-e3845-internal-uart_defconfig | 1 -
configs/conga-qeval20-qa3-e3845_defconfig | 1 -
configs/coreboot-x86_defconfig | 1 -
configs/cougarcanyon2_defconfig | 1 -
configs/crownbay_defconfig | 1 -
configs/dfi-bt700-q7x-151_defconfig | 1 -
configs/efi-x86_defconfig | 1 -
configs/galileo_defconfig | 1 -
configs/minnowmax_defconfig | 1 -
configs/qemu-x86_64_defconfig | 1 -
configs/qemu-x86_defconfig | 1 -
configs/qemu-x86_efi_payload32_defconfig | 1 -
configs/qemu-x86_efi_payload64_defconfig | 1 -
configs/som-db5800-som-6867_defconfig | 1 -
configs/theadorable-x86-dfi-bt700_defconfig | 1 -
21 files changed, 1 insertion(+), 20 deletions(-)
diff --git a/arch/Kconfig b/arch/Kconfig
index 7e76abd..fadd3d6 100644
--- a/arch/Kconfig
+++ b/arch/Kconfig
@@ -93,6 +93,7 @@ config X86
select DM_GPIO
select DM_SPI
select DM_SPI_FLASH
+ select USB
select USB_EHCI_HCD
imply CMD_FPGA_LOADMK
imply CMD_GETTIME
diff --git a/configs/bayleybay_defconfig b/configs/bayleybay_defconfig
index 14b74c4..936808d 100644
--- a/configs/bayleybay_defconfig
+++ b/configs/bayleybay_defconfig
@@ -63,7 +63,6 @@ CONFIG_DM_RTC=y
CONFIG_SYS_NS16550=y
CONFIG_ICH_SPI=y
CONFIG_TIMER=y
-CONFIG_USB=y
CONFIG_DM_USB=y
CONFIG_USB_STORAGE=y
CONFIG_USB_KEYBOARD=y
diff --git a/configs/chromebook_link64_defconfig b/configs/chromebook_link64_defconfig
index 557919c..cb70535 100644
--- a/configs/chromebook_link64_defconfig
+++ b/configs/chromebook_link64_defconfig
@@ -78,7 +78,6 @@ CONFIG_SYS_NS16550=y
CONFIG_ICH_SPI=y
CONFIG_TIMER=y
CONFIG_TPM_TIS_LPC=y
-CONFIG_USB=y
CONFIG_DM_USB=y
CONFIG_USB_STORAGE=y
CONFIG_USB_KEYBOARD=y
diff --git a/configs/chromebook_link_defconfig b/configs/chromebook_link_defconfig
index 3105fed..f2459ef 100644
--- a/configs/chromebook_link_defconfig
+++ b/configs/chromebook_link_defconfig
@@ -61,7 +61,6 @@ CONFIG_SYS_NS16550=y
CONFIG_ICH_SPI=y
CONFIG_TIMER=y
CONFIG_TPM_TIS_LPC=y
-CONFIG_USB=y
CONFIG_DM_USB=y
CONFIG_USB_STORAGE=y
CONFIG_USB_KEYBOARD=y
diff --git a/configs/chromebook_samus_defconfig b/configs/chromebook_samus_defconfig
index ab2d27e..8af14dc 100644
--- a/configs/chromebook_samus_defconfig
+++ b/configs/chromebook_samus_defconfig
@@ -58,7 +58,6 @@ CONFIG_SYS_NS16550=y
CONFIG_ICH_SPI=y
CONFIG_TIMER=y
CONFIG_TPM_TIS_LPC=y
-CONFIG_USB=y
CONFIG_DM_USB=y
CONFIG_USB_STORAGE=y
CONFIG_USB_KEYBOARD=y
diff --git a/configs/chromebox_panther_defconfig b/configs/chromebox_panther_defconfig
index 30d4019..10fbc22 100644
--- a/configs/chromebox_panther_defconfig
+++ b/configs/chromebox_panther_defconfig
@@ -53,7 +53,6 @@ CONFIG_SYS_NS16550=y
CONFIG_ICH_SPI=y
CONFIG_TIMER=y
CONFIG_TPM_TIS_LPC=y
-CONFIG_USB=y
CONFIG_DM_USB=y
CONFIG_USB_STORAGE=y
CONFIG_USB_KEYBOARD=y
diff --git a/configs/conga-qeval20-qa3-e3845-internal-uart_defconfig b/configs/conga-qeval20-qa3-e3845-internal-uart_defconfig
index a0cce75..4802525 100644
--- a/configs/conga-qeval20-qa3-e3845-internal-uart_defconfig
+++ b/configs/conga-qeval20-qa3-e3845-internal-uart_defconfig
@@ -68,7 +68,6 @@ CONFIG_DEBUG_UART_CLOCK=1843200
CONFIG_SYS_NS16550=y
CONFIG_ICH_SPI=y
CONFIG_TIMER=y
-CONFIG_USB=y
CONFIG_DM_USB=y
CONFIG_USB_STORAGE=y
CONFIG_USB_KEYBOARD=y
diff --git a/configs/conga-qeval20-qa3-e3845_defconfig b/configs/conga-qeval20-qa3-e3845_defconfig
index 26eed7c..753ee3f 100644
--- a/configs/conga-qeval20-qa3-e3845_defconfig
+++ b/configs/conga-qeval20-qa3-e3845_defconfig
@@ -67,7 +67,6 @@ CONFIG_DEBUG_UART_CLOCK=1843200
CONFIG_SYS_NS16550=y
CONFIG_ICH_SPI=y
CONFIG_TIMER=y
-CONFIG_USB=y
CONFIG_DM_USB=y
CONFIG_USB_STORAGE=y
CONFIG_USB_KEYBOARD=y
diff --git a/configs/coreboot-x86_defconfig b/configs/coreboot-x86_defconfig
index 8b51073..d8a55e8 100644
--- a/configs/coreboot-x86_defconfig
+++ b/configs/coreboot-x86_defconfig
@@ -44,7 +44,6 @@ CONFIG_DM_RTC=y
CONFIG_SYS_NS16550=y
CONFIG_TIMER=y
CONFIG_TPM_TIS_LPC=y
-CONFIG_USB=y
CONFIG_DM_USB=y
CONFIG_USB_STORAGE=y
CONFIG_USB_KEYBOARD=y
diff --git a/configs/cougarcanyon2_defconfig b/configs/cougarcanyon2_defconfig
index 1008ef7..46a3a21 100644
--- a/configs/cougarcanyon2_defconfig
+++ b/configs/cougarcanyon2_defconfig
@@ -37,7 +37,6 @@ CONFIG_DM_RTC=y
CONFIG_SYS_NS16550=y
CONFIG_ICH_SPI=y
CONFIG_TIMER=y
-CONFIG_USB=y
CONFIG_DM_USB=y
CONFIG_USB_STORAGE=y
CONFIG_USB_KEYBOARD=y
diff --git a/configs/crownbay_defconfig b/configs/crownbay_defconfig
index ac50681..fae404c 100644
--- a/configs/crownbay_defconfig
+++ b/configs/crownbay_defconfig
@@ -54,7 +54,6 @@ CONFIG_DM_RTC=y
CONFIG_SYS_NS16550=y
CONFIG_ICH_SPI=y
CONFIG_TIMER=y
-CONFIG_USB=y
CONFIG_DM_USB=y
CONFIG_USB_STORAGE=y
CONFIG_USB_KEYBOARD=y
diff --git a/configs/dfi-bt700-q7x-151_defconfig b/configs/dfi-bt700-q7x-151_defconfig
index c86e0a9..57b4075 100644
--- a/configs/dfi-bt700-q7x-151_defconfig
+++ b/configs/dfi-bt700-q7x-151_defconfig
@@ -65,7 +65,6 @@ CONFIG_DEBUG_UART_CLOCK=1843200
CONFIG_SYS_NS16550=y
CONFIG_ICH_SPI=y
CONFIG_TIMER=y
-CONFIG_USB=y
CONFIG_DM_USB=y
CONFIG_USB_STORAGE=y
CONFIG_USB_KEYBOARD=y
diff --git a/configs/efi-x86_defconfig b/configs/efi-x86_defconfig
index 2fae904..0d9e1f7 100644
--- a/configs/efi-x86_defconfig
+++ b/configs/efi-x86_defconfig
@@ -37,7 +37,6 @@ CONFIG_DEBUG_UART_BASE=0
CONFIG_DEBUG_UART_CLOCK=0
CONFIG_ICH_SPI=y
CONFIG_TIMER=y
-CONFIG_USB=y
CONFIG_USB_STORAGE=y
CONFIG_USB_KEYBOARD=y
CONFIG_EFI=y
diff --git a/configs/galileo_defconfig b/configs/galileo_defconfig
index f60abc3..24f0296 100644
--- a/configs/galileo_defconfig
+++ b/configs/galileo_defconfig
@@ -56,7 +56,6 @@ CONFIG_DM_RTC=y
CONFIG_SYS_NS16550=y
CONFIG_ICH_SPI=y
CONFIG_TIMER=y
-CONFIG_USB=y
CONFIG_DM_USB=y
CONFIG_USB_STORAGE=y
CONFIG_USB_KEYBOARD=y
diff --git a/configs/minnowmax_defconfig b/configs/minnowmax_defconfig
index 72dea82..94fe5e3 100644
--- a/configs/minnowmax_defconfig
+++ b/configs/minnowmax_defconfig
@@ -67,7 +67,6 @@ CONFIG_DEBUG_UART_CLOCK=1843200
CONFIG_SYS_NS16550=y
CONFIG_ICH_SPI=y
CONFIG_TIMER=y
-CONFIG_USB=y
CONFIG_DM_USB=y
CONFIG_USB_XHCI_HCD=y
CONFIG_USB_STORAGE=y
diff --git a/configs/qemu-x86_64_defconfig b/configs/qemu-x86_64_defconfig
index 2b43827..8a57410 100644
--- a/configs/qemu-x86_64_defconfig
+++ b/configs/qemu-x86_64_defconfig
@@ -70,7 +70,6 @@ CONFIG_DEBUG_UART_BASE=0x3f8
CONFIG_DEBUG_UART_CLOCK=1843200
CONFIG_SYS_NS16550=y
CONFIG_TIMER=y
-CONFIG_USB=y
CONFIG_DM_USB=y
CONFIG_USB_STORAGE=y
CONFIG_USB_KEYBOARD=y
diff --git a/configs/qemu-x86_defconfig b/configs/qemu-x86_defconfig
index b648326..b3912fd 100644
--- a/configs/qemu-x86_defconfig
+++ b/configs/qemu-x86_defconfig
@@ -48,7 +48,6 @@ CONFIG_DM_PCI=y
CONFIG_DM_RTC=y
CONFIG_SYS_NS16550=y
CONFIG_TIMER=y
-CONFIG_USB=y
CONFIG_DM_USB=y
CONFIG_USB_STORAGE=y
CONFIG_USB_KEYBOARD=y
diff --git a/configs/qemu-x86_efi_payload32_defconfig b/configs/qemu-x86_efi_payload32_defconfig
index e092dbd..57002b6 100644
--- a/configs/qemu-x86_efi_payload32_defconfig
+++ b/configs/qemu-x86_efi_payload32_defconfig
@@ -45,7 +45,6 @@ CONFIG_DM_PCI=y
CONFIG_DM_RTC=y
CONFIG_SYS_NS16550=y
CONFIG_TIMER=y
-CONFIG_USB=y
CONFIG_DM_USB=y
CONFIG_USB_STORAGE=y
CONFIG_USB_KEYBOARD=y
diff --git a/configs/qemu-x86_efi_payload64_defconfig b/configs/qemu-x86_efi_payload64_defconfig
index f8f6295..fc590d4 100644
--- a/configs/qemu-x86_efi_payload64_defconfig
+++ b/configs/qemu-x86_efi_payload64_defconfig
@@ -46,7 +46,6 @@ CONFIG_DM_PCI=y
CONFIG_DM_RTC=y
CONFIG_SYS_NS16550=y
CONFIG_TIMER=y
-CONFIG_USB=y
CONFIG_DM_USB=y
CONFIG_USB_STORAGE=y
CONFIG_USB_KEYBOARD=y
diff --git a/configs/som-db5800-som-6867_defconfig b/configs/som-db5800-som-6867_defconfig
index 56a7e4b..c7cd91d 100644
--- a/configs/som-db5800-som-6867_defconfig
+++ b/configs/som-db5800-som-6867_defconfig
@@ -59,7 +59,6 @@ CONFIG_DEBUG_UART_CLOCK=1843200
CONFIG_SYS_NS16550=y
CONFIG_ICH_SPI=y
CONFIG_TIMER=y
-CONFIG_USB=y
CONFIG_DM_USB=y
CONFIG_USB_STORAGE=y
CONFIG_USB_KEYBOARD=y
diff --git a/configs/theadorable-x86-dfi-bt700_defconfig b/configs/theadorable-x86-dfi-bt700_defconfig
index 1703cee..8424714 100644
--- a/configs/theadorable-x86-dfi-bt700_defconfig
+++ b/configs/theadorable-x86-dfi-bt700_defconfig
@@ -62,7 +62,6 @@ CONFIG_DM_RTC=y
CONFIG_SYS_NS16550=y
CONFIG_ICH_SPI=y
CONFIG_TIMER=y
-CONFIG_USB=y
CONFIG_DM_USB=y
CONFIG_USB_STORAGE=y
CONFIG_USB_KEYBOARD=y
--
2.9.2
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [U-Boot] [PATCH v2] arch/x86: Select USB before selecting host driver
2017-07-22 4:18 [U-Boot] [PATCH v2] arch/x86: Select USB before selecting host driver Bin Meng
@ 2017-07-22 5:15 ` Bin Meng
2017-07-22 10:45 ` Andy Shevchenko
0 siblings, 1 reply; 5+ messages in thread
From: Bin Meng @ 2017-07-22 5:15 UTC (permalink / raw)
To: u-boot
On Sat, Jul 22, 2017 at 12:18 PM, Bin Meng <bmeng.cn@gmail.com> wrote:
> From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
>
> Kbuild complains if USB is not selected before any of host driver.
>
> warning: (X86) selects USB_EHCI_HCD which has unmet direct dependencies (USB)
> warning: (X86) selects USB_EHCI_HCD which has unmet direct dependencies (USB)
>
> Select it for X86.
>
> Fixes: 64d6ac5bc4a9 ("Kconfig: USB: Migrate CONFIG_USB_EHCI_HCD users to Kconfig")
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> [bmeng: Update all x86 boards' defconfig files to remove CONFIG_USB]
> Signed-off-by: Bin Meng <bmeng.cn@gmail.com>
> ---
> Changes in v2:
> - Update all x86 boards' defconfig files to remove CONFIG_USB
>
> arch/Kconfig | 1 +
> configs/bayleybay_defconfig | 1 -
> configs/chromebook_link64_defconfig | 1 -
> configs/chromebook_link_defconfig | 1 -
> configs/chromebook_samus_defconfig | 1 -
> configs/chromebox_panther_defconfig | 1 -
> configs/conga-qeval20-qa3-e3845-internal-uart_defconfig | 1 -
> configs/conga-qeval20-qa3-e3845_defconfig | 1 -
> configs/coreboot-x86_defconfig | 1 -
> configs/cougarcanyon2_defconfig | 1 -
> configs/crownbay_defconfig | 1 -
> configs/dfi-bt700-q7x-151_defconfig | 1 -
> configs/efi-x86_defconfig | 1 -
> configs/galileo_defconfig | 1 -
> configs/minnowmax_defconfig | 1 -
> configs/qemu-x86_64_defconfig | 1 -
> configs/qemu-x86_defconfig | 1 -
> configs/qemu-x86_efi_payload32_defconfig | 1 -
> configs/qemu-x86_efi_payload64_defconfig | 1 -
> configs/som-db5800-som-6867_defconfig | 1 -
> configs/theadorable-x86-dfi-bt700_defconfig | 1 -
> 21 files changed, 1 insertion(+), 20 deletions(-)
>
applied to u-boot-x86, thanks!
^ permalink raw reply [flat|nested] 5+ messages in thread
* [U-Boot] [PATCH v2] arch/x86: Select USB before selecting host driver
2017-07-22 5:15 ` Bin Meng
@ 2017-07-22 10:45 ` Andy Shevchenko
2017-07-22 13:46 ` Bin Meng
0 siblings, 1 reply; 5+ messages in thread
From: Andy Shevchenko @ 2017-07-22 10:45 UTC (permalink / raw)
To: u-boot
On Sat, Jul 22, 2017 at 8:15 AM, Bin Meng <bmeng.cn@gmail.com> wrote:
> On Sat, Jul 22, 2017 at 12:18 PM, Bin Meng <bmeng.cn@gmail.com> wrote:
>> From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
>>
>> Kbuild complains if USB is not selected before any of host driver.
>>
>> warning: (X86) selects USB_EHCI_HCD which has unmet direct dependencies (USB)
>> warning: (X86) selects USB_EHCI_HCD which has unmet direct dependencies (USB)
>>
>> Select it for X86.
> applied to u-boot-x86, thanks!
Thank you!
Btw, have you seen my ACPI related series? (No hurry with that at all,
just would like to hear if the direction is somewhat okay)
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 5+ messages in thread
* [U-Boot] [PATCH v2] arch/x86: Select USB before selecting host driver
2017-07-22 10:45 ` Andy Shevchenko
@ 2017-07-22 13:46 ` Bin Meng
2017-07-22 16:47 ` Andy Shevchenko
0 siblings, 1 reply; 5+ messages in thread
From: Bin Meng @ 2017-07-22 13:46 UTC (permalink / raw)
To: u-boot
Hi Andy,
On Sat, Jul 22, 2017 at 6:45 PM, Andy Shevchenko
<andy.shevchenko@gmail.com> wrote:
> On Sat, Jul 22, 2017 at 8:15 AM, Bin Meng <bmeng.cn@gmail.com> wrote:
>> On Sat, Jul 22, 2017 at 12:18 PM, Bin Meng <bmeng.cn@gmail.com> wrote:
>>> From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
>>>
>>> Kbuild complains if USB is not selected before any of host driver.
>>>
>>> warning: (X86) selects USB_EHCI_HCD which has unmet direct dependencies (USB)
>>> warning: (X86) selects USB_EHCI_HCD which has unmet direct dependencies (USB)
>>>
>>> Select it for X86.
>
>> applied to u-boot-x86, thanks!
>
> Thank you!
>
> Btw, have you seen my ACPI related series? (No hurry with that at all,
> just would like to hear if the direction is somewhat okay)
Yep, I just reviewed that series and it looks they are in good shape! Thanks!
Regards,
Bin
^ permalink raw reply [flat|nested] 5+ messages in thread
* [U-Boot] [PATCH v2] arch/x86: Select USB before selecting host driver
2017-07-22 13:46 ` Bin Meng
@ 2017-07-22 16:47 ` Andy Shevchenko
0 siblings, 0 replies; 5+ messages in thread
From: Andy Shevchenko @ 2017-07-22 16:47 UTC (permalink / raw)
To: u-boot
On Sat, Jul 22, 2017 at 4:46 PM, Bin Meng <bmeng.cn@gmail.com> wrote:
> On Sat, Jul 22, 2017 at 6:45 PM, Andy Shevchenko
> <andy.shevchenko@gmail.com> wrote:
>> On Sat, Jul 22, 2017 at 8:15 AM, Bin Meng <bmeng.cn@gmail.com> wrote:
>>> On Sat, Jul 22, 2017 at 12:18 PM, Bin Meng <bmeng.cn@gmail.com> wrote:
>> Btw, have you seen my ACPI related series? (No hurry with that at all,
>> just would like to hear if the direction is somewhat okay)
>
> Yep, I just reviewed that series and it looks they are in good shape! Thanks!
Wow! It was light speed fast.
Thanks!
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2017-07-22 16:47 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-07-22 4:18 [U-Boot] [PATCH v2] arch/x86: Select USB before selecting host driver Bin Meng
2017-07-22 5:15 ` Bin Meng
2017-07-22 10:45 ` Andy Shevchenko
2017-07-22 13:46 ` Bin Meng
2017-07-22 16:47 ` Andy Shevchenko
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.