From: Andy Shevchenko <andy.shevchenko@gmail.com>
To: "Rafael J. Wysocki" <rjw@rjwysocki.net>
Cc: Dexuan Cui <decui@microsoft.com>,
"rafael@kernel.org" <rafael@kernel.org>,
"linux-acpi@vger.kernel.org" <linux-acpi@vger.kernel.org>,
"len.brown@intel.com" <len.brown@intel.com>,
Michael Kelley <mikelley@microsoft.com>,
"rui.zhang@intel.com" <rui.zhang@intel.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"wei.liu@kernel.org" <wei.liu@kernel.org>,
Stephen Hemminger <sthemmin@microsoft.com>,
Haiyang Zhang <haiyangz@microsoft.com>,
KY Srinivasan <kys@microsoft.com>,
"dwaipayanray1@gmail.com" <dwaipayanray1@gmail.com>
Subject: Re: [PATCH] ACPI: scan: Fix a Hyper-V Linux VM panic caused by buffer overflow
Date: Sat, 9 Jan 2021 20:43:22 +0200 [thread overview]
Message-ID: <CAHp75VdwnL_=En1soZX_STdrWY86rm2zqsPLx4pv0NK52SDgkw@mail.gmail.com> (raw)
In-Reply-To: <5464224.fTvfEN5hHQ@kreacher>
On Sat, Jan 9, 2021 at 7:08 PM Rafael J. Wysocki <rjw@rjwysocki.net> wrote:
> On Saturday, January 9, 2021 10:37:41 AM CET Dexuan Cui wrote:
...
> > Do you want a simple strlen() check like the below, or a full
> > check of the AAA#### or NNNN#### format?
>
> It would be good to check the format too while at it.
Let me summarize. It seems from my perspective that the best is to
have two checks here (as far as I got word "too" in Rafael's reply):
- per length with a message that "length is exceeded"
- per format with probably different messages depending on the checks
(like "vendor prefix has incorrect format" and "device id has
incorrect format").
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2021-01-09 18:44 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-08 7:23 [PATCH v2] ACPI: scan: Fix a Hyper-V Linux VM panic caused by buffer overflow Dexuan Cui
2021-01-09 3:10 ` Dexuan Cui
[not found] ` <CAHp75VfPsMNZxN-hA3Cytjpm0K9xGoQpcGY_FZR4hUrtyqMj=w@mail.gmail.com>
2021-01-09 9:37 ` [PATCH] " Dexuan Cui
2021-01-09 17:08 ` Rafael J. Wysocki
2021-01-09 18:43 ` Andy Shevchenko [this message]
2021-01-11 19:50 ` Rafael J. Wysocki
2021-01-09 8:24 ` [PATCH v2] " Jethro Beekman
-- strict thread matches above, loose matches on Subject: below --
2020-12-18 4:08 [PATCH] " Dexuan Cui
2020-12-18 18:29 ` Dexuan Cui
2020-12-22 13:55 ` Michael Kelley
2021-01-05 22:01 ` Dexuan Cui
2021-01-07 13:47 ` Rafael J. Wysocki
2021-01-08 7:06 ` Dexuan Cui
2021-01-07 13:39 ` Dwaipayan Ray
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAHp75VdwnL_=En1soZX_STdrWY86rm2zqsPLx4pv0NK52SDgkw@mail.gmail.com' \
--to=andy.shevchenko@gmail.com \
--cc=decui@microsoft.com \
--cc=dwaipayanray1@gmail.com \
--cc=haiyangz@microsoft.com \
--cc=kys@microsoft.com \
--cc=len.brown@intel.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mikelley@microsoft.com \
--cc=rafael@kernel.org \
--cc=rjw@rjwysocki.net \
--cc=rui.zhang@intel.com \
--cc=sthemmin@microsoft.com \
--cc=wei.liu@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.