All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dexuan Cui <decui@microsoft.com>
To: Michael Kelley <mikelley@microsoft.com>,
	"linux-acpi@vger.kernel.org" <linux-acpi@vger.kernel.org>,
	"rjw@rjwysocki.net" <rjw@rjwysocki.net>,
	"len.brown@intel.com" <len.brown@intel.com>,
	"wei.liu@kernel.org" <wei.liu@kernel.org>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	Stephen Hemminger <sthemmin@microsoft.com>,
	Haiyang Zhang <haiyangz@microsoft.com>,
	KY Srinivasan <kys@microsoft.com>
Subject: RE: [PATCH] ACPI: scan: Fix a Hyper-V Linux VM panic caused by buffer overflow
Date: Tue, 5 Jan 2021 22:01:47 +0000	[thread overview]
Message-ID: <MW2PR2101MB181943C255A86A11E5402E50BFD19@MW2PR2101MB1819.namprd21.prod.outlook.com> (raw)
In-Reply-To: <MW2PR2101MB1052E61BEB80F14896EEFA79D7DF9@MW2PR2101MB1052.namprd21.prod.outlook.com>

> From: Michael Kelley <mikelley@microsoft.com>
> Sent: Tuesday, December 22, 2020 5:56 AM
> From: Dexuan Cui 
> Sent: Thursday, December 17, 2020
> 8:08 PM
> >
> > Linux VM on Hyper-V crashes with the latest mainline:
> > ...
> > --- a/drivers/acpi/scan.c
> > +++ b/drivers/acpi/scan.c
> > @@ -674,7 +674,8 @@ int acpi_device_add(struct acpi_device *device,
> >  	}
> >  	if (!found) {
> >  		acpi_device_bus_id = new_bus_id;
> > -		strcpy(acpi_device_bus_id->bus_id, acpi_device_hid(device));
> > +		strlcpy(acpi_device_bus_id->bus_id, acpi_device_hid(device),
> > +			sizeof(acpi_device_bus_id->bus_id));
> >  		acpi_device_bus_id->instance_no = 0;
> >  		list_add_tail(&acpi_device_bus_id->node, &acpi_bus_id_list);
> >  	}
> 
> Reviewed-by: Michael Kelley <mikelley@microsoft.com>

Hi, ACPI maintainers,
Would you please take a look at the small fix? Currently the mainline Linux
kernel, running in a VM on Hyper-V, has been broken for almost 3 weeks,
i.e. the VM always panics when it boots.

The patch has already had Michael's Reviewed-by.

BTW, the patch should have a stable tag:
Cc: <stable@vger.kernel.org>

Or, do you want the patch to go through the Hyper-V tree?
https://git.kernel.org/pub/scm/linux/kernel/git/hyperv/linux.git/log/?h=hyperv-fixes

The small patch is unlikely to cause a merge conflict, and it only affects
Linux VMs on Hyper-V so far.

Thanks,
-- Dexuan

  reply	other threads:[~2021-01-05 22:02 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-12-18  4:08 [PATCH] ACPI: scan: Fix a Hyper-V Linux VM panic caused by buffer overflow Dexuan Cui
2020-12-18 18:29 ` Dexuan Cui
2020-12-22 13:55 ` Michael Kelley
2021-01-05 22:01   ` Dexuan Cui [this message]
2021-01-07 13:47     ` Rafael J. Wysocki
2021-01-08  7:06       ` Dexuan Cui
2021-01-07 13:39 ` Dwaipayan Ray
2021-01-08  7:23 [PATCH v2] " Dexuan Cui
2021-01-09  3:10 ` Dexuan Cui
     [not found]   ` <CAHp75VfPsMNZxN-hA3Cytjpm0K9xGoQpcGY_FZR4hUrtyqMj=w@mail.gmail.com>
2021-01-09  9:37     ` [PATCH] " Dexuan Cui
2021-01-09 17:08       ` Rafael J. Wysocki
2021-01-09 18:43         ` Andy Shevchenko
2021-01-11 19:50         ` Rafael J. Wysocki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=MW2PR2101MB181943C255A86A11E5402E50BFD19@MW2PR2101MB1819.namprd21.prod.outlook.com \
    --to=decui@microsoft.com \
    --cc=haiyangz@microsoft.com \
    --cc=kys@microsoft.com \
    --cc=len.brown@intel.com \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mikelley@microsoft.com \
    --cc=rjw@rjwysocki.net \
    --cc=sthemmin@microsoft.com \
    --cc=wei.liu@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.