* Re: [PATCH] net: rtw88: fix an issue about leak system resources
@ 2020-05-04 13:51 Markus Elfring
[not found] ` <20200504144206.GA5409@nuc8i5>
0 siblings, 1 reply; 9+ messages in thread
From: Markus Elfring @ 2020-05-04 13:51 UTC (permalink / raw)
To: Dejin Zheng, linux-wireless, netdev
Cc: linux-kernel, Andy Shevchenko, Brian Norris, David S. Miller,
Kalle Valo, Stanislaw Gruszka, Yan-Hsuan Chuang
> the related system resources were not released when pci_iomap() return
> error in the rtw_pci_io_mapping() function. add pci_release_regions() to
> fix it.
How do you think about a wording variant like the following?
Subject:
[PATCH v2] net: rtw88: Complete exception handling in rtw_pci_io_mapping()
Change description:
A call of the function “pci_request_regions” can fail here.
The corresponding system resources were not released then.
Thus add a call of the function “pci_release_regions”.
Regards,
Markus
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] net: rtw88: fix an issue about leak system resources
[not found] ` <20200504144206.GA5409@nuc8i5>
@ 2020-05-04 15:00 ` Markus Elfring
2020-05-04 17:03 ` Brian Norris
0 siblings, 1 reply; 9+ messages in thread
From: Markus Elfring @ 2020-05-04 15:00 UTC (permalink / raw)
To: Dejin Zheng, linux-wireless, netdev
Cc: LKML, Andy Shevchenko, Brian Norris, David S. Miller, Kalle Valo,
Stanislaw Gruszka, Yan-Hsuan Chuang
>>> the related system resources were not released when pci_iomap() return
>>> error in the rtw_pci_io_mapping() function. add pci_release_regions() to
>>> fix it.
>>
>> How do you think about a wording variant like the following?
>>
>> Subject:
>> [PATCH v2] net: rtw88: Complete exception handling in rtw_pci_io_mapping()
>>
>> Change description:
>> A call of the function “pci_request_regions” can fail here.
>> The corresponding system resources were not released then.
>> Thus add a call of the function “pci_release_regions”.
>>
>>
> Markus, I think my commit comments is a sufficiently clear description
> for this patch.
I got an other impression for specific aspects.
> Someone has told me not to send commit comments again and again
> when it is enough clear.
My patch review tries should give you hints where I noticed wording weaknesses.
The corresponding change tolerance can vary by involved contributors.
> Because it only wastes the precious time of the maintainer
> and very very little help for patch improvement.
I hope that also your commit messages will improve.
> BTW, In the past week, you asked me to change the commit comments in my
> 6 patches like this one. Let me return to the essence of patch, point
> out the code problems and better solutions will be more popular.
I would appreciate if various update suggestions would become nicer somehow.
Regards,
Markus
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] net: rtw88: fix an issue about leak system resources
2020-05-04 15:00 ` Markus Elfring
@ 2020-05-04 17:03 ` Brian Norris
2020-05-04 17:19 ` Markus Elfring
` (2 more replies)
0 siblings, 3 replies; 9+ messages in thread
From: Brian Norris @ 2020-05-04 17:03 UTC (permalink / raw)
To: LKML
Cc: Dejin Zheng, linux-wireless, <netdev@vger.kernel.org>,
Andy Shevchenko, David S. Miller, Kalle Valo, Stanislaw Gruszka,
Yan-Hsuan Chuang, Markus Elfring
(Markus is clearly not taking the hint, but FYI for everyone else:)
On Mon, May 4, 2020 at 8:00 AM Markus Elfring <Markus.Elfring@web.de> wrote:
> > BTW, In the past week, you asked me to change the commit comments in my
> > 6 patches like this one. Let me return to the essence of patch, point
> > out the code problems and better solutions will be more popular.
>
> I would appreciate if various update suggestions would become nicer somehow.
Markus is not really providing any value to the community. Just search
for his recent mail history -- it's all silly commit message
nitpicking of little value. He's been blacklisted by a number of
people already:
https://lkml.kernel.org/lkml/20190919112937.GA3072241@kroah.com/
Some people continue to humor him, but it's mostly just a waste of
their time, as this has been going on for years. Just look at searches
like this, and tell me whether they produce anything useful:
https://lkml.kernel.org/lkml/?q=%22markus+elfring%22&o=5000
Brian
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: net: rtw88: fix an issue about leak system resources
2020-05-04 17:03 ` Brian Norris
@ 2020-05-04 17:19 ` Markus Elfring
2020-05-04 17:19 ` Markus Elfring
2020-05-05 0:59 ` [PATCH] " Dejin Zheng
2 siblings, 0 replies; 9+ messages in thread
From: Markus Elfring @ 2020-05-04 17:19 UTC (permalink / raw)
To: Brian Norris, linux-wireless, netdev
Cc: LKML, Andy Shevchenko, David S. Miller, Dejin Zheng, Kalle Valo,
Stanislaw Gruszka, Yan-Hsuan Chuang
> Markus is not really providing any value to the community.
The opinions can vary also around my contributions.
> Just search for his recent mail history -- it's all silly commit message
> nitpicking of little value.
I dare to point questionable implementation (and/or wording) details out.
> He's been blacklisted by a number of people already:
Such communication settings can happen for some reasons.
> Some people continue to humor him, but it's mostly just a waste of
> their time, as this has been going on for years. Just look at searches
> like this, and tell me whether they produce anything useful:
>
> https://lkml.kernel.org/lkml/?q=%22markus+elfring%22&o=5000
How do you think about to take another look at published software development
statistics in constructive ways?
Regards,
Markus
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: net: rtw88: fix an issue about leak system resources
2020-05-04 17:03 ` Brian Norris
2020-05-04 17:19 ` Markus Elfring
@ 2020-05-04 17:19 ` Markus Elfring
2020-05-05 0:59 ` [PATCH] " Dejin Zheng
2 siblings, 0 replies; 9+ messages in thread
From: Markus Elfring @ 2020-05-04 17:19 UTC (permalink / raw)
To: Brian Norris, linux-wireless, netdev
Cc: LKML, Andy Shevchenko, David S. Miller, Dejin Zheng, Kalle Valo,
Stanislaw Gruszka, Yan-Hsuan Chuang
> Markus is not really providing any value to the community.
The opinions can vary also around my contributions.
> Just search for his recent mail history -- it's all silly commit message
> nitpicking of little value.
I dare to point questionable implementation (and/or wording) details out.
> He's been blacklisted by a number of people already:
Such communication settings can happen for some reasons.
> Some people continue to humor him, but it's mostly just a waste of
> their time, as this has been going on for years. Just look at searches
> like this, and tell me whether they produce anything useful:
>
> https://lkml.kernel.org/lkml/?q=%22markus+elfring%22&o=5000
How do you think about to take another look at published software development
statistics in constructive ways?
Regards,
Markus
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] net: rtw88: fix an issue about leak system resources
2020-05-04 17:03 ` Brian Norris
2020-05-04 17:19 ` Markus Elfring
2020-05-04 17:19 ` Markus Elfring
@ 2020-05-05 0:59 ` Dejin Zheng
2020-05-05 6:15 ` Markus Elfring
2020-05-05 8:52 ` [PATCH] " Andy Shevchenko
2 siblings, 2 replies; 9+ messages in thread
From: Dejin Zheng @ 2020-05-05 0:59 UTC (permalink / raw)
To: Brian Norris
Cc: LKML, linux-wireless, <netdev@vger.kernel.org>,
Andy Shevchenko, David S. Miller, Kalle Valo, Stanislaw Gruszka,
Yan-Hsuan Chuang, Markus Elfring
On Mon, May 04, 2020 at 10:03:59AM -0700, Brian Norris wrote:
> (Markus is clearly not taking the hint, but FYI for everyone else:)
>
> On Mon, May 4, 2020 at 8:00 AM Markus Elfring <Markus.Elfring@web.de> wrote:
> > > BTW, In the past week, you asked me to change the commit comments in my
> > > 6 patches like this one. Let me return to the essence of patch, point
> > > out the code problems and better solutions will be more popular.
> >
> > I would appreciate if various update suggestions would become nicer somehow.
>
> Markus is not really providing any value to the community. Just search
> for his recent mail history -- it's all silly commit message
> nitpicking of little value. He's been blacklisted by a number of
> people already:
>
> https://lkml.kernel.org/lkml/20190919112937.GA3072241@kroah.com/
>
> Some people continue to humor him, but it's mostly just a waste of
> their time, as this has been going on for years. Just look at searches
> like this, and tell me whether they produce anything useful:
>
> https://lkml.kernel.org/lkml/?q=%22markus+elfring%22&o=5000
>
Brian, Thanks very much for your reminder, These comments have always
bothered me. Now I can put it on my blacklist. Thank you very very much!
BR,
Dejin
> Brian
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: net: rtw88: fix an issue about leak system resources
2020-05-05 0:59 ` [PATCH] " Dejin Zheng
@ 2020-05-05 6:15 ` Markus Elfring
2020-05-05 8:52 ` [PATCH] " Andy Shevchenko
1 sibling, 0 replies; 9+ messages in thread
From: Markus Elfring @ 2020-05-05 6:15 UTC (permalink / raw)
To: Dejin Zheng, linux-wireless, netdev
Cc: Brian Norris, LKML, Andy Shevchenko, David S. Miller, Kalle Valo,
Stanislaw Gruszka, Yan-Hsuan Chuang
> Brian, Thanks very much for your reminder,
Reminders can hopefully trigger positive effects.
> These comments have always bothered me.
Thanks for such information.
> Now I can put it on my blacklist.
I find it unfortunate that you choose to adjust your communication preferences
in this direction.
Thus I am curious if other contributors will get more chances to integrate
another bit of advice into your software development attention.
Regards,
Markus
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] net: rtw88: fix an issue about leak system resources
2020-05-05 0:59 ` [PATCH] " Dejin Zheng
2020-05-05 6:15 ` Markus Elfring
@ 2020-05-05 8:52 ` Andy Shevchenko
2020-05-05 9:03 ` net: rtw88: Fix an issue about leaking " Markus Elfring
1 sibling, 1 reply; 9+ messages in thread
From: Andy Shevchenko @ 2020-05-05 8:52 UTC (permalink / raw)
To: Dejin Zheng
Cc: Brian Norris, LKML, linux-wireless,
<netdev@vger.kernel.org>,
David S. Miller, Kalle Valo, Stanislaw Gruszka, Yan-Hsuan Chuang,
Markus Elfring
On Tue, May 5, 2020 at 3:59 AM Dejin Zheng <zhengdejin5@gmail.com> wrote:
> On Mon, May 04, 2020 at 10:03:59AM -0700, Brian Norris wrote:
> > (Markus is clearly not taking the hint, but FYI for everyone else:)
> Brian, Thanks very much for your reminder, These comments have always
> bothered me. Now I can put it on my blacklist. Thank you very very much!
Perhaps we need to find a good researcher student who may do a MD
dissertation out of the case :-)
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: net: rtw88: Fix an issue about leaking system resources
2020-05-05 8:52 ` [PATCH] " Andy Shevchenko
@ 2020-05-05 9:03 ` Markus Elfring
0 siblings, 0 replies; 9+ messages in thread
From: Markus Elfring @ 2020-05-05 9:03 UTC (permalink / raw)
To: Andy Shevchenko, linux-wireless, netdev
Cc: Dejin Zheng, Brian Norris, LKML, David S. Miller, Kalle Valo,
Stanislaw Gruszka, Yan-Hsuan Chuang
> Perhaps we need to find a good researcher student who may do a MD
> dissertation out of the case :-)
I got the impression that some research is performed already around
affected areas.
Would you like to reuse any more experiences from there?
Regards,
Markus
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2020-05-05 9:04 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-05-04 13:51 [PATCH] net: rtw88: fix an issue about leak system resources Markus Elfring
[not found] ` <20200504144206.GA5409@nuc8i5>
2020-05-04 15:00 ` Markus Elfring
2020-05-04 17:03 ` Brian Norris
2020-05-04 17:19 ` Markus Elfring
2020-05-04 17:19 ` Markus Elfring
2020-05-05 0:59 ` [PATCH] " Dejin Zheng
2020-05-05 6:15 ` Markus Elfring
2020-05-05 8:52 ` [PATCH] " Andy Shevchenko
2020-05-05 9:03 ` net: rtw88: Fix an issue about leaking " Markus Elfring
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.