From: Andy Shevchenko <andy.shevchenko@gmail.com> To: Daniel Scally <djrscally@gmail.com> Cc: Sakari Ailus <sakari.ailus@linux.intel.com>, Linux Kernel Mailing List <linux-kernel@vger.kernel.org>, ACPI Devel Maling List <linux-acpi@vger.kernel.org>, Linux Media Mailing List <linux-media@vger.kernel.org>, devel@acpica.org, "Rafael J. Wysocki" <rjw@rjwysocki.net>, Len Brown <lenb@kernel.org>, Greg Kroah-Hartman <gregkh@linuxfoundation.org>, Yong Zhi <yong.zhi@intel.com>, Bingbu Cao <bingbu.cao@intel.com>, Tian Shu Qiu <tian.shu.qiu@intel.com>, Mauro Carvalho Chehab <mchehab@kernel.org>, Robert Moore <robert.moore@intel.com>, Erik Kaneda <erik.kaneda@intel.com>, Petr Mladek <pmladek@suse.com>, Steven Rostedt <rostedt@goodmis.org>, Sergey Senozhatsky <sergey.senozhatsky@gmail.com>, Rasmus Villemoes <linux@rasmusvillemoes.dk>, Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>, Jacopo Mondi <jacopo+renesas@jmondi.org>, kieran.bingham+renesas@ideasonboard.com, Hans Verkuil <hverkuil-cisco@xs4all.nl>, Marco Felsch <m.felsch@pengutronix.de>, niklas.soderlund+renesas@ragnatech.se, Steve Longerbeam <slongerbeam@gmail.com>, "Krogerus, Heikki" <heikki.krogerus@linux.intel.com>, Linus Walleij <linus.walleij@linaro.org>, Jordan Hand <jorhand@linux.microsoft.com>, Laurent Pinchart <laurent.pinchart@ideasonboard.com> Subject: Re: [PATCH v3 14/14] ipu3-cio2: Add cio2-bridge to ipu3-cio2 driver Date: Tue, 29 Dec 2020 01:47:12 +0200 [thread overview] Message-ID: <CAHp75VeCbmUXagxwfn55tqicJoWqdHjN8_sirBtBbxueCV88Pw@mail.gmail.com> (raw) In-Reply-To: <1b6ffc66-d16e-8ab4-64c8-b92bfac557f0@gmail.com> On Tue, Dec 29, 2020 at 1:30 AM Daniel Scally <djrscally@gmail.com> wrote: > > Hi Andy > > On 28/12/2020 22:55, Andy Shevchenko wrote: > > On Mon, Dec 28, 2020 at 10:37:38PM +0000, Daniel Scally wrote: > >> On 28/12/2020 17:05, Sakari Ailus wrote: > >>> On Thu, Dec 24, 2020 at 02:54:44PM +0200, Andy Shevchenko wrote: > > ... > > > >>>>> +#include <linux/property.h> > >>>>> + > >>>>> +#define CIO2_HID "INT343E" > >>>>> +#define CIO2_NUM_PORTS 4 > >>> This is already defined in ipu3-cio2.h. Could you include that instead? > >> Yes; but I'd need to also include media/v4l2-device.h and > >> media/videobuf2-dma-sg.h (they're included in ipu3-cio2-main.c at the > >> moment). It didn't seem worth it; but I can move those two includes from > >> the .c to the .h and then include ipu3-cio2.h in cio2-bridge.h > >> > >> Which do you prefer? > > I think here should be a > > compromise variant, split out something like ipu3-cio2-defs.h which can be > > included in both ipu3-cio2.h and cio2-bridge.h. > > And just including all the things that need to be in both files you mean? Something which may be logically grouped together. It may include something which cio2-bridge doesn't need, but at least it will be in one place (for example, if you move one CIO2_PCI_* constant, that means you better move all, or so, the rest CIO2_PCI_* constants as well). -- With Best Regards, Andy Shevchenko
WARNING: multiple messages have this Message-ID (diff)
From: Andy Shevchenko <andy.shevchenko at gmail.com> To: devel@acpica.org Subject: [Devel] Re: [PATCH v3 14/14] ipu3-cio2: Add cio2-bridge to ipu3-cio2 driver Date: Mon, 28 Dec 2020 23:47:29 +0000 [thread overview] Message-ID: <CAHp75VeCbmUXagxwfn55tqicJoWqdHjN8_sirBtBbxueCV88Pw@mail.gmail.com> (raw) In-Reply-To: 1b6ffc66-d16e-8ab4-64c8-b92bfac557f0@gmail.com [-- Attachment #1: Type: text/plain, Size: 1489 bytes --] On Tue, Dec 29, 2020 at 1:30 AM Daniel Scally <djrscally(a)gmail.com> wrote: > > Hi Andy > > On 28/12/2020 22:55, Andy Shevchenko wrote: > > On Mon, Dec 28, 2020 at 10:37:38PM +0000, Daniel Scally wrote: > >> On 28/12/2020 17:05, Sakari Ailus wrote: > >>> On Thu, Dec 24, 2020 at 02:54:44PM +0200, Andy Shevchenko wrote: > > ... > > > >>>>> +#include <linux/property.h> > >>>>> + > >>>>> +#define CIO2_HID "INT343E" > >>>>> +#define CIO2_NUM_PORTS 4 > >>> This is already defined in ipu3-cio2.h. Could you include that instead? > >> Yes; but I'd need to also include media/v4l2-device.h and > >> media/videobuf2-dma-sg.h (they're included in ipu3-cio2-main.c at the > >> moment). It didn't seem worth it; but I can move those two includes from > >> the .c to the .h and then include ipu3-cio2.h in cio2-bridge.h > >> > >> Which do you prefer? > > I think here should be a > > compromise variant, split out something like ipu3-cio2-defs.h which can be > > included in both ipu3-cio2.h and cio2-bridge.h. > > And just including all the things that need to be in both files you mean? Something which may be logically grouped together. It may include something which cio2-bridge doesn't need, but at least it will be in one place (for example, if you move one CIO2_PCI_* constant, that means you better move all, or so, the rest CIO2_PCI_* constants as well). -- With Best Regards, Andy Shevchenko
next prev parent reply other threads:[~2020-12-28 23:48 UTC|newest] Thread overview: 71+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-12-24 1:08 [PATCH v3 00/14] Add functionality to ipu3-cio2 driver allowing software_node connections to sensors on platforms designed for Windows Daniel Scally 2020-12-24 1:08 ` [PATCH v3 01/14] software_node: Fix refcounts in software_node_get_next_child() Daniel Scally 2020-12-24 1:08 ` [PATCH v3 02/14] property: Return true in fwnode_device_is_available for NULL ops Daniel Scally 2020-12-24 1:08 ` [PATCH v3 03/14] property: Call fwnode_graph_get_endpoint_by_id() for fwnode->secondary Daniel Scally 2020-12-24 1:08 ` [PATCH v3 04/14] software_node: Enforce parent before child ordering of nodes arrays Daniel Scally 2020-12-24 1:08 ` [PATCH v3 05/14] software_node: unregister software_nodes in reverse order Daniel Scally 2020-12-24 12:13 ` Andy Shevchenko 2020-12-24 12:13 ` [Devel] " Andy Shevchenko 2020-12-24 14:00 ` Daniel Scally 2020-12-24 14:12 ` Andy Shevchenko 2020-12-24 14:12 ` [Devel] " Andy Shevchenko 2020-12-24 14:14 ` Daniel Scally 2020-12-24 18:36 ` David Laight 2020-12-28 10:15 ` Andy Shevchenko 2020-12-28 10:15 ` [Devel] " Andy Shevchenko 2020-12-28 21:17 ` Daniel Scally 2020-12-28 16:34 ` Sakari Ailus 2020-12-28 17:47 ` Andy Shevchenko 2020-12-24 1:08 ` [PATCH v3 06/14] include: fwnode.h: Define format macros for ports and endpoints Daniel Scally 2020-12-24 12:17 ` Andy Shevchenko 2020-12-24 12:17 ` [Devel] " Andy Shevchenko 2020-12-24 12:41 ` Laurent Pinchart 2020-12-28 16:30 ` Sakari Ailus 2020-12-28 17:11 ` Sakari Ailus 2020-12-28 21:36 ` Daniel Scally 2020-12-24 1:09 ` [PATCH v3 07/14] software_node: Add support for fwnode_graph*() family of functions Daniel Scally 2020-12-24 12:24 ` Andy Shevchenko 2020-12-24 12:24 ` [Devel] " Andy Shevchenko 2020-12-24 12:55 ` Laurent Pinchart 2020-12-24 13:03 ` Andy Shevchenko 2020-12-24 13:03 ` [Devel] " Andy Shevchenko 2020-12-24 14:21 ` Daniel Scally 2020-12-28 16:41 ` Sakari Ailus 2020-12-28 21:37 ` Daniel Scally 2020-12-26 23:47 ` Daniel Scally 2020-12-24 12:53 ` Laurent Pinchart 2020-12-24 14:24 ` Daniel Scally 2020-12-24 1:09 ` [PATCH v3 08/14] lib/test_printf.c: Use helper function to unwind array of software_nodes Daniel Scally 2020-12-24 1:09 ` [PATCH v3 09/14] ipu3-cio2: Add T: entry to MAINTAINERS Daniel Scally 2020-12-24 1:09 ` [PATCH v3 10/14] ipu3-cio2: Rename ipu3-cio2.c Daniel Scally 2020-12-24 1:09 ` [PATCH v3 11/14] media: v4l2-core: v4l2-async: Check sd->fwnode->secondary in match_fwnode() Daniel Scally 2020-12-24 1:09 ` [PATCH v3 12/14] acpi: Add acpi_dev_get_next_match_dev() and helper macro Daniel Scally 2020-12-24 1:09 ` [PATCH v3 13/14] include: media: v4l2-fwnode: Include v4l2_fwnode_bus_type Daniel Scally 2020-12-24 12:32 ` Andy Shevchenko 2020-12-24 12:32 ` [Devel] " Andy Shevchenko 2020-12-26 23:14 ` Daniel Scally 2020-12-24 12:58 ` Laurent Pinchart 2020-12-24 1:09 ` [PATCH v3 14/14] ipu3-cio2: Add cio2-bridge to ipu3-cio2 driver Daniel Scally 2020-12-24 12:54 ` Andy Shevchenko 2020-12-24 12:54 ` [Devel] " Andy Shevchenko 2020-12-26 23:23 ` Daniel Scally 2020-12-28 17:05 ` Sakari Ailus 2020-12-28 22:37 ` Daniel Scally 2020-12-28 22:54 ` [Devel] " Andy Shevchenko 2020-12-28 22:55 ` Andy Shevchenko 2020-12-28 23:07 ` Laurent Pinchart 2020-12-28 23:54 ` Andy Shevchenko 2020-12-28 23:55 ` [Devel] " Andy Shevchenko 2020-12-29 0:07 ` Laurent Pinchart 2020-12-30 20:47 ` Andy Shevchenko 2020-12-30 20:48 ` [Devel] " Andy Shevchenko 2020-12-28 23:30 ` Daniel Scally 2020-12-28 23:47 ` Andy Shevchenko [this message] 2020-12-28 23:47 ` [Devel] " Andy Shevchenko 2021-01-02 17:07 ` Sakari Ailus 2021-01-02 17:12 ` Daniel Scally 2021-01-02 17:21 ` Sakari Ailus 2021-01-02 17:24 ` Sakari Ailus 2021-01-02 21:23 ` Daniel Scally 2020-12-28 22:55 [Devel] " Andy Shevchenko 2020-12-28 22:56 ` Andy Shevchenko
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=CAHp75VeCbmUXagxwfn55tqicJoWqdHjN8_sirBtBbxueCV88Pw@mail.gmail.com \ --to=andy.shevchenko@gmail.com \ --cc=bingbu.cao@intel.com \ --cc=devel@acpica.org \ --cc=djrscally@gmail.com \ --cc=erik.kaneda@intel.com \ --cc=gregkh@linuxfoundation.org \ --cc=heikki.krogerus@linux.intel.com \ --cc=hverkuil-cisco@xs4all.nl \ --cc=jacopo+renesas@jmondi.org \ --cc=jorhand@linux.microsoft.com \ --cc=kieran.bingham+renesas@ideasonboard.com \ --cc=laurent.pinchart+renesas@ideasonboard.com \ --cc=laurent.pinchart@ideasonboard.com \ --cc=lenb@kernel.org \ --cc=linus.walleij@linaro.org \ --cc=linux-acpi@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-media@vger.kernel.org \ --cc=linux@rasmusvillemoes.dk \ --cc=m.felsch@pengutronix.de \ --cc=mchehab@kernel.org \ --cc=niklas.soderlund+renesas@ragnatech.se \ --cc=pmladek@suse.com \ --cc=rjw@rjwysocki.net \ --cc=robert.moore@intel.com \ --cc=rostedt@goodmis.org \ --cc=sakari.ailus@linux.intel.com \ --cc=sergey.senozhatsky@gmail.com \ --cc=slongerbeam@gmail.com \ --cc=tian.shu.qiu@intel.com \ --cc=yong.zhi@intel.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.