* [PATCH] leds: pwm: Fix error code in led_pwm_create_fwnode()
@ 2023-07-11 6:13 Dan Carpenter
2023-07-11 9:10 ` Andy Shevchenko
2023-07-13 14:55 ` Lee Jones
0 siblings, 2 replies; 3+ messages in thread
From: Dan Carpenter @ 2023-07-11 6:13 UTC (permalink / raw)
To: Andy Shevchenko; +Cc: Pavel Machek, Lee Jones, linux-leds, kernel-janitors
Negative -EINVAL was intended, not positive EINVAL. Fix it.
Fixes: 95138e01275e ("leds: pwm: Make error handling more robust")
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
---
drivers/leds/leds-pwm.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/leds/leds-pwm.c b/drivers/leds/leds-pwm.c
index 29194cc382af..87c199242f3c 100644
--- a/drivers/leds/leds-pwm.c
+++ b/drivers/leds/leds-pwm.c
@@ -146,7 +146,7 @@ static int led_pwm_create_fwnode(struct device *dev, struct led_pwm_priv *priv)
led.name = to_of_node(fwnode)->name;
if (!led.name) {
- ret = EINVAL;
+ ret = -EINVAL;
goto err_child_out;
}
--
2.39.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] leds: pwm: Fix error code in led_pwm_create_fwnode()
2023-07-11 6:13 [PATCH] leds: pwm: Fix error code in led_pwm_create_fwnode() Dan Carpenter
@ 2023-07-11 9:10 ` Andy Shevchenko
2023-07-13 14:55 ` Lee Jones
1 sibling, 0 replies; 3+ messages in thread
From: Andy Shevchenko @ 2023-07-11 9:10 UTC (permalink / raw)
To: Dan Carpenter; +Cc: Pavel Machek, Lee Jones, linux-leds, kernel-janitors
On Tue, Jul 11, 2023 at 9:13 AM Dan Carpenter <dan.carpenter@linaro.org> wrote:
>
> Negative -EINVAL was intended, not positive EINVAL. Fix it.
Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>
Thanks!
> Fixes: 95138e01275e ("leds: pwm: Make error handling more robust")
> Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
> ---
> drivers/leds/leds-pwm.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/leds/leds-pwm.c b/drivers/leds/leds-pwm.c
> index 29194cc382af..87c199242f3c 100644
> --- a/drivers/leds/leds-pwm.c
> +++ b/drivers/leds/leds-pwm.c
> @@ -146,7 +146,7 @@ static int led_pwm_create_fwnode(struct device *dev, struct led_pwm_priv *priv)
> led.name = to_of_node(fwnode)->name;
>
> if (!led.name) {
> - ret = EINVAL;
> + ret = -EINVAL;
> goto err_child_out;
> }
>
> --
> 2.39.2
>
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] leds: pwm: Fix error code in led_pwm_create_fwnode()
2023-07-11 6:13 [PATCH] leds: pwm: Fix error code in led_pwm_create_fwnode() Dan Carpenter
2023-07-11 9:10 ` Andy Shevchenko
@ 2023-07-13 14:55 ` Lee Jones
1 sibling, 0 replies; 3+ messages in thread
From: Lee Jones @ 2023-07-13 14:55 UTC (permalink / raw)
To: Dan Carpenter; +Cc: Andy Shevchenko, Pavel Machek, linux-leds, kernel-janitors
On Tue, 11 Jul 2023, Dan Carpenter wrote:
> Negative -EINVAL was intended, not positive EINVAL. Fix it.
>
> Fixes: 95138e01275e ("leds: pwm: Make error handling more robust")
> Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
> ---
> drivers/leds/leds-pwm.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Applied, thanks
--
Lee Jones [李琼斯]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-07-13 14:55 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-07-11 6:13 [PATCH] leds: pwm: Fix error code in led_pwm_create_fwnode() Dan Carpenter
2023-07-11 9:10 ` Andy Shevchenko
2023-07-13 14:55 ` Lee Jones
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.