From: Andy Shevchenko <andy.shevchenko@gmail.com>
To: Vignesh R <vigneshr@ti.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Jiri Slaby <jslaby@suse.com>, Jisheng Zhang <jszhang@marvell.com>,
"linux-serial@vger.kernel.org" <linux-serial@vger.kernel.org>,
linux-arm Mailing List <linux-arm-kernel@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 1/2] tty: serial_core: Add name field to uart_port struct
Date: Fri, 24 Mar 2017 13:46:00 +0200 [thread overview]
Message-ID: <CAHp75VeRBq=VVgh7FaiuFF6GjTx98A2oEYyWaQVEPAmwPExMdg@mail.gmail.com> (raw)
In-Reply-To: <20170324052800.11526-2-vigneshr@ti.com>
On Fri, Mar 24, 2017 at 7:27 AM, Vignesh R <vigneshr@ti.com> wrote:
> Introduce a field to store name of uart_port that can be used to easily
> identify UART port instances on a system that has more than one UART
> instance. The name is of the form ttyXN(eg. ttyS0, ttyAMA0,..) where N
> is number that particular UART instance.
> This field will be useful when printing debug info for a particular port
> or in register IRQs with unique IRQ name. Port name is populated during
> uart_add_one_port().
>
Looks good to me:
Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>
Just in case, have you checked if there any possible scenarios where
memory will be leaked?
> Signed-off-by: Vignesh R <vigneshr@ti.com>
> ---
>
> v2:
> use kasprintf() instead of snprintf()
> Fix up commit message.
>
> drivers/tty/serial/serial_core.c | 7 +++++++
> include/linux/serial_core.h | 1 +
> 2 files changed, 8 insertions(+)
>
> diff --git a/drivers/tty/serial/serial_core.c b/drivers/tty/serial/serial_core.c
> index 0fb3f7cce62a..f5572e28d16a 100644
> --- a/drivers/tty/serial/serial_core.c
> +++ b/drivers/tty/serial/serial_core.c
> @@ -2744,6 +2744,12 @@ int uart_add_one_port(struct uart_driver *drv, struct uart_port *uport)
> state->pm_state = UART_PM_STATE_UNDEFINED;
> uport->cons = drv->cons;
> uport->minor = drv->tty_driver->minor_start + uport->line;
> + uport->name = kasprintf(GFP_KERNEL, "%s%d", drv->dev_name,
> + drv->tty_driver->name_base + uport->line);
> + if (!uport->name) {
> + ret = -ENOMEM;
> + goto out;
> + }
>
> /*
> * If this port is a console, then the spinlock is already
> @@ -2861,6 +2867,7 @@ int uart_remove_one_port(struct uart_driver *drv, struct uart_port *uport)
> if (uport->type != PORT_UNKNOWN && uport->ops->release_port)
> uport->ops->release_port(uport);
> kfree(uport->tty_groups);
> + kfree(uport->name);
>
> /*
> * Indicate that there isn't a port here anymore.
> diff --git a/include/linux/serial_core.h b/include/linux/serial_core.h
> index 58484fb35cc8..60530678c633 100644
> --- a/include/linux/serial_core.h
> +++ b/include/linux/serial_core.h
> @@ -247,6 +247,7 @@ struct uart_port {
> unsigned char suspended;
> unsigned char irq_wake;
> unsigned char unused[2];
> + char *name; /* port name */
> struct attribute_group *attr_group; /* port specific attributes */
> const struct attribute_group **tty_groups; /* all attributes (serial core use only) */
> struct serial_rs485 rs485;
> --
> 2.11.0
>
--
With Best Regards,
Andy Shevchenko
WARNING: multiple messages have this Message-ID (diff)
From: Andy Shevchenko <andy.shevchenko@gmail.com>
To: Vignesh R <vigneshr@ti.com>
Cc: Jisheng Zhang <jszhang@marvell.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-serial@vger.kernel.org" <linux-serial@vger.kernel.org>,
Jiri Slaby <jslaby@suse.com>,
linux-arm Mailing List <linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH v2 1/2] tty: serial_core: Add name field to uart_port struct
Date: Fri, 24 Mar 2017 13:46:00 +0200 [thread overview]
Message-ID: <CAHp75VeRBq=VVgh7FaiuFF6GjTx98A2oEYyWaQVEPAmwPExMdg@mail.gmail.com> (raw)
In-Reply-To: <20170324052800.11526-2-vigneshr@ti.com>
On Fri, Mar 24, 2017 at 7:27 AM, Vignesh R <vigneshr@ti.com> wrote:
> Introduce a field to store name of uart_port that can be used to easily
> identify UART port instances on a system that has more than one UART
> instance. The name is of the form ttyXN(eg. ttyS0, ttyAMA0,..) where N
> is number that particular UART instance.
> This field will be useful when printing debug info for a particular port
> or in register IRQs with unique IRQ name. Port name is populated during
> uart_add_one_port().
>
Looks good to me:
Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>
Just in case, have you checked if there any possible scenarios where
memory will be leaked?
> Signed-off-by: Vignesh R <vigneshr@ti.com>
> ---
>
> v2:
> use kasprintf() instead of snprintf()
> Fix up commit message.
>
> drivers/tty/serial/serial_core.c | 7 +++++++
> include/linux/serial_core.h | 1 +
> 2 files changed, 8 insertions(+)
>
> diff --git a/drivers/tty/serial/serial_core.c b/drivers/tty/serial/serial_core.c
> index 0fb3f7cce62a..f5572e28d16a 100644
> --- a/drivers/tty/serial/serial_core.c
> +++ b/drivers/tty/serial/serial_core.c
> @@ -2744,6 +2744,12 @@ int uart_add_one_port(struct uart_driver *drv, struct uart_port *uport)
> state->pm_state = UART_PM_STATE_UNDEFINED;
> uport->cons = drv->cons;
> uport->minor = drv->tty_driver->minor_start + uport->line;
> + uport->name = kasprintf(GFP_KERNEL, "%s%d", drv->dev_name,
> + drv->tty_driver->name_base + uport->line);
> + if (!uport->name) {
> + ret = -ENOMEM;
> + goto out;
> + }
>
> /*
> * If this port is a console, then the spinlock is already
> @@ -2861,6 +2867,7 @@ int uart_remove_one_port(struct uart_driver *drv, struct uart_port *uport)
> if (uport->type != PORT_UNKNOWN && uport->ops->release_port)
> uport->ops->release_port(uport);
> kfree(uport->tty_groups);
> + kfree(uport->name);
>
> /*
> * Indicate that there isn't a port here anymore.
> diff --git a/include/linux/serial_core.h b/include/linux/serial_core.h
> index 58484fb35cc8..60530678c633 100644
> --- a/include/linux/serial_core.h
> +++ b/include/linux/serial_core.h
> @@ -247,6 +247,7 @@ struct uart_port {
> unsigned char suspended;
> unsigned char irq_wake;
> unsigned char unused[2];
> + char *name; /* port name */
> struct attribute_group *attr_group; /* port specific attributes */
> const struct attribute_group **tty_groups; /* all attributes (serial core use only) */
> struct serial_rs485 rs485;
> --
> 2.11.0
>
--
With Best Regards,
Andy Shevchenko
WARNING: multiple messages have this Message-ID (diff)
From: andy.shevchenko@gmail.com (Andy Shevchenko)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 1/2] tty: serial_core: Add name field to uart_port struct
Date: Fri, 24 Mar 2017 13:46:00 +0200 [thread overview]
Message-ID: <CAHp75VeRBq=VVgh7FaiuFF6GjTx98A2oEYyWaQVEPAmwPExMdg@mail.gmail.com> (raw)
In-Reply-To: <20170324052800.11526-2-vigneshr@ti.com>
On Fri, Mar 24, 2017 at 7:27 AM, Vignesh R <vigneshr@ti.com> wrote:
> Introduce a field to store name of uart_port that can be used to easily
> identify UART port instances on a system that has more than one UART
> instance. The name is of the form ttyXN(eg. ttyS0, ttyAMA0,..) where N
> is number that particular UART instance.
> This field will be useful when printing debug info for a particular port
> or in register IRQs with unique IRQ name. Port name is populated during
> uart_add_one_port().
>
Looks good to me:
Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>
Just in case, have you checked if there any possible scenarios where
memory will be leaked?
> Signed-off-by: Vignesh R <vigneshr@ti.com>
> ---
>
> v2:
> use kasprintf() instead of snprintf()
> Fix up commit message.
>
> drivers/tty/serial/serial_core.c | 7 +++++++
> include/linux/serial_core.h | 1 +
> 2 files changed, 8 insertions(+)
>
> diff --git a/drivers/tty/serial/serial_core.c b/drivers/tty/serial/serial_core.c
> index 0fb3f7cce62a..f5572e28d16a 100644
> --- a/drivers/tty/serial/serial_core.c
> +++ b/drivers/tty/serial/serial_core.c
> @@ -2744,6 +2744,12 @@ int uart_add_one_port(struct uart_driver *drv, struct uart_port *uport)
> state->pm_state = UART_PM_STATE_UNDEFINED;
> uport->cons = drv->cons;
> uport->minor = drv->tty_driver->minor_start + uport->line;
> + uport->name = kasprintf(GFP_KERNEL, "%s%d", drv->dev_name,
> + drv->tty_driver->name_base + uport->line);
> + if (!uport->name) {
> + ret = -ENOMEM;
> + goto out;
> + }
>
> /*
> * If this port is a console, then the spinlock is already
> @@ -2861,6 +2867,7 @@ int uart_remove_one_port(struct uart_driver *drv, struct uart_port *uport)
> if (uport->type != PORT_UNKNOWN && uport->ops->release_port)
> uport->ops->release_port(uport);
> kfree(uport->tty_groups);
> + kfree(uport->name);
>
> /*
> * Indicate that there isn't a port here anymore.
> diff --git a/include/linux/serial_core.h b/include/linux/serial_core.h
> index 58484fb35cc8..60530678c633 100644
> --- a/include/linux/serial_core.h
> +++ b/include/linux/serial_core.h
> @@ -247,6 +247,7 @@ struct uart_port {
> unsigned char suspended;
> unsigned char irq_wake;
> unsigned char unused[2];
> + char *name; /* port name */
> struct attribute_group *attr_group; /* port specific attributes */
> const struct attribute_group **tty_groups; /* all attributes (serial core use only) */
> struct serial_rs485 rs485;
> --
> 2.11.0
>
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2017-03-24 11:46 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-24 5:27 [PATCH v2 0/2] serial: Add name field to uart_port Vignesh R
2017-03-24 5:27 ` Vignesh R
2017-03-24 5:27 ` Vignesh R
2017-03-24 5:27 ` [PATCH v2 1/2] tty: serial_core: Add name field to uart_port struct Vignesh R
2017-03-24 5:27 ` Vignesh R
2017-03-24 5:27 ` Vignesh R
2017-03-24 11:46 ` Andy Shevchenko [this message]
2017-03-24 11:46 ` Andy Shevchenko
2017-03-24 11:46 ` Andy Shevchenko
2017-03-25 10:33 ` Vignesh R
2017-03-25 10:33 ` Vignesh R
2017-03-25 10:33 ` Vignesh R
2017-03-24 5:28 ` [PATCH v2 2/2] serial: 8250: 8250_core: Fix irq name for 8250 serial IRQ Vignesh R
2017-03-24 5:28 ` Vignesh R
2017-03-24 5:28 ` Vignesh R
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAHp75VeRBq=VVgh7FaiuFF6GjTx98A2oEYyWaQVEPAmwPExMdg@mail.gmail.com' \
--to=andy.shevchenko@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=jslaby@suse.com \
--cc=jszhang@marvell.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.