* [PATCH v1] lib/generic-radix-tree: Make good use of while (level--)
@ 2019-03-21 15:30 Andy Shevchenko
2019-03-21 15:36 ` Andy Shevchenko
0 siblings, 1 reply; 2+ messages in thread
From: Andy Shevchenko @ 2019-03-21 15:30 UTC (permalink / raw)
To: Kent Overstreet, linux-kernel; +Cc: Andy Shevchenko
There is no need to split postincrement in while (level--) type of loops.
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
lib/generic-radix-tree.c | 10 ++--------
1 file changed, 2 insertions(+), 8 deletions(-)
diff --git a/lib/generic-radix-tree.c b/lib/generic-radix-tree.c
index a7bafc413730..5a1818a0de1f 100644
--- a/lib/generic-radix-tree.c
+++ b/lib/generic-radix-tree.c
@@ -59,13 +59,9 @@ void *__genradix_ptr(struct __genradix *radix, size_t offset)
if (ilog2(offset) >= genradix_depth_shift(level))
return NULL;
- while (1) {
+ while (level--) {
if (!n)
return NULL;
- if (!level)
- break;
-
- level--;
n = n->children[offset >> genradix_depth_shift(level)];
offset &= genradix_depth_size(level) - 1;
@@ -157,9 +153,7 @@ void *__genradix_iter_peek(struct genradix_iter *iter,
if (ilog2(iter->offset) >= genradix_depth_shift(level))
return NULL;
- while (level) {
- level--;
-
+ while (level--) {
i = (iter->offset >> genradix_depth_shift(level)) &
(GENRADIX_ARY - 1);
--
2.20.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v1] lib/generic-radix-tree: Make good use of while (level--)
2019-03-21 15:30 [PATCH v1] lib/generic-radix-tree: Make good use of while (level--) Andy Shevchenko
@ 2019-03-21 15:36 ` Andy Shevchenko
0 siblings, 0 replies; 2+ messages in thread
From: Andy Shevchenko @ 2019-03-21 15:36 UTC (permalink / raw)
To: Andy Shevchenko; +Cc: Kent Overstreet, Linux Kernel Mailing List
On Thu, Mar 21, 2019 at 5:32 PM Andy Shevchenko
<andriy.shevchenko@linux.intel.com> wrote:
>
> There is no need to split postincrement in while (level--) type of loops.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ---
> lib/generic-radix-tree.c | 10 ++--------
> 1 file changed, 2 insertions(+), 8 deletions(-)
>
> diff --git a/lib/generic-radix-tree.c b/lib/generic-radix-tree.c
> index a7bafc413730..5a1818a0de1f 100644
> --- a/lib/generic-radix-tree.c
> +++ b/lib/generic-radix-tree.c
> @@ -59,13 +59,9 @@ void *__genradix_ptr(struct __genradix *radix, size_t offset)
> if (ilog2(offset) >= genradix_depth_shift(level))
> return NULL;
>
> - while (1) {
> + while (level--) {
> if (!n)
> return NULL;
> - if (!level)
> - break;
> -
> - level--;
My bad, this will need an additional check. before the loop.
>
> n = n->children[offset >> genradix_depth_shift(level)];
> offset &= genradix_depth_size(level) - 1;
> @@ -157,9 +153,7 @@ void *__genradix_iter_peek(struct genradix_iter *iter,
> if (ilog2(iter->offset) >= genradix_depth_shift(level))
> return NULL;
>
> - while (level) {
> - level--;
> -
> + while (level--) {
> i = (iter->offset >> genradix_depth_shift(level)) &
> (GENRADIX_ARY - 1);
>
> --
> 2.20.1
>
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-03-21 15:37 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-03-21 15:30 [PATCH v1] lib/generic-radix-tree: Make good use of while (level--) Andy Shevchenko
2019-03-21 15:36 ` Andy Shevchenko
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.