All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andy Shevchenko <andy.shevchenko@gmail.com>
To: Evgeniy Didin <Evgeniy.Didin@synopsys.com>
Cc: linux-mmc@vger.kernel.org,
	Alexey Brodkin <Alexey.Brodkin@synopsys.com>,
	Eugeniy Paltsev <Eugeniy.Paltsev@synopsys.com>,
	Douglas Anderson <dianders@chromium.org>,
	Ulf Hansson <ulf.hansson@linaro.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	linux-snps-arc@lists.infradead.org,
	Stable <stable@vger.kernel.org>,
	Vineet Gupta <Vineet.Gupta1@synopsys.com>
Subject: Re: [PATCH 1/2 v3] mmc: dw_mmc: Fix the DTO timeout overflow calculation for 32-bit systems
Date: Mon, 26 Feb 2018 16:40:34 +0200	[thread overview]
Message-ID: <CAHp75Vepn=nS9=WRpKhPLQ04EJEpL0tcne-DfV6ip-ELH9ggRA@mail.gmail.com> (raw)
In-Reply-To: <20180226143413.44134-2-Evgeniy.Didin@synopsys.com>

On Mon, Feb 26, 2018 at 4:34 PM, Evgeniy Didin
<Evgeniy.Didin@synopsys.com> wrote:
> In commit 9d9491a7da2a ("mmc: dw_mmc: Fix the DTO timeout calculation") have been made
> changes which cause multiply overflow for 32-bit systems.
> The broken timeout calculations caused false interrupt latency warnings
> and stacktrace splat (such as below) when accessing the SD Card.

> +       drto_ms = DIV_ROUND_UP((u64)MSEC_PER_SEC * drto_clks * drto_div,
>                                host->bus_hz);

Same as per patch 2.

-- 
With Best Regards,
Andy Shevchenko

WARNING: multiple messages have this Message-ID (diff)
From: andy.shevchenko@gmail.com (Andy Shevchenko)
To: linux-snps-arc@lists.infradead.org
Subject: [PATCH 1/2 v3] mmc: dw_mmc: Fix the DTO timeout overflow calculation for 32-bit systems
Date: Mon, 26 Feb 2018 16:40:34 +0200	[thread overview]
Message-ID: <CAHp75Vepn=nS9=WRpKhPLQ04EJEpL0tcne-DfV6ip-ELH9ggRA@mail.gmail.com> (raw)
In-Reply-To: <20180226143413.44134-2-Evgeniy.Didin@synopsys.com>

On Mon, Feb 26, 2018 at 4:34 PM, Evgeniy Didin
<Evgeniy.Didin@synopsys.com> wrote:
> In commit 9d9491a7da2a ("mmc: dw_mmc: Fix the DTO timeout calculation") have been made
> changes which cause multiply overflow for 32-bit systems.
> The broken timeout calculations caused false interrupt latency warnings
> and stacktrace splat (such as below) when accessing the SD Card.

> +       drto_ms = DIV_ROUND_UP((u64)MSEC_PER_SEC * drto_clks * drto_div,
>                                host->bus_hz);

Same as per patch 2.

-- 
With Best Regards,
Andy Shevchenko

  reply	other threads:[~2018-02-26 14:40 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-02-26 14:34 [PATCH 0/2 v3] mmc: dw_mmc: Fix DTO/STO timeout overflow calculation Evgeniy Didin
2018-02-26 14:34 ` Evgeniy Didin
2018-02-26 14:34 ` [PATCH 1/2 v3] mmc: dw_mmc: Fix the DTO timeout overflow calculation for 32-bit systems Evgeniy Didin
2018-02-26 14:34   ` Evgeniy Didin
2018-02-26 14:34   ` Evgeniy Didin
2018-02-26 14:40   ` Andy Shevchenko [this message]
2018-02-26 14:40     ` Andy Shevchenko
2018-02-27  1:14   ` Shawn Lin
2018-02-27  1:14     ` Shawn Lin
2018-02-27  1:46     ` Shawn Lin
2018-02-27  1:46       ` Shawn Lin
2018-03-01  1:22   ` kbuild test robot
2018-03-01  1:22     ` kbuild test robot
2018-02-26 14:34 ` [PATCH 2/2 v3] mmc: dw_mmc: Fix the CTO " Evgeniy Didin
2018-02-26 14:34   ` Evgeniy Didin
2018-02-26 14:39   ` Andy Shevchenko
2018-02-26 14:39     ` Andy Shevchenko
2018-02-26 15:14     ` Evgeniy Didin
2018-02-26 15:14       ` Evgeniy Didin
2018-02-26 15:14       ` Evgeniy Didin
2018-02-26 16:53       ` Andy Shevchenko
2018-02-26 16:53         ` Andy Shevchenko
2018-02-26 17:14         ` Evgeniy Didin
2018-02-26 17:14           ` Evgeniy Didin
2018-02-26 18:30           ` Andy Shevchenko
2018-02-26 18:30             ` Andy Shevchenko
2018-02-26 20:27             ` Alexey Brodkin
2018-02-26 20:27               ` Alexey Brodkin
2018-02-26 20:27               ` Alexey Brodkin
2018-02-27  3:52               ` Jisheng Zhang
2018-02-27  3:52                 ` Jisheng Zhang
2018-02-27 10:49                 ` Andy Shevchenko
2018-02-27 10:49                   ` Andy Shevchenko
2018-02-27  3:02 ` [PATCH 0/2 v3] mmc: dw_mmc: Fix DTO/STO timeout overflow calculation Jisheng Zhang
2018-02-27  3:02   ` Jisheng Zhang
2018-02-27  3:02   ` Jisheng Zhang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAHp75Vepn=nS9=WRpKhPLQ04EJEpL0tcne-DfV6ip-ELH9ggRA@mail.gmail.com' \
    --to=andy.shevchenko@gmail.com \
    --cc=Alexey.Brodkin@synopsys.com \
    --cc=Eugeniy.Paltsev@synopsys.com \
    --cc=Evgeniy.Didin@synopsys.com \
    --cc=Vineet.Gupta1@synopsys.com \
    --cc=dianders@chromium.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mmc@vger.kernel.org \
    --cc=linux-snps-arc@lists.infradead.org \
    --cc=stable@vger.kernel.org \
    --cc=ulf.hansson@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.