All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andy Shevchenko <andy.shevchenko@gmail.com>
To: Joe Perches <joe@perches.com>
Cc: Corentin Chary <corentin.chary@gmail.com>,
	Darren Hart <dvhart@infradead.org>,
	Andy Shevchenko <andy@infradead.org>,
	acpi4asus-user <acpi4asus-user@lists.sourceforge.net>,
	Platform Driver <platform-driver-x86@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 27/35] drivers/platform: Convert remaining uses of pr_warning to pr_warn
Date: Fri, 17 Feb 2017 09:45:08 +0200	[thread overview]
Message-ID: <CAHp75VeytUj9AQz0ROPvQ+VqzmbnEw2PeAY6Zqkxav+c9AZO6w@mail.gmail.com> (raw)
In-Reply-To: <1368dcea67d973983430fd8e328d1da7658dbb0f.1487314667.git.joe@perches.com>

On Fri, Feb 17, 2017 at 9:11 AM, Joe Perches <joe@perches.com> wrote:
> To enable eventual removal of pr_warning
>
> This makes pr_warn use consistent for drivers/platform
>
> Prior to this patch, there were 7 uses of pr_warning and
> 108 uses of pr_warn in drivers/platform

Acked-by: Andy Shevchenko <andy.shevchenko@gmail.com>

>
> Signed-off-by: Joe Perches <joe@perches.com>
> ---
>  drivers/platform/x86/asus-laptop.c    |  2 +-
>  drivers/platform/x86/eeepc-laptop.c   |  2 +-
>  drivers/platform/x86/intel_oaktrail.c | 10 +++++-----
>  3 files changed, 7 insertions(+), 7 deletions(-)
>
> diff --git a/drivers/platform/x86/asus-laptop.c b/drivers/platform/x86/asus-laptop.c
> index 28551f5a2e07..7f248f84f49a 100644
> --- a/drivers/platform/x86/asus-laptop.c
> +++ b/drivers/platform/x86/asus-laptop.c
> @@ -1163,7 +1163,7 @@ static void asus_als_switch(struct asus_laptop *asus, int value)
>                 ret = write_acpi_int(asus->handle, METHOD_ALS_CONTROL, value);
>         }
>         if (ret)
> -               pr_warning("Error setting light sensor switch\n");
> +               pr_warn("Error setting light sensor switch\n");
>
>         asus->light_switch = value;
>  }
> diff --git a/drivers/platform/x86/eeepc-laptop.c b/drivers/platform/x86/eeepc-laptop.c
> index 8cdf315f9730..09f93eb49230 100644
> --- a/drivers/platform/x86/eeepc-laptop.c
> +++ b/drivers/platform/x86/eeepc-laptop.c
> @@ -585,7 +585,7 @@ static void eeepc_rfkill_hotplug(struct eeepc_laptop *eeepc, acpi_handle handle)
>
>         port = acpi_get_pci_dev(handle);
>         if (!port) {
> -               pr_warning("Unable to find port\n");
> +               pr_warn("Unable to find port\n");
>                 goto out_unlock;
>         }
>
> diff --git a/drivers/platform/x86/intel_oaktrail.c b/drivers/platform/x86/intel_oaktrail.c
> index 6aa33c4a809f..133b2f04643d 100644
> --- a/drivers/platform/x86/intel_oaktrail.c
> +++ b/drivers/platform/x86/intel_oaktrail.c
> @@ -257,7 +257,7 @@ static int oaktrail_backlight_init(void)
>
>         if (IS_ERR(bd)) {
>                 oaktrail_bl_device = NULL;
> -               pr_warning("Unable to register backlight device\n");
> +               pr_warn("Unable to register backlight device\n");
>                 return PTR_ERR(bd);
>         }
>
> @@ -327,20 +327,20 @@ static int __init oaktrail_init(void)
>
>         ret = platform_driver_register(&oaktrail_driver);
>         if (ret) {
> -               pr_warning("Unable to register platform driver\n");
> +               pr_warn("Unable to register platform driver\n");
>                 goto err_driver_reg;
>         }
>
>         oaktrail_device = platform_device_alloc(DRIVER_NAME, -1);
>         if (!oaktrail_device) {
> -               pr_warning("Unable to allocate platform device\n");
> +               pr_warn("Unable to allocate platform device\n");
>                 ret = -ENOMEM;
>                 goto err_device_alloc;
>         }
>
>         ret = platform_device_add(oaktrail_device);
>         if (ret) {
> -               pr_warning("Unable to add platform device\n");
> +               pr_warn("Unable to add platform device\n");
>                 goto err_device_add;
>         }
>
> @@ -352,7 +352,7 @@ static int __init oaktrail_init(void)
>
>         ret = oaktrail_rfkill_init();
>         if (ret) {
> -               pr_warning("Setup rfkill failed\n");
> +               pr_warn("Setup rfkill failed\n");
>                 goto err_rfkill;
>         }
>
> --
> 2.10.0.rc2.1.g053435c
>



-- 
With Best Regards,
Andy Shevchenko

  reply	other threads:[~2017-02-17  7:45 UTC|newest]

Thread overview: 157+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-02-17  7:11 [PATCH 00/35] treewide trivial patches converting pr_warning to pr_warn Joe Perches
2017-02-17  7:11 ` Joe Perches
2017-02-17  7:11 ` Joe Perches
2017-02-17  7:11 ` Joe Perches
2017-02-17  7:11 ` Joe Perches
2017-02-17  7:11 ` [PATCH 01/35] alpha: Convert remaining uses of " Joe Perches
2017-02-17  7:11 ` [PATCH 02/35] ARM: ep93xx: " Joe Perches
2017-02-17  7:11   ` Joe Perches
2017-02-17 16:26   ` Hartley Sweeten
2017-02-17 16:26     ` Hartley Sweeten
2017-02-17  7:11 ` [PATCH 03/35] arm64: " Joe Perches
2017-02-17  7:11   ` Joe Perches
2017-02-17 10:52   ` Mark Rutland
2017-02-17 10:52     ` Mark Rutland
2017-02-17  7:11 ` [PATCH 04/35] arch/blackfin: " Joe Perches
2017-02-17  7:11 ` [PATCH 05/35] ia64: Convert remaining use " Joe Perches
2017-02-17  7:11   ` Joe Perches
2017-02-17  7:11 ` [PATCH 06/35] powerpc: Convert remaining uses " Joe Perches
2017-02-20  4:40   ` Michael Ellerman
2017-02-20  4:43     ` Joe Perches
2017-02-20  4:43       ` Joe Perches
2017-02-20 17:25   ` Geoff Levand
2017-02-17  7:11 ` [PATCH 07/35] sh: " Joe Perches
2017-02-17  7:11   ` Joe Perches
2017-02-17  7:11 ` [PATCH 08/35] sparc: Convert remaining use " Joe Perches
2017-02-17  7:11   ` Joe Perches
2017-02-17  8:39   ` Sam Ravnborg
2017-02-17  8:39     ` Sam Ravnborg
2017-02-17 15:20   ` David Miller
2017-02-17 15:20     ` David Miller
2017-02-17  7:11 ` [PATCH 09/35] x86: Convert remaining uses " Joe Perches
2017-02-17  7:11   ` Joe Perches
2017-02-17  7:46   ` Pekka Paalanen
2017-02-17  7:46     ` Pekka Paalanen
2017-02-17  7:46   ` Pekka Paalanen
2017-02-17  8:06   ` Juergen Gross
2017-02-17  8:06   ` Juergen Gross
2017-02-17 11:17   ` Thomas Gleixner
2017-02-17 11:17   ` Thomas Gleixner
2017-02-17 14:07   ` Robert Richter
2017-02-17 14:07   ` Robert Richter
2017-02-17 15:01   ` Steven Rostedt
2017-02-17 15:01     ` Steven Rostedt
2017-02-17 15:01   ` Steven Rostedt
2017-02-21  1:12   ` Adan Hawthorn
2017-02-21  1:12   ` Adan Hawthorn
2017-02-17  7:11 ` [PATCH 10/35] drivers/acpi: " Joe Perches
2017-02-17  7:11 ` [PATCH 11/35] block/drbd: " Joe Perches
2017-02-17  7:11 ` [PATCH 12/35] gdrom: " Joe Perches
2017-02-17  7:11 ` [PATCH 13/35] drivers/char: Convert remaining use " Joe Perches
2017-02-17  7:53   ` Amit Shah
2017-02-17  7:53   ` Amit Shah
2017-02-17  7:11 ` Joe Perches
2017-02-17  7:11 ` [PATCH 14/35] clocksource: " Joe Perches
2017-02-17  7:11 ` [PATCH 15/35] drivers/crypto: Convert remaining uses " Joe Perches
2017-02-17  7:11 ` [PATCH 16/35] fmc: Convert remaining use " Joe Perches
2017-02-17  7:11 ` [PATCH 17/35] drivers/gpu: Convert remaining uses " Joe Perches
2017-02-17  7:11   ` Joe Perches
2017-02-17 14:22   ` Christian König
2017-02-17 14:22     ` Christian König
2017-02-18  5:03     ` Edward O'Callaghan
2017-02-18  5:03       ` Edward O'Callaghan
2017-02-23 15:02       ` Alex Deucher
2017-02-23 15:02         ` Alex Deucher
2017-02-17  7:11 ` [PATCH 18/35] drivers/ide: " Joe Perches
2017-02-17 15:20   ` David Miller
2017-02-17  7:11 ` [PATCH 19/35] drivers/input: " Joe Perches
2017-02-17  7:11 ` [PATCH 20/35] drivers/isdn: " Joe Perches
2017-02-17  8:49   ` Paul Bolle
2017-02-17  7:11 ` [PATCH 21/35] drivers/macintosh: " Joe Perches
2017-02-17  7:11 ` [PATCH 22/35] drivers/media: Convert remaining use " Joe Perches
2017-02-17  7:11 ` [PATCH 23/35] drivers/mfd: Convert remaining uses " Joe Perches
2017-02-17  7:11   ` Joe Perches
2017-03-14 14:04   ` Lee Jones
2017-03-14 14:04     ` Lee Jones
2017-03-14 14:04     ` Lee Jones
2017-03-14 17:17     ` Joe Perches
2017-03-14 17:17       ` Joe Perches
2017-03-15 12:23       ` Lee Jones
2017-03-15 12:23         ` Lee Jones
2017-03-15 12:23         ` Lee Jones
2017-03-15 14:17         ` Joe Perches
2017-03-15 14:17           ` Joe Perches
2017-03-15 14:17           ` Joe Perches
2017-03-23 10:52   ` Lee Jones
2017-03-23 10:52     ` Lee Jones
2017-02-17  7:11 ` [PATCH 24/35] drivers/mtd: " Joe Perches
2017-04-19 20:11   ` Brian Norris
2017-02-17  7:11 ` [PATCH 25/35] drivers/of: " Joe Perches
2017-02-23 16:00   ` Rob Herring
2017-02-17  7:11 ` [PATCH 26/35] drivers/oprofile: " Joe Perches
2017-02-17 14:07   ` Robert Richter
2017-02-17  7:11 ` [PATCH 27/35] drivers/platform: " Joe Perches
2017-02-17  7:45   ` Andy Shevchenko [this message]
2017-02-17  7:11 ` [PATCH 28/35] drivers/rapidio: Convert remaining use " Joe Perches
2017-02-17  7:11 ` [PATCH 29/35] drivers/scsi: " Joe Perches
2017-02-17  7:11 ` [PATCH 31/35] drivers/tty: Convert remaining uses " Joe Perches
2017-02-17  7:11 ` [PATCH 32/35] drivers/video: " Joe Perches
2017-02-17  7:11   ` Joe Perches
2017-03-21 15:17   ` Bartlomiej Zolnierkiewicz
2017-03-21 15:17     ` Bartlomiej Zolnierkiewicz
2017-02-17  7:11 ` [PATCH 33/35] kernel/trace: " Joe Perches
2017-02-17 14:59   ` Steven Rostedt
2017-02-17  7:11 ` [PATCH 34/35] lib: " Joe Perches
2017-02-17  7:11 ` [PATCH 35/35] sound/soc: " Joe Perches
2017-02-17  7:11   ` Joe Perches
2017-02-17 20:28   ` Nicolin Chen
2017-02-17 20:28     ` Nicolin Chen
2017-02-17 23:48     ` Mark Brown
2017-02-17 23:48       ` Mark Brown
2017-02-17 23:57       ` Nicolin Chen
2017-02-18  0:20         ` Joe Perches
2017-02-18  0:20           ` Joe Perches
2017-02-20 19:06           ` Mark Brown
2017-02-20 19:06             ` Mark Brown
2017-02-17 12:27 ` [PATCH 00/35] treewide trivial patches converting " Rafael J. Wysocki
2017-02-17 12:27 ` Rafael J. Wysocki
2017-02-23 15:28 ` Rob Herring
2017-02-23 15:28 ` Rob Herring
     [not found] ` <cover.1487314666.git.joe-6d6DIl74uiNBDgjK7y7TUQ@public.gmane.org>
2017-02-17 12:27   ` Rafael J. Wysocki
2017-02-17 12:27     ` Rafael J. Wysocki
2017-02-17 12:27     ` Rafael J. Wysocki
2017-02-17 12:27     ` Rafael J. Wysocki
2017-02-17 12:27     ` Rafael J. Wysocki
2017-02-17 12:37     ` Geert Uytterhoeven
2017-02-17 12:37     ` Geert Uytterhoeven
2017-02-17 12:37       ` Geert Uytterhoeven
2017-02-17 12:37       ` Geert Uytterhoeven
2017-02-23 15:28   ` Rob Herring
2017-02-23 15:28     ` Rob Herring
2017-02-23 15:28     ` Rob Herring
2017-02-23 15:28     ` Rob Herring
2017-02-23 15:28     ` Rob Herring
2017-02-23 17:18     ` Joe Perches
2017-02-23 17:18     ` Joe Perches
2017-02-23 17:18       ` Joe Perches
2017-02-23 17:18       ` Joe Perches
2017-02-23 17:18       ` Joe Perches
2017-02-23 17:18       ` Joe Perches
2017-02-23 17:18       ` Joe Perches
2017-02-23 17:41       ` Emil Velikov
2017-02-23 17:41       ` Emil Velikov
2017-02-23 17:41         ` Emil Velikov
2017-02-23 17:41         ` Emil Velikov
2017-02-23 17:41         ` Emil Velikov
2017-02-23 17:41         ` Emil Velikov
2017-02-23 17:53         ` Joe Perches
2017-02-23 17:53         ` Joe Perches
2017-02-23 17:53           ` Joe Perches
2017-02-23 17:53           ` Joe Perches
2017-02-23 17:53           ` Joe Perches
2017-02-23 17:53           ` Joe Perches
2017-02-23 17:53           ` Joe Perches
2017-02-23 17:53           ` Joe Perches
2017-02-23 17:53         ` Joe Perches
2017-02-17  7:11 [PATCH 30/35] drivers/sh: Convert remaining use of " Joe Perches
2017-02-17  7:11 ` Joe Perches

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAHp75VeytUj9AQz0ROPvQ+VqzmbnEw2PeAY6Zqkxav+c9AZO6w@mail.gmail.com \
    --to=andy.shevchenko@gmail.com \
    --cc=acpi4asus-user@lists.sourceforge.net \
    --cc=andy@infradead.org \
    --cc=corentin.chary@gmail.com \
    --cc=dvhart@infradead.org \
    --cc=joe@perches.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=platform-driver-x86@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.