From: Joe Perches <joe@perches.com> To: Lee Jones <lee.jones@linaro.org> Cc: Linus Walleij <linus.walleij@linaro.org>, Tony Lindgren <tony@atomide.com>, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org Subject: Re: [PATCH 23/35] drivers/mfd: Convert remaining uses of pr_warning to pr_warn Date: Tue, 14 Mar 2017 10:17:48 -0700 [thread overview] Message-ID: <1489511868.2582.2.camel@perches.com> (raw) In-Reply-To: <20170314140455.umlhdbuj3grqtu6i@dell> On Tue, 2017-03-14 at 14:04 +0000, Lee Jones wrote: > On Thu, 16 Feb 2017, Joe Perches wrote: > > To enable eventual removal of pr_warning [] > > diff --git a/drivers/mfd/twl4030-power.c b/drivers/mfd/twl4030-power.c [] > > @@ -502,9 +502,7 @@ static int load_twl4030_script(const struct twl4030_power_data *pdata, > > } > > if (tscript->flags & TWL4030_SLEEP_SCRIPT) { > > if (!order) > > - pr_warning("TWL4030: Bad order of scripts (sleep "\ > > - "script before wakeup) Leads to boot"\ > > - "failure on some boards\n"); > > + pr_warn("TWL4030: Bad order of scripts (sleep script before wakeup) Leads to boot failure on some boards\n"); > > Is 80 chars considered the lessor sin? Splitting logging messages into multiple lines is non preferred. Documentation/process/coding-style.rst: Breaking long lines and strings: never break user-visible strings such as printk messages, because that breaks the ability to grep for them.
WARNING: multiple messages have this Message-ID (diff)
From: joe@perches.com (Joe Perches) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH 23/35] drivers/mfd: Convert remaining uses of pr_warning to pr_warn Date: Tue, 14 Mar 2017 10:17:48 -0700 [thread overview] Message-ID: <1489511868.2582.2.camel@perches.com> (raw) In-Reply-To: <20170314140455.umlhdbuj3grqtu6i@dell> On Tue, 2017-03-14 at 14:04 +0000, Lee Jones wrote: > On Thu, 16 Feb 2017, Joe Perches wrote: > > To enable eventual removal of pr_warning [] > > diff --git a/drivers/mfd/twl4030-power.c b/drivers/mfd/twl4030-power.c [] > > @@ -502,9 +502,7 @@ static int load_twl4030_script(const struct twl4030_power_data *pdata, > > } > > if (tscript->flags & TWL4030_SLEEP_SCRIPT) { > > if (!order) > > - pr_warning("TWL4030: Bad order of scripts (sleep "\ > > - "script before wakeup) Leads to boot"\ > > - "failure on some boards\n"); > > + pr_warn("TWL4030: Bad order of scripts (sleep script before wakeup) Leads to boot failure on some boards\n"); > > Is 80 chars considered the lessor sin? Splitting logging messages into multiple lines is non preferred. Documentation/process/coding-style.rst: Breaking long lines and strings: never break user-visible strings such as printk messages, because that breaks the ability to grep for them.
next prev parent reply other threads:[~2017-03-14 17:18 UTC|newest] Thread overview: 157+ messages / expand[flat|nested] mbox.gz Atom feed top 2017-02-17 7:11 [PATCH 00/35] treewide trivial patches converting pr_warning to pr_warn Joe Perches 2017-02-17 7:11 ` Joe Perches 2017-02-17 7:11 ` Joe Perches 2017-02-17 7:11 ` Joe Perches 2017-02-17 7:11 ` Joe Perches 2017-02-17 7:11 ` [PATCH 01/35] alpha: Convert remaining uses of " Joe Perches 2017-02-17 7:11 ` [PATCH 02/35] ARM: ep93xx: " Joe Perches 2017-02-17 7:11 ` Joe Perches 2017-02-17 16:26 ` Hartley Sweeten 2017-02-17 16:26 ` Hartley Sweeten 2017-02-17 7:11 ` [PATCH 03/35] arm64: " Joe Perches 2017-02-17 7:11 ` Joe Perches 2017-02-17 10:52 ` Mark Rutland 2017-02-17 10:52 ` Mark Rutland 2017-02-17 7:11 ` [PATCH 04/35] arch/blackfin: " Joe Perches 2017-02-17 7:11 ` [PATCH 05/35] ia64: Convert remaining use " Joe Perches 2017-02-17 7:11 ` Joe Perches 2017-02-17 7:11 ` [PATCH 06/35] powerpc: Convert remaining uses " Joe Perches 2017-02-20 4:40 ` Michael Ellerman 2017-02-20 4:43 ` Joe Perches 2017-02-20 4:43 ` Joe Perches 2017-02-20 17:25 ` Geoff Levand 2017-02-17 7:11 ` [PATCH 07/35] sh: " Joe Perches 2017-02-17 7:11 ` Joe Perches 2017-02-17 7:11 ` [PATCH 08/35] sparc: Convert remaining use " Joe Perches 2017-02-17 7:11 ` Joe Perches 2017-02-17 8:39 ` Sam Ravnborg 2017-02-17 8:39 ` Sam Ravnborg 2017-02-17 15:20 ` David Miller 2017-02-17 15:20 ` David Miller 2017-02-17 7:11 ` [PATCH 09/35] x86: Convert remaining uses " Joe Perches 2017-02-17 7:11 ` Joe Perches 2017-02-17 7:46 ` Pekka Paalanen 2017-02-17 7:46 ` Pekka Paalanen 2017-02-17 7:46 ` Pekka Paalanen 2017-02-17 8:06 ` Juergen Gross 2017-02-17 8:06 ` Juergen Gross 2017-02-17 11:17 ` Thomas Gleixner 2017-02-17 11:17 ` Thomas Gleixner 2017-02-17 14:07 ` Robert Richter 2017-02-17 14:07 ` Robert Richter 2017-02-17 15:01 ` Steven Rostedt 2017-02-17 15:01 ` Steven Rostedt 2017-02-17 15:01 ` Steven Rostedt 2017-02-21 1:12 ` Adan Hawthorn 2017-02-21 1:12 ` Adan Hawthorn 2017-02-17 7:11 ` [PATCH 10/35] drivers/acpi: " Joe Perches 2017-02-17 7:11 ` [PATCH 11/35] block/drbd: " Joe Perches 2017-02-17 7:11 ` [PATCH 12/35] gdrom: " Joe Perches 2017-02-17 7:11 ` [PATCH 13/35] drivers/char: Convert remaining use " Joe Perches 2017-02-17 7:53 ` Amit Shah 2017-02-17 7:53 ` Amit Shah 2017-02-17 7:11 ` Joe Perches 2017-02-17 7:11 ` [PATCH 14/35] clocksource: " Joe Perches 2017-02-17 7:11 ` [PATCH 15/35] drivers/crypto: Convert remaining uses " Joe Perches 2017-02-17 7:11 ` [PATCH 16/35] fmc: Convert remaining use " Joe Perches 2017-02-17 7:11 ` [PATCH 17/35] drivers/gpu: Convert remaining uses " Joe Perches 2017-02-17 7:11 ` Joe Perches 2017-02-17 14:22 ` Christian König 2017-02-17 14:22 ` Christian König 2017-02-18 5:03 ` Edward O'Callaghan 2017-02-18 5:03 ` Edward O'Callaghan 2017-02-23 15:02 ` Alex Deucher 2017-02-23 15:02 ` Alex Deucher 2017-02-17 7:11 ` [PATCH 18/35] drivers/ide: " Joe Perches 2017-02-17 15:20 ` David Miller 2017-02-17 7:11 ` [PATCH 19/35] drivers/input: " Joe Perches 2017-02-17 7:11 ` [PATCH 20/35] drivers/isdn: " Joe Perches 2017-02-17 8:49 ` Paul Bolle 2017-02-17 7:11 ` [PATCH 21/35] drivers/macintosh: " Joe Perches 2017-02-17 7:11 ` [PATCH 22/35] drivers/media: Convert remaining use " Joe Perches 2017-02-17 7:11 ` [PATCH 23/35] drivers/mfd: Convert remaining uses " Joe Perches 2017-02-17 7:11 ` Joe Perches 2017-03-14 14:04 ` Lee Jones 2017-03-14 14:04 ` Lee Jones 2017-03-14 14:04 ` Lee Jones 2017-03-14 17:17 ` Joe Perches [this message] 2017-03-14 17:17 ` Joe Perches 2017-03-15 12:23 ` Lee Jones 2017-03-15 12:23 ` Lee Jones 2017-03-15 12:23 ` Lee Jones 2017-03-15 14:17 ` Joe Perches 2017-03-15 14:17 ` Joe Perches 2017-03-15 14:17 ` Joe Perches 2017-03-23 10:52 ` Lee Jones 2017-03-23 10:52 ` Lee Jones 2017-02-17 7:11 ` [PATCH 24/35] drivers/mtd: " Joe Perches 2017-04-19 20:11 ` Brian Norris 2017-02-17 7:11 ` [PATCH 25/35] drivers/of: " Joe Perches 2017-02-23 16:00 ` Rob Herring 2017-02-17 7:11 ` [PATCH 26/35] drivers/oprofile: " Joe Perches 2017-02-17 14:07 ` Robert Richter 2017-02-17 7:11 ` [PATCH 27/35] drivers/platform: " Joe Perches 2017-02-17 7:45 ` Andy Shevchenko 2017-02-17 7:11 ` [PATCH 28/35] drivers/rapidio: Convert remaining use " Joe Perches 2017-02-17 7:11 ` [PATCH 29/35] drivers/scsi: " Joe Perches 2017-02-17 7:11 ` [PATCH 31/35] drivers/tty: Convert remaining uses " Joe Perches 2017-02-17 7:11 ` [PATCH 32/35] drivers/video: " Joe Perches 2017-02-17 7:11 ` Joe Perches 2017-03-21 15:17 ` Bartlomiej Zolnierkiewicz 2017-03-21 15:17 ` Bartlomiej Zolnierkiewicz 2017-02-17 7:11 ` [PATCH 33/35] kernel/trace: " Joe Perches 2017-02-17 14:59 ` Steven Rostedt 2017-02-17 7:11 ` [PATCH 34/35] lib: " Joe Perches 2017-02-17 7:11 ` [PATCH 35/35] sound/soc: " Joe Perches 2017-02-17 7:11 ` Joe Perches 2017-02-17 20:28 ` Nicolin Chen 2017-02-17 20:28 ` Nicolin Chen 2017-02-17 23:48 ` Mark Brown 2017-02-17 23:48 ` Mark Brown 2017-02-17 23:57 ` Nicolin Chen 2017-02-18 0:20 ` Joe Perches 2017-02-18 0:20 ` Joe Perches 2017-02-20 19:06 ` Mark Brown 2017-02-20 19:06 ` Mark Brown 2017-02-17 12:27 ` [PATCH 00/35] treewide trivial patches converting " Rafael J. Wysocki 2017-02-17 12:27 ` Rafael J. Wysocki 2017-02-23 15:28 ` Rob Herring 2017-02-23 15:28 ` Rob Herring [not found] ` <cover.1487314666.git.joe-6d6DIl74uiNBDgjK7y7TUQ@public.gmane.org> 2017-02-17 12:27 ` Rafael J. Wysocki 2017-02-17 12:27 ` Rafael J. Wysocki 2017-02-17 12:27 ` Rafael J. Wysocki 2017-02-17 12:27 ` Rafael J. Wysocki 2017-02-17 12:27 ` Rafael J. Wysocki 2017-02-17 12:37 ` Geert Uytterhoeven 2017-02-17 12:37 ` Geert Uytterhoeven 2017-02-17 12:37 ` Geert Uytterhoeven 2017-02-17 12:37 ` Geert Uytterhoeven 2017-02-23 15:28 ` Rob Herring 2017-02-23 15:28 ` Rob Herring 2017-02-23 15:28 ` Rob Herring 2017-02-23 15:28 ` Rob Herring 2017-02-23 15:28 ` Rob Herring 2017-02-23 17:18 ` Joe Perches 2017-02-23 17:18 ` Joe Perches 2017-02-23 17:18 ` Joe Perches 2017-02-23 17:18 ` Joe Perches 2017-02-23 17:18 ` Joe Perches 2017-02-23 17:18 ` Joe Perches 2017-02-23 17:18 ` Joe Perches 2017-02-23 17:41 ` Emil Velikov 2017-02-23 17:41 ` Emil Velikov 2017-02-23 17:41 ` Emil Velikov 2017-02-23 17:41 ` Emil Velikov 2017-02-23 17:41 ` Emil Velikov 2017-02-23 17:41 ` Emil Velikov 2017-02-23 17:53 ` Joe Perches 2017-02-23 17:53 ` Joe Perches 2017-02-23 17:53 ` Joe Perches 2017-02-23 17:53 ` Joe Perches 2017-02-23 17:53 ` Joe Perches 2017-02-23 17:53 ` Joe Perches 2017-02-23 17:53 ` Joe Perches 2017-02-23 17:53 ` Joe Perches 2017-02-23 17:53 ` Joe Perches 2017-02-17 7:11 [PATCH 30/35] drivers/sh: Convert remaining use of " Joe Perches 2017-02-17 7:11 ` Joe Perches
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=1489511868.2582.2.camel@perches.com \ --to=joe@perches.com \ --cc=lee.jones@linaro.org \ --cc=linus.walleij@linaro.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-omap@vger.kernel.org \ --cc=tony@atomide.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.