* [PATCH][V2] gpiolib: remove unused variable 'i'
@ 2017-05-30 11:02 ` Colin King
0 siblings, 0 replies; 4+ messages in thread
From: Colin King @ 2017-05-30 11:02 UTC (permalink / raw)
To: Linus Walleij, linux-gpio; +Cc: kernel-janitors, linux-kernel
From: Colin Ian King <colin.king@canonical.com>
Fixes smatch warning:unused variable 'i' [-Wunused-variable]
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
drivers/gpio/gpiolib.c | 2 --
sound/soc/generic/audio-graph-scu-card.c | 2 +-
2 files changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/gpio/gpiolib.c b/drivers/gpio/gpiolib.c
index be8097097326..62ffb4e293d2 100644
--- a/drivers/gpio/gpiolib.c
+++ b/drivers/gpio/gpiolib.c
@@ -1471,8 +1471,6 @@ static struct gpio_chip *find_chip_by_name(const char *name)
static int gpiochip_irqchip_init_valid_mask(struct gpio_chip *gpiochip)
{
- int i;
-
if (!gpiochip->irq_need_valid_mask)
return 0;
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH][V2] gpiolib: remove unused variable 'i'
@ 2017-05-30 11:02 ` Colin King
0 siblings, 0 replies; 4+ messages in thread
From: Colin King @ 2017-05-30 11:02 UTC (permalink / raw)
To: Linus Walleij, linux-gpio; +Cc: kernel-janitors, linux-kernel
From: Colin Ian King <colin.king@canonical.com>
Fixes smatch warning:unused variable 'i' [-Wunused-variable]
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
drivers/gpio/gpiolib.c | 2 --
sound/soc/generic/audio-graph-scu-card.c | 2 +-
2 files changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/gpio/gpiolib.c b/drivers/gpio/gpiolib.c
index be8097097326..62ffb4e293d2 100644
--- a/drivers/gpio/gpiolib.c
+++ b/drivers/gpio/gpiolib.c
@@ -1471,8 +1471,6 @@ static struct gpio_chip *find_chip_by_name(const char *name)
static int gpiochip_irqchip_init_valid_mask(struct gpio_chip *gpiochip)
{
- int i;
-
if (!gpiochip->irq_need_valid_mask)
return 0;
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH][V2] gpiolib: remove unused variable 'i'
2017-05-30 11:02 ` Colin King
@ 2017-05-30 13:12 ` Andy Shevchenko
-1 siblings, 0 replies; 4+ messages in thread
From: Andy Shevchenko @ 2017-05-30 13:12 UTC (permalink / raw)
To: Colin King; +Cc: Linus Walleij, linux-gpio, kernel-janitors, linux-kernel
On Tue, May 30, 2017 at 2:02 PM, Colin King <colin.king@canonical.com> wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> Fixes smatch warning:unused variable 'i' [-Wunused-variable]
Arnd was faster :)
https://lkml.org/lkml/2017/5/30/224
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
> drivers/gpio/gpiolib.c | 2 --
> sound/soc/generic/audio-graph-scu-card.c | 2 +-
> 2 files changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/gpio/gpiolib.c b/drivers/gpio/gpiolib.c
> index be8097097326..62ffb4e293d2 100644
> --- a/drivers/gpio/gpiolib.c
> +++ b/drivers/gpio/gpiolib.c
> @@ -1471,8 +1471,6 @@ static struct gpio_chip *find_chip_by_name(const char *name)
>
> static int gpiochip_irqchip_init_valid_mask(struct gpio_chip *gpiochip)
> {
> - int i;
> -
> if (!gpiochip->irq_need_valid_mask)
> return 0;
>
>
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH][V2] gpiolib: remove unused variable 'i'
@ 2017-05-30 13:12 ` Andy Shevchenko
0 siblings, 0 replies; 4+ messages in thread
From: Andy Shevchenko @ 2017-05-30 13:12 UTC (permalink / raw)
To: Colin King; +Cc: Linus Walleij, linux-gpio, kernel-janitors, linux-kernel
On Tue, May 30, 2017 at 2:02 PM, Colin King <colin.king@canonical.com> wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> Fixes smatch warning:unused variable 'i' [-Wunused-variable]
Arnd was faster :)
https://lkml.org/lkml/2017/5/30/224
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
> drivers/gpio/gpiolib.c | 2 --
> sound/soc/generic/audio-graph-scu-card.c | 2 +-
> 2 files changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/gpio/gpiolib.c b/drivers/gpio/gpiolib.c
> index be8097097326..62ffb4e293d2 100644
> --- a/drivers/gpio/gpiolib.c
> +++ b/drivers/gpio/gpiolib.c
> @@ -1471,8 +1471,6 @@ static struct gpio_chip *find_chip_by_name(const char *name)
>
> static int gpiochip_irqchip_init_valid_mask(struct gpio_chip *gpiochip)
> {
> - int i;
> -
> if (!gpiochip->irq_need_valid_mask)
> return 0;
>
>
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2017-05-30 13:12 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-05-30 11:02 [PATCH][V2] gpiolib: remove unused variable 'i' Colin King
2017-05-30 11:02 ` Colin King
2017-05-30 13:12 ` Andy Shevchenko
2017-05-30 13:12 ` Andy Shevchenko
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.