All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] intel_punit_ipc: include linux/io.h
@ 2018-08-17  9:51 ` Arnd Bergmann
  0 siblings, 0 replies; 4+ messages in thread
From: Arnd Bergmann @ 2018-08-17  9:51 UTC (permalink / raw)
  To: Zha Qipeng, Darren Hart, Andy Shevchenko
  Cc: Arnd Bergmann, Nicolai Stange, Thomas Gleixner,
	Michael S. Tsirkin, Kuppuswamy Sathyanarayanan, Lad, Prabhakar,
	platform-driver-x86, linux-kernel

After we stop including linux/irq.h implicitly, we don't see linux/io.h
in intel_punit_ipc.c, leading to a build failure:

drivers/platform/x86/intel_punit_ipc.c: In function 'ipc_read_status':
drivers/platform/x86/intel_punit_ipc.c:55:9: error: implicit declaration of function 'readl' [-Werror=implicit-function-declaration]

Add back the include that is clearly needed.

Fixes: 447ae3166702 ("x86: Don't include linux/irq.h from asm/hardirq.h")
Cc: Nicolai Stange <nstange@suse.de>
Cc: Thomas Gleixner <tglx@linutronix.de>
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
 drivers/platform/x86/intel_punit_ipc.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/platform/x86/intel_punit_ipc.c b/drivers/platform/x86/intel_punit_ipc.c
index f1afc0ebbc68..2efeab650345 100644
--- a/drivers/platform/x86/intel_punit_ipc.c
+++ b/drivers/platform/x86/intel_punit_ipc.c
@@ -18,6 +18,7 @@
 #include <linux/bitops.h>
 #include <linux/device.h>
 #include <linux/interrupt.h>
+#include <linux/io.h>
 #include <linux/platform_device.h>
 #include <asm/intel_punit_ipc.h>
 
-- 
2.18.0


^ permalink raw reply related	[flat|nested] 4+ messages in thread
* [PATCH] intel_punit_ipc: include linux/io.h
@ 2018-08-17  9:51 ` Arnd Bergmann
  0 siblings, 0 replies; 4+ messages in thread
From: Arnd Bergmann @ 2018-08-17  9:51 UTC (permalink / raw)
  To: Zha Qipeng, Darren Hart, Andy Shevchenko
  Cc: Arnd Bergmann, Nicolai Stange, Thomas Gleixner,
	Michael S. Tsirkin, Kuppuswamy Sathyanarayanan, Lad, Prabhakar,
	platform-driver-x86, linux-kernel

After we stop including linux/irq.h implicitly, we don't see linux/io.h
in intel_punit_ipc.c, leading to a build failure:

drivers/platform/x86/intel_punit_ipc.c: In function 'ipc_read_status':
drivers/platform/x86/intel_punit_ipc.c:55:9: error: implicit declaration of function 'readl' [-Werror=implicit-function-declaration]

Add back the include that is clearly needed.

Fixes: 447ae3166702 ("x86: Don't include linux/irq.h from asm/hardirq.h")
Cc: Nicolai Stange <nstange@suse.de>
Cc: Thomas Gleixner <tglx@linutronix.de>
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
 drivers/platform/x86/intel_punit_ipc.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/platform/x86/intel_punit_ipc.c b/drivers/platform/x86/intel_punit_ipc.c
index f1afc0ebbc68..2efeab650345 100644
--- a/drivers/platform/x86/intel_punit_ipc.c
+++ b/drivers/platform/x86/intel_punit_ipc.c
@@ -18,6 +18,7 @@
 #include <linux/bitops.h>
 #include <linux/device.h>
 #include <linux/interrupt.h>
+#include <linux/io.h>
 #include <linux/platform_device.h>
 #include <asm/intel_punit_ipc.h>
 
-- 
2.18.0

^ permalink raw reply related	[flat|nested] 4+ messages in thread
* Re: [PATCH] intel_punit_ipc: include linux/io.h
  2018-08-17  9:51 ` Arnd Bergmann
@ 2018-08-17 10:48   ` Andy Shevchenko
  -1 siblings, 0 replies; 4+ messages in thread
From: Andy Shevchenko @ 2018-08-17 10:48 UTC (permalink / raw)
  To: Arnd Bergmann, Randy Dunlap
  Cc: Zha Qipeng, Darren Hart, Andy Shevchenko, Nicolai Stange,
	Thomas Gleixner, Michael S. Tsirkin, Kuppuswamy Sathyanarayanan,
	Lad, Prabhakar, Platform Driver, Linux Kernel Mailing List

On Fri, Aug 17, 2018 at 12:51 PM, Arnd Bergmann <arnd@arndb.de> wrote:
> After we stop including linux/irq.h implicitly, we don't see linux/io.h
> in intel_punit_ipc.c, leading to a build failure:
>
> drivers/platform/x86/intel_punit_ipc.c: In function 'ipc_read_status':
> drivers/platform/x86/intel_punit_ipc.c:55:9: error: implicit declaration of function 'readl' [-Werror=implicit-function-declaration]
>
> Add back the include that is clearly needed.
>

Thanks, Randy already sent a patch

> Fixes: 447ae3166702 ("x86: Don't include linux/irq.h from asm/hardirq.h")
> Cc: Nicolai Stange <nstange@suse.de>
> Cc: Thomas Gleixner <tglx@linutronix.de>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
>  drivers/platform/x86/intel_punit_ipc.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/platform/x86/intel_punit_ipc.c b/drivers/platform/x86/intel_punit_ipc.c
> index f1afc0ebbc68..2efeab650345 100644
> --- a/drivers/platform/x86/intel_punit_ipc.c
> +++ b/drivers/platform/x86/intel_punit_ipc.c
> @@ -18,6 +18,7 @@
>  #include <linux/bitops.h>
>  #include <linux/device.h>
>  #include <linux/interrupt.h>
> +#include <linux/io.h>
>  #include <linux/platform_device.h>
>  #include <asm/intel_punit_ipc.h>
>
> --
> 2.18.0
>



-- 
With Best Regards,
Andy Shevchenko

^ permalink raw reply	[flat|nested] 4+ messages in thread
* Re: [PATCH] intel_punit_ipc: include linux/io.h
@ 2018-08-17 10:48   ` Andy Shevchenko
  0 siblings, 0 replies; 4+ messages in thread
From: Andy Shevchenko @ 2018-08-17 10:48 UTC (permalink / raw)
  To: Arnd Bergmann, Randy Dunlap
  Cc: Zha Qipeng, Darren Hart, Andy Shevchenko, Nicolai Stange,
	Thomas Gleixner, Michael S. Tsirkin, Kuppuswamy Sathyanarayanan,
	Lad, Prabhakar, Platform Driver, Linux Kernel Mailing List

On Fri, Aug 17, 2018 at 12:51 PM, Arnd Bergmann <arnd@arndb.de> wrote:
> After we stop including linux/irq.h implicitly, we don't see linux/io.h
> in intel_punit_ipc.c, leading to a build failure:
>
> drivers/platform/x86/intel_punit_ipc.c: In function 'ipc_read_status':
> drivers/platform/x86/intel_punit_ipc.c:55:9: error: implicit declaration of function 'readl' [-Werror=implicit-function-declaration]
>
> Add back the include that is clearly needed.
>

Thanks, Randy already sent a patch

> Fixes: 447ae3166702 ("x86: Don't include linux/irq.h from asm/hardirq.h")
> Cc: Nicolai Stange <nstange@suse.de>
> Cc: Thomas Gleixner <tglx@linutronix.de>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
>  drivers/platform/x86/intel_punit_ipc.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/platform/x86/intel_punit_ipc.c b/drivers/platform/x86/intel_punit_ipc.c
> index f1afc0ebbc68..2efeab650345 100644
> --- a/drivers/platform/x86/intel_punit_ipc.c
> +++ b/drivers/platform/x86/intel_punit_ipc.c
> @@ -18,6 +18,7 @@
>  #include <linux/bitops.h>
>  #include <linux/device.h>
>  #include <linux/interrupt.h>
> +#include <linux/io.h>
>  #include <linux/platform_device.h>
>  #include <asm/intel_punit_ipc.h>
>
> --
> 2.18.0
>



-- 
With Best Regards,
Andy Shevchenko

^ permalink raw reply	[flat|nested] 4+ messages in thread
end of thread, other threads:[~2018-08-17 10:48 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-08-17  9:51 [PATCH] intel_punit_ipc: include linux/io.h Arnd Bergmann
2018-08-17  9:51 ` Arnd Bergmann
2018-08-17 10:48 ` Andy Shevchenko
2018-08-17 10:48   ` Andy Shevchenko

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.