[PATCH v2] platform/x86: pmc_atom: Add Siemens SIMATIC IPC227E to critclk_systems DMI table

[PATCH v2] platform/x86: pmc_atom: Add Siemens SIMATIC IPC227E to critclk_systems DMI table

[Jan Kiszka]

From: Jan Kiszka <jan.kiszka@siemens.com>

The SIMATIC IPC227E uses the PMC clock for on-board components and gets
stuck during boot if the clock is disabled. Therefore, add this device
to the critical systems list.

Fixes: 648e921888ad ("clk: x86: Stop marking clocks as CLK_IS_CRITICAL")
Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
---

Changes in v2:
 - fixed cut-off subject line (local tooling bug...)

Should go into stable as well, down to 4.19.

 drivers/platform/x86/pmc_atom.c | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/drivers/platform/x86/pmc_atom.c b/drivers/platform/x86/pmc_atom.c
index aa53648a2214..9aca5e7ce6d0 100644
--- a/drivers/platform/x86/pmc_atom.c
+++ b/drivers/platform/x86/pmc_atom.c
@@ -415,6 +415,13 @@ static const struct dmi_system_id critclk_systems[] = {
 			DMI_MATCH(DMI_BOARD_NAME, "CB6363"),
 		},
 	},
+	{
+		.ident = "SIMATIC IPC227E",
+		.matches = {
+			DMI_MATCH(DMI_SYS_VENDOR, "SIEMENS AG"),
+			DMI_MATCH(DMI_PRODUCT_VERSION, "6ES7647-8B"),
+		},
+	},
 	{ /*sentinel*/ }
 };
 
-- 

2.16.4


-- 
Siemens AG, Corporate Technology, CT RDA IOT SES-DE
Corporate Competence Center Embedded Linux

Re: [PATCH v2] platform/x86: pmc_atom: Add Siemens SIMATIC IPC227E to critclk_systems DMI table

[Jan Kiszka]

On 04.09.19 08:42, Jan Kiszka wrote:
> From: Jan Kiszka <jan.kiszka@siemens.com>
> 
> The SIMATIC IPC227E uses the PMC clock for on-board components and gets
> stuck during boot if the clock is disabled. Therefore, add this device
> to the critical systems list.
> 
> Fixes: 648e921888ad ("clk: x86: Stop marking clocks as CLK_IS_CRITICAL")
> Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
> ---
> 
> Changes in v2:
>  - fixed cut-off subject line (local tooling bug...)
> 
> Should go into stable as well, down to 4.19.

This one is in 5.4-rc now (as ad0d315b4d4e). Is it also queued somewhere
for stable kernels? IIRC, it's generally the privilege of the subsystem
maintainer to propose formally to stable.

I've received reports from users down at 4.14 with the need for it (4.9
is unaffected). And the same applies to f110d252ae79 ("platform/x86:
pmc_atom: Add Siemens SIMATIC IPC277E to critclk_systems DMI table").

TIA!
Jan

> 
>  drivers/platform/x86/pmc_atom.c | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/drivers/platform/x86/pmc_atom.c b/drivers/platform/x86/pmc_atom.c
> index aa53648a2214..9aca5e7ce6d0 100644
> --- a/drivers/platform/x86/pmc_atom.c
> +++ b/drivers/platform/x86/pmc_atom.c
> @@ -415,6 +415,13 @@ static const struct dmi_system_id critclk_systems[] = {
>  			DMI_MATCH(DMI_BOARD_NAME, "CB6363"),
>  		},
>  	},
> +	{
> +		.ident = "SIMATIC IPC227E",
> +		.matches = {
> +			DMI_MATCH(DMI_SYS_VENDOR, "SIEMENS AG"),
> +			DMI_MATCH(DMI_PRODUCT_VERSION, "6ES7647-8B"),
> +		},
> +	},
>  	{ /*sentinel*/ }
>  };
>  
> 

-- 
Siemens AG, Corporate Technology, CT RDA IOT SES-DE
Corporate Competence Center Embedded Linux

Re: [PATCH v2] platform/x86: pmc_atom: Add Siemens SIMATIC IPC227E to critclk_systems DMI table

[Andy Shevchenko]

On Mon, Nov 4, 2019 at 6:21 PM Jan Kiszka <jan.kiszka@siemens.com> wrote:
>
> On 04.09.19 08:42, Jan Kiszka wrote:
> > From: Jan Kiszka <jan.kiszka@siemens.com>
> >
> > The SIMATIC IPC227E uses the PMC clock for on-board components and gets
> > stuck during boot if the clock is disabled. Therefore, add this device
> > to the critical systems list.
> >
> > Fixes: 648e921888ad ("clk: x86: Stop marking clocks as CLK_IS_CRITICAL")
> > Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
> > ---
> >
> > Changes in v2:
> >  - fixed cut-off subject line (local tooling bug...)
> >
> > Should go into stable as well, down to 4.19.
>
> This one is in 5.4-rc now (as ad0d315b4d4e). Is it also queued somewhere
> for stable kernels? IIRC, it's generally the privilege of the subsystem
> maintainer to propose formally to stable.

Anybody can resend for stable putting maintainer to Cc as long as the
original commit is in upstream.

Nevertheless, I just resend it.

> I've received reports from users down at 4.14 with the need for it (4.9
> is unaffected). And the same applies to f110d252ae79 ("platform/x86:
> pmc_atom: Add Siemens SIMATIC IPC277E to critclk_systems DMI table").


-- 
With Best Regards,
Andy Shevchenko