All of lore.kernel.org
 help / color / mirror / Atom feed
* Re: [Bug 212379] AMD GPIO chip IRQs stops working (ELN4690, WCOM51C7, BMA250E)
       [not found] ` <bug-212379-6385-VMOjMpWM97@https.bugzilla.kernel.org/>
@ 2021-04-26 22:04   ` Borislav Petkov
  2021-04-27 14:10     ` Andy Shevchenko
  0 siblings, 1 reply; 6+ messages in thread
From: Borislav Petkov @ 2021-04-26 22:04 UTC (permalink / raw)
  To: vectorflaredesigns, Linus Walleij; +Cc: linux-gpio, lkml

Switching to mail...

On Mon, Apr 26, 2021 at 09:04:38PM +0000, bugzilla-daemon@bugzilla.kernel.org wrote:
> https://bugzilla.kernel.org/show_bug.cgi?id=212379
> 
> --- Comment #15 from Austin Kilgore (vectorflaredesigns@gmail.com) ---
> Is this ever going to get looked at?
> 
> Did I need to @ mention someone? Honestly asking since I don't know what to do.
> I don't even know who needs to be told to take a look at this.
> 
> Like I said, if this bug report is lacking information just let me know and
> I'll test, check, or upload whatever is needed. It's really important to me
> that this gets fixed.
> 
> -- 

Grepping through the tree, "amd_gpio" sounds like
drivers/pinctrl/pinctrl-amd.c so maybe Linus might have an idea, CCed.

@Linus, the bugzilla entry has some more info on what happens.

@Austin: in the future, please do not CC everyone including the
postmaster on your bug. Now you're mass-spamming 50+ people
unnecessarily.

Thx.

-- 
Regards/Gruss,
    Boris.

https://people.kernel.org/tglx/notes-about-netiquette

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [Bug 212379] AMD GPIO chip IRQs stops working (ELN4690, WCOM51C7, BMA250E)
  2021-04-26 22:04   ` [Bug 212379] AMD GPIO chip IRQs stops working (ELN4690, WCOM51C7, BMA250E) Borislav Petkov
@ 2021-04-27 14:10     ` Andy Shevchenko
  2021-04-27 14:25       ` Andy Shevchenko
  0 siblings, 1 reply; 6+ messages in thread
From: Andy Shevchenko @ 2021-04-27 14:10 UTC (permalink / raw)
  To: Borislav Petkov, Coiby Xu, Ken Xue, Jeff, Nehal Shah, Shyam Sundar S K
  Cc: vectorflaredesigns, Linus Walleij, open list:GPIO SUBSYSTEM, lkml

+Cc: authors and contents per driver source code along with Coiby who
fixed touchpad issues in the past in the same driver.

On Tue, Apr 27, 2021 at 1:04 AM Borislav Petkov <bp@alien8.de> wrote:
>
> Switching to mail...
>
> On Mon, Apr 26, 2021 at 09:04:38PM +0000, bugzilla-daemon@bugzilla.kernel.org wrote:
> > https://bugzilla.kernel.org/show_bug.cgi?id=212379
> >
> > --- Comment #15 from Austin Kilgore (vectorflaredesigns@gmail.com) ---
> > Is this ever going to get looked at?
> >
> > Did I need to @ mention someone? Honestly asking since I don't know what to do.
> > I don't even know who needs to be told to take a look at this.
> >
> > Like I said, if this bug report is lacking information just let me know and
> > I'll test, check, or upload whatever is needed. It's really important to me
> > that this gets fixed.
> >
> > --
>
> Grepping through the tree, "amd_gpio" sounds like
> drivers/pinctrl/pinctrl-amd.c so maybe Linus might have an idea, CCed.
>
> @Linus, the bugzilla entry has some more info on what happens.
>
> @Austin: in the future, please do not CC everyone including the
> postmaster on your bug. Now you're mass-spamming 50+ people
> unnecessarily.
>
> Thx.
>
> --
> Regards/Gruss,
>     Boris.
>
> https://people.kernel.org/tglx/notes-about-netiquette



-- 
With Best Regards,
Andy Shevchenko

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [Bug 212379] AMD GPIO chip IRQs stops working (ELN4690, WCOM51C7, BMA250E)
  2021-04-27 14:10     ` Andy Shevchenko
@ 2021-04-27 14:25       ` Andy Shevchenko
  2021-04-27 23:42         ` Daniel Drake
  2021-04-29 14:31         ` Linus Walleij
  0 siblings, 2 replies; 6+ messages in thread
From: Andy Shevchenko @ 2021-04-27 14:25 UTC (permalink / raw)
  To: Borislav Petkov, Coiby Xu, Ken Xue, Nehal Shah, Shyam Sundar S K,
	Daniel Drake
  Cc: vectorflaredesigns, Linus Walleij, open list:GPIO SUBSYSTEM, lkml

On Tue, Apr 27, 2021 at 5:10 PM Andy Shevchenko
<andy.shevchenko@gmail.com> wrote:
>
> +Cc: authors and contents per driver source code along with Coiby who
> fixed touchpad issues in the past in the same driver.
>
> On Tue, Apr 27, 2021 at 1:04 AM Borislav Petkov <bp@alien8.de> wrote:
> >
> > Switching to mail...
> >
> > On Mon, Apr 26, 2021 at 09:04:38PM +0000, bugzilla-daemon@bugzilla.kernel.org wrote:
> > > https://bugzilla.kernel.org/show_bug.cgi?id=212379
> > >
> > > --- Comment #15 from Austin Kilgore (vectorflaredesigns@gmail.com) ---
> > > Is this ever going to get looked at?
> > >
> > > Did I need to @ mention someone? Honestly asking since I don't know what to do.
> > > I don't even know who needs to be told to take a look at this.
> > >
> > > Like I said, if this bug report is lacking information just let me know and
> > > I'll test, check, or upload whatever is needed. It's really important to me
> > > that this gets fixed.
> > >
> > > --
> >
> > Grepping through the tree, "amd_gpio" sounds like
> > drivers/pinctrl/pinctrl-amd.c so maybe Linus might have an idea, CCed.
> >
> > @Linus, the bugzilla entry has some more info on what happens.
> >
> > @Austin: in the future, please do not CC everyone including the
> > postmaster on your bug. Now you're mass-spamming 50+ people
> > unnecessarily.

Looking into history of changes it might be related to (Cc Daniel as well):

commit d21b8adbd475dba19ac2086d3306327b4a297418
Author: Daniel Drake <drake@endlessm.com>
Date:   Wed Aug 14 17:05:40 2019 +0800

   pinctrl: amd: disable spurious-firing GPIO IRQs


-- 
With Best Regards,
Andy Shevchenko

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [Bug 212379] AMD GPIO chip IRQs stops working (ELN4690, WCOM51C7, BMA250E)
  2021-04-27 14:25       ` Andy Shevchenko
@ 2021-04-27 23:42         ` Daniel Drake
  2021-04-29 14:31         ` Linus Walleij
  1 sibling, 0 replies; 6+ messages in thread
From: Daniel Drake @ 2021-04-27 23:42 UTC (permalink / raw)
  To: Andy Shevchenko
  Cc: Borislav Petkov, Coiby Xu, Ken Xue, Nehal Shah, Shyam Sundar S K,
	vectorflaredesigns, Linus Walleij, open list:GPIO SUBSYSTEM,
	lkml

On Tue, Apr 27, 2021 at 10:25 PM Andy Shevchenko
<andy.shevchenko@gmail.com> wrote:
> Looking into history of changes it might be related to (Cc Daniel as well):
>
> commit d21b8adbd475dba19ac2086d3306327b4a297418
> Author: Daniel Drake <drake@endlessm.com>
> Date:   Wed Aug 14 17:05:40 2019 +0800
>
>    pinctrl: amd: disable spurious-firing GPIO IRQs

I think it's unlikely to be related (seems like the affected drivers
are claiming their IRQs so this would have no effect), but good to
poke every angle of course.
This could be confirmed by enabling dyndbg to see if the "Disabling
spurious GPIO" message gets emitted.

There's also a debugfs dump file for amd_gpio, could be useful to
compare this before & after the failure.

Daniel

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [Bug 212379] AMD GPIO chip IRQs stops working (ELN4690, WCOM51C7, BMA250E)
  2021-04-27 14:25       ` Andy Shevchenko
  2021-04-27 23:42         ` Daniel Drake
@ 2021-04-29 14:31         ` Linus Walleij
  2021-04-29 14:58           ` Borislav Petkov
  1 sibling, 1 reply; 6+ messages in thread
From: Linus Walleij @ 2021-04-29 14:31 UTC (permalink / raw)
  To: Andy Shevchenko
  Cc: Borislav Petkov, Coiby Xu, Ken Xue, Nehal Shah, Shyam Sundar S K,
	Daniel Drake, vectorflaredesigns, open list:GPIO SUBSYSTEM, lkml,
	Hans de Goede

> > > Grepping through the tree, "amd_gpio" sounds like
> > > drivers/pinctrl/pinctrl-amd.c so maybe Linus might have an idea, CCed.
> > >
> > > @Linus, the bugzilla entry has some more info on what happens.

I have no clue, someone with deeper understanding of AMDs bridges
and stuff need to look at this. Since it dies after a while I would
suspect power management by the BIOS. (Off the top of my head.)
SInce I guess these systems use BIOS ACPI for all PM.

If someone from AMD could pick up this bug, that would be great.

Yours,
Linus Walleij

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [Bug 212379] AMD GPIO chip IRQs stops working (ELN4690, WCOM51C7, BMA250E)
  2021-04-29 14:31         ` Linus Walleij
@ 2021-04-29 14:58           ` Borislav Petkov
  0 siblings, 0 replies; 6+ messages in thread
From: Borislav Petkov @ 2021-04-29 14:58 UTC (permalink / raw)
  To: Linus Walleij
  Cc: Andy Shevchenko, Coiby Xu, Ken Xue, Nehal Shah, Shyam Sundar S K,
	Daniel Drake, vectorflaredesigns, open list:GPIO SUBSYSTEM, lkml,
	Hans de Goede

On Thu, Apr 29, 2021 at 04:31:18PM +0200, Linus Walleij wrote:
> I have no clue, someone with deeper understanding of AMDs bridges
> and stuff need to look at this. Since it dies after a while I would
> suspect power management by the BIOS. (Off the top of my head.)
> SInce I guess these systems use BIOS ACPI for all PM.
> 
> If someone from AMD could pick up this bug, that would be great.

Thanks for looking. I have it on a good authority that something like
that is happening now.

:-)

-- 
Regards/Gruss,
    Boris.

https://people.kernel.org/tglx/notes-about-netiquette

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2021-04-29 14:58 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
     [not found] <bug-212379-6385@https.bugzilla.kernel.org/>
     [not found] ` <bug-212379-6385-VMOjMpWM97@https.bugzilla.kernel.org/>
2021-04-26 22:04   ` [Bug 212379] AMD GPIO chip IRQs stops working (ELN4690, WCOM51C7, BMA250E) Borislav Petkov
2021-04-27 14:10     ` Andy Shevchenko
2021-04-27 14:25       ` Andy Shevchenko
2021-04-27 23:42         ` Daniel Drake
2021-04-29 14:31         ` Linus Walleij
2021-04-29 14:58           ` Borislav Petkov

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.