From: Andy Shevchenko <andy.shevchenko@gmail.com>
To: u-boot@lists.denx.de
Subject: [PATCH v2 2/7] console: Keep ->start() and ->stop() balanced
Date: Thu, 17 Dec 2020 11:48:22 +0200 [thread overview]
Message-ID: <CAHp75VfQj_k_40gSxQpc_ZXw2PUDF_zTyNV6=CYOzu4hEFzLPg@mail.gmail.com> (raw)
In-Reply-To: <20201216231624.9724-2-andriy.shevchenko@linux.intel.com>
On Thu, Dec 17, 2020 at 1:16 AM Andy Shevchenko
<andriy.shevchenko@linux.intel.com> wrote:
> There is no need to call ->start() for already started device. All the same,
an already
> there is no need to call ->stop() for devices still in use.
>
> For now enforce this only for CONSOLE_MUX case.
now, enforce
the CONSOLE_MUX
...
> +static bool console_needs_handle(int file, struct stdio_dev *dev)
> +{
> + int i;
> +
> + for (i = 0; i < cd_count[file]; i++)
> + if (console_devices[file][i] == dev)
> + return false;
Actually this is no-op. I realized it later on.
It misses the iteration over all files. And file argument to exclude
iteration over that specific file.
I will update this, but will also wait a couple of days for other
comments against the series.
> + return true;
> +}
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2020-12-17 9:48 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-16 23:16 [PATCH v2 1/7] console: Introduce console_start() and console_stop() Andy Shevchenko
2020-12-16 23:16 ` [PATCH v2 2/7] console: Keep ->start() and ->stop() balanced Andy Shevchenko
2020-12-17 9:48 ` Andy Shevchenko [this message]
2020-12-19 2:29 ` Simon Glass
2020-12-16 23:16 ` [PATCH v2 3/7] IOMUX: move search_device() to console.h Andy Shevchenko
2020-12-19 2:29 ` Simon Glass
2020-12-16 23:16 ` [PATCH v2 4/7] IOMUX: Preserve console list if realloc() fails Andy Shevchenko
2020-12-19 2:29 ` Simon Glass
2020-12-21 12:01 ` Andy Shevchenko
2020-12-21 16:47 ` Simon Glass
2020-12-21 17:17 ` Andy Shevchenko
2020-12-21 17:33 ` Simon Glass
2020-12-16 23:16 ` [PATCH v2 5/7] IOMUX: Refactor iomux_doenv() in order to increase readability Andy Shevchenko
2020-12-19 2:29 ` Simon Glass
2020-12-21 12:04 ` Andy Shevchenko
2020-12-21 16:47 ` Simon Glass
2020-12-16 23:16 ` [PATCH v2 6/7] IOMUX: Drop indentation level by removing redundant 'else' Andy Shevchenko
2020-12-19 2:29 ` Simon Glass
2020-12-16 23:16 ` [PATCH v2 7/7] IOMUX: Stop dropped consoles Andy Shevchenko
2020-12-19 2:29 ` Simon Glass
2020-12-19 2:29 ` [PATCH v2 1/7] console: Introduce console_start() and console_stop() Simon Glass
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAHp75VfQj_k_40gSxQpc_ZXw2PUDF_zTyNV6=CYOzu4hEFzLPg@mail.gmail.com' \
--to=andy.shevchenko@gmail.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.