All of lore.kernel.org
 help / color / mirror / Atom feed
From: Simon Glass <sjg@chromium.org>
To: u-boot@lists.denx.de
Subject: [PATCH v2 3/7] IOMUX: move search_device() to console.h
Date: Fri, 18 Dec 2020 19:29:17 -0700	[thread overview]
Message-ID: <CAPnjgZ1D0UGhvapFWN+jRj24zCFy4sQOAiDfDC9RQ7TEw6BtCw@mail.gmail.com> (raw)
In-Reply-To: <20201216231624.9724-3-andriy.shevchenko@linux.intel.com>

On Wed, 16 Dec 2020 at 16:16, Andy Shevchenko
<andriy.shevchenko@linux.intel.com> wrote:
>
> search_device() is defined in console.c. Move its declaration
> to an appropriate header file.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ---
> v2: new patch
>  include/console.h | 2 ++
>  include/iomux.h   | 1 -
>  2 files changed, 2 insertions(+), 1 deletion(-)

Reviewed-by: Simon Glass <sjg@chromium.org>

>
> diff --git a/include/console.h b/include/console.h
> index 233ff323e1ee..79f9534a9535 100644
> --- a/include/console.h
> +++ b/include/console.h
> @@ -25,6 +25,8 @@ void clear_ctrlc(void);       /* clear the Control-C condition */
>  int disable_ctrlc(int);        /* 1 to disable, 0 to enable Control-C detect */
>  int confirm_yesno(void);        /*  1 if input is "y", "Y", "yes" or "YES" */
>
> +struct stdio_dev *search_device(int flags, const char *name);
> +
>  #ifdef CONFIG_CONSOLE_RECORD
>  /**
>   * console_record_init() - set up the console recording buffers
> diff --git a/include/iomux.h b/include/iomux.h
> index e6e1097db5b2..da7ff697d218 100644
> --- a/include/iomux.h
> +++ b/include/iomux.h
> @@ -26,6 +26,5 @@ extern int cd_count[MAX_FILES];
>
>  int iomux_doenv(const int, const char *);
>  void iomux_printdevs(const int);
> -struct stdio_dev *search_device(int, const char *);

Please add a full function comment

Also consider renaming it to console_search_dev() or similar, since it
is in console.h

>
>  #endif /* _IO_MUX_H */
> --
> 2.29.2
>

Regards,
Simon

  reply	other threads:[~2020-12-19  2:29 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-12-16 23:16 [PATCH v2 1/7] console: Introduce console_start() and console_stop() Andy Shevchenko
2020-12-16 23:16 ` [PATCH v2 2/7] console: Keep ->start() and ->stop() balanced Andy Shevchenko
2020-12-17  9:48   ` Andy Shevchenko
2020-12-19  2:29   ` Simon Glass
2020-12-16 23:16 ` [PATCH v2 3/7] IOMUX: move search_device() to console.h Andy Shevchenko
2020-12-19  2:29   ` Simon Glass [this message]
2020-12-16 23:16 ` [PATCH v2 4/7] IOMUX: Preserve console list if realloc() fails Andy Shevchenko
2020-12-19  2:29   ` Simon Glass
2020-12-21 12:01     ` Andy Shevchenko
2020-12-21 16:47       ` Simon Glass
2020-12-21 17:17         ` Andy Shevchenko
2020-12-21 17:33           ` Simon Glass
2020-12-16 23:16 ` [PATCH v2 5/7] IOMUX: Refactor iomux_doenv() in order to increase readability Andy Shevchenko
2020-12-19  2:29   ` Simon Glass
2020-12-21 12:04     ` Andy Shevchenko
2020-12-21 16:47       ` Simon Glass
2020-12-16 23:16 ` [PATCH v2 6/7] IOMUX: Drop indentation level by removing redundant 'else' Andy Shevchenko
2020-12-19  2:29   ` Simon Glass
2020-12-16 23:16 ` [PATCH v2 7/7] IOMUX: Stop dropped consoles Andy Shevchenko
2020-12-19  2:29   ` Simon Glass
2020-12-19  2:29 ` [PATCH v2 1/7] console: Introduce console_start() and console_stop() Simon Glass

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAPnjgZ1D0UGhvapFWN+jRj24zCFy4sQOAiDfDC9RQ7TEw6BtCw@mail.gmail.com \
    --to=sjg@chromium.org \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.